mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug]: OPML Import Failed #2079
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#2079
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @hardwareadictos on GitHub (Jul 5, 2024).
What happened?
WWhen i import an opml file from AntennaPod/Pocketcast podcastUtils crashes and doesn't import any subscription
What did you expect to happen?
Podcasts being imported from OPML file, even if any suscription doesnt exists anymore or returns a 404 error
Steps to reproduce the issue
Just importing an opml file on the web UI
Audiobookshelf version
v2.10.1
How are you running audiobookshelf?
Docker
What OS is your Audiobookshelf server hosted from?
Windows
If the issue is being seen in the UI, what browsers are you seeing the problem on?
None
Logs
Additional Notes
OPML file: https://pastecode.io/s/j10cuenc
@mikiher commented on GitHub (Jul 10, 2024):
I tried importing your OPML, and it successfully imported all the podcasts that it did find.
There were many podcasts in the list for which the podcast feed link is broken or empty, and therefore you get errors for those - that is normal. You said: "podcastUtils crashes and doesn't import any subscription". Is the server actually crashing? when I tried it, I saw no crush, but the import took quite a bit of time (maybe 5-10 minutes), due to the large number of feeds.
What would you want Audiobookshelf to do with a podcast that does not have a working feed? If it doesn't have a feed it's not actionable (you cannot search and download episodes, you cannot display its cover image - you can't do anything with it).
@hardwareadictos commented on GitHub (Jul 10, 2024):
Nice! I didn't wait those five minutes as i saw lots of 404 errors on the logs, glad it worked for you.
I'm going to reproduce it and see if it works.
@hardwareadictos commented on GitHub (Jul 10, 2024):
Well, still the same. I just load the OPML file and it crashes 2/3 minutes later:
Which browser are you using? I tried Edge on Windows Server 2019, and Edge/Firefox on OpenSUSE.
@mikiher commented on GitHub (Jul 10, 2024):
I doubt the browser is the issue here (this is all happening on the server).
So, just to be clear, what I see in your screenshots is a message saying "Failed to parse OPML file". I don't see a crash - so the server is still running, but the OPML import fails, correct?
@hardwareadictos commented on GitHub (Jul 10, 2024):
yes. that's it!
@mikiher commented on GitHub (Jul 10, 2024):
Can I ask you to please set Audiobookshelf
Server Log Level(inSettings->Logs) toDebug, and try to import the OPML again?After that can you please attach the latest actual log file from the server? It can be found at
/metadata/logs/dailyAlso if there's any crash log at
/metadata/logs/crash_logs.txt, please attach that as well.@hardwareadictos commented on GitHub (Jul 10, 2024):
Done! Uploading the logs, just search on todays log from 12:00 and beyond, on crash logs you will see something about SQLITE DB crashing, i think (but im not sure) that's realted to another issue i opened: https://github.com/advplyr/audiobookshelf/issues/3123
crash_logs.txt
2024-07-10.txt
@mikiher commented on GitHub (Jul 10, 2024):
OK, thanks for sending the logs. The logs seem to indicate that the OPML upload operation on the server finished successfuly, so I'm suspecting maybe some timeout or another connection-related error between the browser and the server.
Can I ask you to open the developer tools on the browser (f12 on Chrome and Edge), and go to the Console tab. Then try to import the opml file again, and wait for the "Failed to parse OPML file" message. Please check if some error message is printed to the console at same time the "Failed to parse OPML file" message appears, and paste it here.
@hardwareadictos commented on GitHub (Jul 10, 2024):
And you were right:
Error 504. I'm runing under an nginx proxy manager with websockets enabled.
BUT: If i attack de service via the internal ip:port i am able to get all the podcasts correctly and i can add them to my library!!:
So something in the proxy is giving those timeouts. Let me check the proxy and the documentation.
EDIT: as of the documentation, only websockets needs to be enabled so let me investigate how to make those timeouts bigger to avoid the 502 error on Nginx Proxy Manager.
@hardwareadictos commented on GitHub (Jul 10, 2024):
Okay seems that adding
proxy_read_timeout 600s(10 minutes in my case because the opml was taking 5 mins to import through the proxy); to Advanced tab on the proxy host helps:Let me test this fore some days and i will report back :)
@mikiher commented on GitHub (Jul 10, 2024):
@advplyr that's an interesting type of failure. We should probably make the OPML import a non-blocking task like metadata embedding. What do you think?
@advplyr commented on GitHub (Jul 12, 2024):
Yeah we definitely should. We may have to skip the confirmation step then and just add the podcasts. Showing a task in the appbar.
@github-actions[bot] commented on GitHub (Aug 5, 2024):
Fixed in v2.12.0.