mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug]: embedded chapters are not properly extracted from multiple m4b #2061
Closed
opened 2026-04-25 00:03:03 +02:00 by adam
·
5 comments
No Branch/Tag Specified
master
book_tags_genres_dedupe
episode_download_fallback
Issue-4540-SortBy-StartedDate-and-FinishedDate
episode_meta_tagging
fix_authorize_race_condition
redirect_transcode_requests
progress_updated_sort
fix_ereader_socket_event
fix_change_empty_root_password
fix_podcast_session_track_index
fix_set_token
session_modal_user
localize_durations
fix_oidc_create_user
jwt_auth_refactor
fix_scanner_deleting_single_file_books
fix_mediaprogress_updatedat_2
experimental_next_client
podcast_episode_duration
episode-timestamps-clickable
book_author_secondary_sort_title
podcast_useragents
pathexists_user_access
fix_pathexists_join
book_author_secondary_sort
clean_duplicate_mediaprogress
sanitize_html_description
trix_prevent_attachments
check_path_api_fix
fix_mediaprogress_updatedat
increase_express_json_limit
fix_dockerfile_nunicode
search_episodes
audiobook_tools_update
episode_secondary_sorts
hls_stream_url_update
new_session_track_endpoint
audiobook_tools_enhancements
watcher_rescans_update
player_track_tooltip
fix_exclude_prefixes_crash
socket_item_events
fix_podcast_episode_scanner_promise
new_stats_controller
count_cache_for_userpermissions
parsing-opf-v3
validate_migration_files
fix-quick-match-all-crash
fix-chapter-end-sleep-timer
stringify_sequelize_query
remove-col-ambiguity
fix_next_prev_edit_description
details_trim_whitespace
fix_content_url_basepath
fix_logger_fatal
progress_bar_visibility
batch-edit-populate-map-details
feed_generator_updates
bookmark-modal-updates
migrate-library-item-in-scanner
migrate-new-library-items
migrate-podcasts-new-library-item-2
migrate-podcasts-new-library-item
fix-remove-episode-from-playlist
playback-session-use-new-library-item
refactor-library-item
fix-heatmap-caption
feed-episodes-upsert
share-media-player-media-session-api
remove-old-playlist
remove_old_collection_object
plugin-implementation-demo
feed_migration
refactor-feeds-from-item
fix_remove_authors_no_books
v2.17.3-fk-constraints-migration
migrations-first-upgrade
sqlite_2
feature/nuxt-target-server
waveform
sqlite
playlists
video
v2.35.1
v2.35.0
v2.34.0
v2.33.2
v2.33.1
v2.33.0
v2.32.1
v2.32.0
v2.31.0
v2.30.0
v2.29.0
v2.28.0
v2.27.0
v2.26.3
v2.26.2
v2.26.1
v2.26.0
v2.25.1
v2.25.0
v2.24.0
v2.23.0
v2.22.0
v2.21.0
v2.20.0
v2.19.5
v2.19.4
v2.19.3
v2.19.2
v2.19.1
v2.19.0
v2.18.1
v2.18.0
v2.17.7
v2.17.6
v2.17.5
v2.17.4
v2.17.3
v2.17.2
v2.17.1
v2.17.0
v2.16.2
v2.16.1
v2.16.0
v2.15.1
v2.15.0
v2.14.0
v2.13.4
v2.13.3
v2.13.2
v2.13.1
v2.13.0
v2.12.3
v2.12.2
v2.12.1
v2.12.0
v2.11.0
v2.10.1
v2.10.0
v2.9.0
v2.8.1
v2.8.0
v2.7.2
v2.7.1
v2.7.0
v2.6.0
v2.5.0
v2.4.4
v2.4.3
v2.4.2
v2.4.1
v2.4.0
v2.3.5
v2.3.4
v2.3.3
v2.3.2
v2.3.1
v2.3.0
v2.2.23
v2.2.22
v2.2.21
v2.2.20
v2.2.19
v2.2.18
v2.2.17
v2.2.16
v2.2.15
v2.2.14
v2.2.13
v2.2.12
v2.2.11
v2.2.10
v2.2.9
v2.2.8
v2.2.7
v2.2.6
v2.2.5
v2.2.4
v2.2.3
v2.2.2
v2.2.1
v2.2.0
v2.1.5
v2.1.4
v2.1.3
v2.1.2
v2.1.1
v2.1.0
v2.0.24
v2.0.23
v2.0.22
v2.0.21
v2.0.20
v2.0.19
v2.0.18
v2.0.17
v2.0.16
v2.0.15
v2.0.14
v2.0.13
v2.0.12
v2.0.11
v2.0.10
v2.0.9
v2.0.8
v2.0.7
v2.0.6
v2.0.5
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v1.7.2
v1.7.1
v1.7.0
v1.6.0
v1.5.5
v1.5.0
v1.4.11
v1.4.9
v1.4.7
v1.4.6
v1.4.4
v1.4.2
v1.4.0
v1.4.1
v1.3.4
v1.3.3
v1.3.1
v1.2.8
v1.2.6
v1.2.5
v1.2.4
v1.2.1
v1.1.15
v1.1.14
v1.1.13
v1.1.12
v1.1.11
v1.1.10
v1.1.9
v1.1.8
v1.0.0
0.9.61-beta.0
0.9.61-beta
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
Mirrored from GitHub Pull Request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
adam (Adam Melkus)
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#2061
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @random-human-being on GitHub (Jun 17, 2024).
What happened?
Most m4b audiobooks are composed of a single file with embedded chapters, or of several file each corresponding to one chapter. Both are properly scanned.
Some instances exist where a long-ish m4b is split into two or three smaller m4b, each with its embedded chapter list. This happens, for instance, with some Japanese audiobooks, which are split into a 上 (up/first) and 下 (down/second) volume.
When this happens, the chapters of the first volume are properly extracted, while those of the second (and further) volume(s) are ignored. This leads to the latter half (or more) of the audiobook being devoid of chapters.
What did you expect to happen?
Chapters and timestamps should be extracted from all files.
Timestamps for files after the first one should be shifted as needed.
Steps to reproduce the issue
Add an audiobook divided into two or more parts, each with its embedded chapter metadata. Here is an example:
Mediainfo file 1
Mediainfo file 2
After it has been imported into the library, check its chapters and verify that only those from the first file have been imported.
Audiobookshelf version
v2.10.1
How are you running audiobookshelf?
Docker
What OS is your Audiobookshelf server hosted from?
Linux
If the issue is being seen in the UI, what browsers are you seeing the problem on?
None
Logs
No response
Additional Notes
No response
@advplyr commented on GitHub (Jun 17, 2024):
The reason is because the chapter titles are the same. Sometimes audiobooks have multiple files and have all of the chapters embedded into each file so if we can't always merge the files, we need to check that they are different.
https://github.com/advplyr/audiobookshelf/blob/a75ad5d6594274a6ea048e246a1cedbd2dc72cd1/server/scanner/AudioFileScanner.js#L464-L474
Update: copied the wrong code snippet
@advplyr commented on GitHub (Jun 18, 2024):
I'm looking at this again and since the timestamps are different the chapters should have still been merged. I was incorrect in saying it only checks the chapter titles (as shown in the code snippet). It checks the start time and titles to check if it should merge the chapters.
Since Abs uses ffprobe to get the chapter information, can you share the ffprobe output of those same 2 files?
You can do this using Abs: https://www.audiobookshelf.org/guides/ffprobe#inspecting-an-audio-file
@random-human-being commented on GitHub (Jun 19, 2024):
I'm wondering if the issue is not with the files themselves. Unless I am doing something wrong, ffprobe gives the following errors:
ffprobe file 1
ffprobe file 2
Both play fine via VLC and MPC though.
@advplyr commented on GitHub (Jun 19, 2024):
If you are referring to the message
Unsupported codecat the bottom then this can be ignored. I see this from ffprobe also for m4b files with embedded chapters.Is it possible you added the second file after the first file had already been scanned in?
Abs does not update chapters after the initial scan. To pull in chapters again fresh after you add audio files you can press "Edit chapters" and delete the existing chapters. Then press edit on the book and "Re-Scan".
From what I can see the ffprobe outputs look fine. It would be better to check within Abs like it shows in the guide that I linked because then we would be sure that Abs is pulling the chapters in.
@random-human-being commented on GitHub (Jun 21, 2024):
I have removed both m4b from the filesystem, then and re-added them. Now they indeed show up as expected.
I guess when I first transferred them to my server one, of them finished being copied slightly before the other did, by just enough time that abs was able to complete a scan of the former.
Well, that being the case, apologies for my oversight.