mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug]: After metadata match completes, screen refreshes again adding bad data. #206
Closed
opened 2026-04-24 23:01:07 +02:00 by adam
·
10 comments
No Branch/Tag Specified
master
book_tags_genres_dedupe
episode_download_fallback
Issue-4540-SortBy-StartedDate-and-FinishedDate
episode_meta_tagging
fix_authorize_race_condition
redirect_transcode_requests
progress_updated_sort
fix_ereader_socket_event
fix_change_empty_root_password
fix_podcast_session_track_index
fix_set_token
session_modal_user
localize_durations
fix_oidc_create_user
jwt_auth_refactor
fix_scanner_deleting_single_file_books
fix_mediaprogress_updatedat_2
experimental_next_client
podcast_episode_duration
episode-timestamps-clickable
book_author_secondary_sort_title
podcast_useragents
pathexists_user_access
fix_pathexists_join
book_author_secondary_sort
clean_duplicate_mediaprogress
sanitize_html_description
trix_prevent_attachments
check_path_api_fix
fix_mediaprogress_updatedat
increase_express_json_limit
fix_dockerfile_nunicode
search_episodes
audiobook_tools_update
episode_secondary_sorts
hls_stream_url_update
new_session_track_endpoint
audiobook_tools_enhancements
watcher_rescans_update
player_track_tooltip
fix_exclude_prefixes_crash
socket_item_events
fix_podcast_episode_scanner_promise
new_stats_controller
count_cache_for_userpermissions
parsing-opf-v3
validate_migration_files
fix-quick-match-all-crash
fix-chapter-end-sleep-timer
stringify_sequelize_query
remove-col-ambiguity
fix_next_prev_edit_description
details_trim_whitespace
fix_content_url_basepath
fix_logger_fatal
progress_bar_visibility
batch-edit-populate-map-details
feed_generator_updates
bookmark-modal-updates
migrate-library-item-in-scanner
migrate-new-library-items
migrate-podcasts-new-library-item-2
migrate-podcasts-new-library-item
fix-remove-episode-from-playlist
playback-session-use-new-library-item
refactor-library-item
fix-heatmap-caption
feed-episodes-upsert
share-media-player-media-session-api
remove-old-playlist
remove_old_collection_object
plugin-implementation-demo
feed_migration
refactor-feeds-from-item
fix_remove_authors_no_books
v2.17.3-fk-constraints-migration
migrations-first-upgrade
sqlite_2
feature/nuxt-target-server
waveform
sqlite
playlists
video
v2.35.1
v2.35.0
v2.34.0
v2.33.2
v2.33.1
v2.33.0
v2.32.1
v2.32.0
v2.31.0
v2.30.0
v2.29.0
v2.28.0
v2.27.0
v2.26.3
v2.26.2
v2.26.1
v2.26.0
v2.25.1
v2.25.0
v2.24.0
v2.23.0
v2.22.0
v2.21.0
v2.20.0
v2.19.5
v2.19.4
v2.19.3
v2.19.2
v2.19.1
v2.19.0
v2.18.1
v2.18.0
v2.17.7
v2.17.6
v2.17.5
v2.17.4
v2.17.3
v2.17.2
v2.17.1
v2.17.0
v2.16.2
v2.16.1
v2.16.0
v2.15.1
v2.15.0
v2.14.0
v2.13.4
v2.13.3
v2.13.2
v2.13.1
v2.13.0
v2.12.3
v2.12.2
v2.12.1
v2.12.0
v2.11.0
v2.10.1
v2.10.0
v2.9.0
v2.8.1
v2.8.0
v2.7.2
v2.7.1
v2.7.0
v2.6.0
v2.5.0
v2.4.4
v2.4.3
v2.4.2
v2.4.1
v2.4.0
v2.3.5
v2.3.4
v2.3.3
v2.3.2
v2.3.1
v2.3.0
v2.2.23
v2.2.22
v2.2.21
v2.2.20
v2.2.19
v2.2.18
v2.2.17
v2.2.16
v2.2.15
v2.2.14
v2.2.13
v2.2.12
v2.2.11
v2.2.10
v2.2.9
v2.2.8
v2.2.7
v2.2.6
v2.2.5
v2.2.4
v2.2.3
v2.2.2
v2.2.1
v2.2.0
v2.1.5
v2.1.4
v2.1.3
v2.1.2
v2.1.1
v2.1.0
v2.0.24
v2.0.23
v2.0.22
v2.0.21
v2.0.20
v2.0.19
v2.0.18
v2.0.17
v2.0.16
v2.0.15
v2.0.14
v2.0.13
v2.0.12
v2.0.11
v2.0.10
v2.0.9
v2.0.8
v2.0.7
v2.0.6
v2.0.5
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v1.7.2
v1.7.1
v1.7.0
v1.6.0
v1.5.5
v1.5.0
v1.4.11
v1.4.9
v1.4.7
v1.4.6
v1.4.4
v1.4.2
v1.4.0
v1.4.1
v1.3.4
v1.3.3
v1.3.1
v1.2.8
v1.2.6
v1.2.5
v1.2.4
v1.2.1
v1.1.15
v1.1.14
v1.1.13
v1.1.12
v1.1.11
v1.1.10
v1.1.9
v1.1.8
v1.0.0
0.9.61-beta.0
0.9.61-beta
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
Mirrored from GitHub Pull Request
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
adam (Adam Melkus)
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#206
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @yourjelly on GitHub (Feb 14, 2022).
Describe the issue
After doing a match on an audiobook. (Particularly one with missing Metadata) The metadata fills in and then the screen refreshes and it add the genre of "audiobook" which is meaningless in application meant entirely for audiobooks. In some cases this refresh also changes the title from what was just set by the match to include things like "(Unabridged)" or ": {Series} Book {#}" which to be clear was not in the preview that you click through for the data match and is an additional change being made.
I am working on getting screenshots of it changing the title, I already dealt with this happening several times before thinking to document and report it here. It is not something that happens every time and doesn't happen once the metadata is already completed.
Steps to reproduce the issue
Audiobookshelf version
v1.6.66
How are you running audiobookshelf?
Docker / Unraid
@advplyr commented on GitHub (Feb 14, 2022):
Do you have the server setting enabled that is saving the cover art in your audiobook directory?
Are you using a remote file system where your audiobooks are stored? What OS are you running docker?
@yourjelly commented on GitHub (Feb 14, 2022):
I do, I could see how that could be triggering the refresh I'm seeing. Should I try disabling it and see if it stops.
Local fs, running on Unraid
@advplyr commented on GitHub (Feb 14, 2022):
Yeah so it seems the folder watcher is getting triggered by the added cover art, which is normal. Then the directory is scanned and the audio file is being detected as a new audio file, which would mean the inode value attached to the audio file is changing between scans.
I've only seen this happening with remote file systems, like using Unraid but storing your audiobooks on a Windows drive.
You should try scanning your entire library again to see if it is creating new audiobooks.
@yourjelly commented on GitHub (Feb 15, 2022):
I was mucking about in the folder structure last night cleaning up the rest of my library and didn't run across the issue nearly as much. The main factor was likely the cover art, but by then I had found that I preferred getting the cover art separate from the metadata (match) as the match with the most complete metadata / description didn't have the best cover art. So as course I have been unticking getting the cover from the match and it stopped the refresh. And getting the cover from the cover tab does not pull errant genres or titles.
@advplyr commented on GitHub (Feb 15, 2022):
That's good to hear. You will likely come across bigger issues when adding new audiobooks and scanning your library because there is something going on with your file system. If that happens feel free to open another issue or re-open this one.
@yourjelly commented on GitHub (Feb 15, 2022):
Interesting, because in what I was doing last night I added about 30 files, and corrected a handful that had bad folder structure and were being merged (several book files under a series folder but not individual book folders), and even in all that rearranging I had no issues. I have about another 30 I'll be migrating over from Libro tonight. Are you saying issues should pop up from scans or a force re-scan, because I didn't do the latter.
@advplyr commented on GitHub (Feb 15, 2022):
I may be misunderstanding your issue entirely. If you rename an audiobook folder by just changing the spelling and audiobookshelf creates a duplicate audiobook marking the original as missing, then it is what I expected.
Renaming an audiobook folder should just update the title or other missing book details.
@yourjelly commented on GitHub (Feb 15, 2022):
This did happen when I was moving things around in the FS last night. But, like you, I considered it expected behavior. (Plex does the same)
But this is not the original trouble I was having. The trouble I was having before was entirely contained within the audiobookshelf web ui.
@advplyr commented on GitHub (Feb 15, 2022):
The "audiobook" genre appears because the first audio file in that folder has an ID3 tag for genre with that value.
https://www.audiobookshelf.org/docs#metadata
Many audiobook audio files I have use "audiobook" as a genre, which I agree is meaningless. Maybe it is worthwhile adding a check to ignore this genre on the audio file. I'm sure the vast majority of users don't want to use this genre, only maybe some users with a lot of audio plays or podcasts, but those would be the exception.
@yourjelly commented on GitHub (Feb 15, 2022):
If that is the path you go down, while "Audiobook" was the most common, it occasionally popped up as "audiobook", "audio" and "audio book"