mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug] Local listening sessions showing on the wrong day #1844
Closed
opened 2026-04-24 23:59:45 +02:00 by adam
·
16 comments
No Branch/Tag Specified
master
book_tags_genres_dedupe
episode_download_fallback
Issue-4540-SortBy-StartedDate-and-FinishedDate
episode_meta_tagging
fix_authorize_race_condition
redirect_transcode_requests
progress_updated_sort
fix_ereader_socket_event
fix_change_empty_root_password
fix_podcast_session_track_index
fix_set_token
session_modal_user
localize_durations
fix_oidc_create_user
jwt_auth_refactor
fix_scanner_deleting_single_file_books
fix_mediaprogress_updatedat_2
experimental_next_client
podcast_episode_duration
episode-timestamps-clickable
book_author_secondary_sort_title
podcast_useragents
pathexists_user_access
fix_pathexists_join
book_author_secondary_sort
clean_duplicate_mediaprogress
sanitize_html_description
trix_prevent_attachments
check_path_api_fix
fix_mediaprogress_updatedat
increase_express_json_limit
fix_dockerfile_nunicode
search_episodes
audiobook_tools_update
episode_secondary_sorts
hls_stream_url_update
new_session_track_endpoint
audiobook_tools_enhancements
watcher_rescans_update
player_track_tooltip
fix_exclude_prefixes_crash
socket_item_events
fix_podcast_episode_scanner_promise
new_stats_controller
count_cache_for_userpermissions
parsing-opf-v3
validate_migration_files
fix-quick-match-all-crash
fix-chapter-end-sleep-timer
stringify_sequelize_query
remove-col-ambiguity
fix_next_prev_edit_description
details_trim_whitespace
fix_content_url_basepath
fix_logger_fatal
progress_bar_visibility
batch-edit-populate-map-details
feed_generator_updates
bookmark-modal-updates
migrate-library-item-in-scanner
migrate-new-library-items
migrate-podcasts-new-library-item-2
migrate-podcasts-new-library-item
fix-remove-episode-from-playlist
playback-session-use-new-library-item
refactor-library-item
fix-heatmap-caption
feed-episodes-upsert
share-media-player-media-session-api
remove-old-playlist
remove_old_collection_object
plugin-implementation-demo
feed_migration
refactor-feeds-from-item
fix_remove_authors_no_books
v2.17.3-fk-constraints-migration
migrations-first-upgrade
sqlite_2
feature/nuxt-target-server
waveform
sqlite
playlists
video
v2.35.1
v2.35.0
v2.34.0
v2.33.2
v2.33.1
v2.33.0
v2.32.1
v2.32.0
v2.31.0
v2.30.0
v2.29.0
v2.28.0
v2.27.0
v2.26.3
v2.26.2
v2.26.1
v2.26.0
v2.25.1
v2.25.0
v2.24.0
v2.23.0
v2.22.0
v2.21.0
v2.20.0
v2.19.5
v2.19.4
v2.19.3
v2.19.2
v2.19.1
v2.19.0
v2.18.1
v2.18.0
v2.17.7
v2.17.6
v2.17.5
v2.17.4
v2.17.3
v2.17.2
v2.17.1
v2.17.0
v2.16.2
v2.16.1
v2.16.0
v2.15.1
v2.15.0
v2.14.0
v2.13.4
v2.13.3
v2.13.2
v2.13.1
v2.13.0
v2.12.3
v2.12.2
v2.12.1
v2.12.0
v2.11.0
v2.10.1
v2.10.0
v2.9.0
v2.8.1
v2.8.0
v2.7.2
v2.7.1
v2.7.0
v2.6.0
v2.5.0
v2.4.4
v2.4.3
v2.4.2
v2.4.1
v2.4.0
v2.3.5
v2.3.4
v2.3.3
v2.3.2
v2.3.1
v2.3.0
v2.2.23
v2.2.22
v2.2.21
v2.2.20
v2.2.19
v2.2.18
v2.2.17
v2.2.16
v2.2.15
v2.2.14
v2.2.13
v2.2.12
v2.2.11
v2.2.10
v2.2.9
v2.2.8
v2.2.7
v2.2.6
v2.2.5
v2.2.4
v2.2.3
v2.2.2
v2.2.1
v2.2.0
v2.1.5
v2.1.4
v2.1.3
v2.1.2
v2.1.1
v2.1.0
v2.0.24
v2.0.23
v2.0.22
v2.0.21
v2.0.20
v2.0.19
v2.0.18
v2.0.17
v2.0.16
v2.0.15
v2.0.14
v2.0.13
v2.0.12
v2.0.11
v2.0.10
v2.0.9
v2.0.8
v2.0.7
v2.0.6
v2.0.5
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v1.7.2
v1.7.1
v1.7.0
v1.6.0
v1.5.5
v1.5.0
v1.4.11
v1.4.9
v1.4.7
v1.4.6
v1.4.4
v1.4.2
v1.4.0
v1.4.1
v1.3.4
v1.3.3
v1.3.1
v1.2.8
v1.2.6
v1.2.5
v1.2.4
v1.2.1
v1.1.15
v1.1.14
v1.1.13
v1.1.12
v1.1.11
v1.1.10
v1.1.9
v1.1.8
v1.0.0
0.9.61-beta.0
0.9.61-beta
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
Mirrored from GitHub Pull Request
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
adam (Adam Melkus)
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#1844
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rasmuslos on GitHub (Mar 28, 2024).
Describe the feature/enhancement
Right now the only way to modify the listing statistics is to use the sessions endpoint. But if a user has, for example, listened to an item for four hours yesterday and three hours today, but not synced their progress to the server for a few days, everything will be squashed together on the day the session is updated.
A dedicated statics endpoint you could send something like
timestamp at 00:00: time listenedwould make it possible to accurately keep track of listening statistics while the user is offline.
@advplyr commented on GitHub (Mar 28, 2024):
I believe I fixed this in v2.8.0. The problem was in the migration to sql the sequelize ORM was automatically updating the
updatedAtandcreatedAttimestamps instead of using the timestamps passed in from the local session.@rasmuslos commented on GitHub (Mar 28, 2024):
So if I want to report the time listened for yesterday I can send a session object with the
timeListenedandupdatedAtproperties with the previous values and for today I can do the same thing with the correct values?@advplyr commented on GitHub (Mar 28, 2024):
Yes but only for the
/session/localand/session/local-allendpoints. I tested this quite a bit when I made that change 2 months ago but please test it again to make sure@rasmuslos commented on GitHub (Mar 30, 2024):
So I am currently looking into implementing this and found two things:
play_local_is a good idea but I could not find this documented anywherePlaybackSessionManager.js#L147) desired behavior? Because looking atApiRouter.js#L477it seems like sessions are grouped based on their date and the session manger uses the current date, not the one the session provideshttps://github.com/advplyr/audiobookshelf/blob/93bec282d22e954097753c0210450b9f917a3e8e/server/managers/PlaybackSessionManager.js#L147
@advplyr commented on GitHub (Mar 30, 2024):
play_local_anymore. It has to be UUIDv4. I just looked at the docs and realize it is out of date so I'm going to update this now. https://api.audiobookshelf.org/#sync-local-sessionsIt has to be a UUIDv4 identifier because it is inserted into the database. This way you can send the same local playback session to the server and it will only overwrite the existing local session after it gets created.
@advplyr commented on GitHub (Mar 30, 2024):
There is one issue with the current playback sessions model that is going to require a refactor of the data model. Currently playback sessions can only store a single date. I re-read your original post and realized that it is not going to be possible to show the listening session on both days.
There is already a bug report open for that. I'm not sure yet how to handle this because I don't want to completely change everything.
@advplyr commented on GitHub (Mar 30, 2024):
I also want to reference this old commit where I fixed the
dateanddayOfWeekproperty when creating the playback session from the local playback session on the server side https://github.com/advplyr/audiobookshelf/commit/20a1d40d990b1d14750ba061a0dd808a016cb0ecThe commit I just made fixes the one you pointed out where updates to the playback session are using the current date and dayOfWeek instead of what is passed in.
@advplyr commented on GitHub (Mar 30, 2024):
Your issue is actually a duplicate of https://github.com/advplyr/audiobookshelf/issues/1445
The docs I will update with UUIDv4
@rasmuslos commented on GitHub (Mar 31, 2024):
Nice that that has been resolved!
I also wanted do ask how verbose my session objects should be. Is it enough to include the duration listened and the updated at timestamp or are there more required fields / are they automatically added when the session is inserted into the database?
@advplyr commented on GitHub (Mar 31, 2024):
It is expecting the entire playback session https://api.audiobookshelf.org/#playback-session
You don't need to include the
dateanddayOfWeek, those will be set automatically using theupdatedAttimestamp you pass in.@rasmuslos commented on GitHub (Mar 31, 2024):
Even when I create a new local session all fields like
mediaMetadatahave to be present?@advplyr commented on GitHub (Mar 31, 2024):
I'm not sure what you mean by create a new local session. The same endpoint is used for create/update and it expects the full playback session object each time because it is just overwriting that record in the db.
I have some ideas on setting up a better system for that but as of now you need to manage and pass in the full object for those offline sessions.
@rasmuslos commented on GitHub (Mar 31, 2024):
Ok, i was wondering because with the current system I have to make an API call for each item that I want to create a session for, not ideal but also not that bad.
Thanks for your help!
@advplyr commented on GitHub (Mar 31, 2024):
You only need to do that for sessions they are connected to the server for if you want to make real-time progress updates. The local listening session endpoints are for offline listening sessions. So you wouldn't be able to create the listening session via the API because they were offline when you created it.
Alternatively you can use it to sync a listening session you created via the API if for example they lose network connection part-way and they listened for an extended period of time offline that couldn't be synced
@rasmuslos commented on GitHub (Apr 1, 2024):
I want to use them for items that the user listened to that they have downloaded. I will keep track of the time listened and when the item is finished the tracked progress can be uploaded to the server, either after the playback stopped, or if no internet connection is available at the next possible time.
So i will only really be creating sessions and because I don't store the entirety of an item metadata on device the app has to make an additional call to the API to get all metadata fields to create the sessions.
This is purely to keep allow the server to keep track of the time listened, when the user has downloaded an audiobook the progress is already updated using the
api/me/progressendpoint.@advplyr commented on GitHub (Apr 22, 2024):
Fixed in v2.9.0