mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug]: Server crashes #1783
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#1783
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @digitalwm on GitHub (Mar 1, 2024).
Describe the issue
FATAL: [Server] Unhandled rejection: TypeError: Cannot read properties of undefined (reading 'authors'), promise: Promise {
audiobookshelf | TypeError: Cannot read properties of undefined (reading 'authors')
audiobookshelf | at BookScanner.scanNewBookLibraryItem (/server/scanner/BookScanner.js:446:86)
audiobookshelf | at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
audiobookshelf | at async LibraryItemScanner.scanNewLibraryItem (/server/scanner/LibraryItemScanner.js:178:24)
audiobookshelf | at async LibraryScanner.scanFolderUpdates (/server/scanner/LibraryScanner.js:584:30)
audiobookshelf | at async LibraryScanner.scanFilesChanged (/server/scanner/LibraryScanner.js:385:33)
audiobookshelf | } (Server.js:166)
Steps to reproduce the issue
Audiobookshelf version
v2.8.0
How are you running audiobookshelf?
Docker
@mikiher commented on GitHub (Mar 1, 2024):
Looking at the stack trace, the crash seems to have happened not while matching, but while the library watcher was adding a new book (but perhaps both things happened around the same time). The error itself is also very odd.
Can you please attach the full log file so I can examine what led up to the crash? you can find it under <your_metadata_dir>/logs/daily
@digitalwm commented on GitHub (Mar 3, 2024):
2024-03-01.txt
@mikiher commented on GitHub (Mar 8, 2024):
Thanks. In your server settings, Do you have "Store covers with item" enabled?
@digitalwm commented on GitHub (Mar 8, 2024):
Yes I do.
@mikiher commented on GitHub (Mar 8, 2024):
OK, then I believe I understand the root cause for this crash.
TLDR: This is caused by a race condition accessing
Database.libraryFilterData[libraryId]. This race condition happens because theStore covers with itemsetting is enabled.Analysis:
Store covers with itemenabled means that when submitting a match result with a new cover, the cover is downloaded to the book's library directory, rather than then to the book's metadata directory. Now two things happen in parallel:The two code paths above might be running interleaved due to their asynchronous nature.
Specifically, within path 1, the following happens:
1.a. Database.libraryFilterData[libraryId] is populated here
1.b Database.libraryFilterData[libraryId] is accessed here (where the crash happens).
and within code path 2, the following happens:
2.a. Database.libraryFilterData[libraryId] is deleted (since it's invalid and needs to be reread) here
Now, since the code between 1.a and 1.b is highly asynchronous, the code may run in the following sequence:
This will cause the crash we see at 1.b, since Database.libraryFilterData[libraryId] is deleted at that point.
Solution:
Database.libraryFilterData[libraryId] needs to be checked for validity right before every access.
I will work on a fix.
As a workaround until this is fixed, you can disable the
Store covers with itemsetting, or disable the library watcher.@digitalwm commented on GitHub (Mar 8, 2024):
Hi, thank you for your detailed response and workaround.
Also thank you in advance for the fix.
@advplyr commented on GitHub (Mar 17, 2024):
Fixed in v2.8.1
@digitalwm commented on GitHub (Mar 18, 2024):
Thank you again for fixing this. Much appreciated.