mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug]: Server crash when iOS app connects to server, unique constraint violation - #1763
Closed
opened 2026-04-24 23:57:25 +02:00 by adam
·
11 comments
No Branch/Tag Specified
master
book_tags_genres_dedupe
episode_download_fallback
Issue-4540-SortBy-StartedDate-and-FinishedDate
episode_meta_tagging
fix_authorize_race_condition
redirect_transcode_requests
progress_updated_sort
fix_ereader_socket_event
fix_change_empty_root_password
fix_podcast_session_track_index
fix_set_token
session_modal_user
localize_durations
fix_oidc_create_user
jwt_auth_refactor
fix_scanner_deleting_single_file_books
fix_mediaprogress_updatedat_2
experimental_next_client
podcast_episode_duration
episode-timestamps-clickable
book_author_secondary_sort_title
podcast_useragents
pathexists_user_access
fix_pathexists_join
book_author_secondary_sort
clean_duplicate_mediaprogress
sanitize_html_description
trix_prevent_attachments
check_path_api_fix
fix_mediaprogress_updatedat
increase_express_json_limit
fix_dockerfile_nunicode
search_episodes
audiobook_tools_update
episode_secondary_sorts
hls_stream_url_update
new_session_track_endpoint
audiobook_tools_enhancements
watcher_rescans_update
player_track_tooltip
fix_exclude_prefixes_crash
socket_item_events
fix_podcast_episode_scanner_promise
new_stats_controller
count_cache_for_userpermissions
parsing-opf-v3
validate_migration_files
fix-quick-match-all-crash
fix-chapter-end-sleep-timer
stringify_sequelize_query
remove-col-ambiguity
fix_next_prev_edit_description
details_trim_whitespace
fix_content_url_basepath
fix_logger_fatal
progress_bar_visibility
batch-edit-populate-map-details
feed_generator_updates
bookmark-modal-updates
migrate-library-item-in-scanner
migrate-new-library-items
migrate-podcasts-new-library-item-2
migrate-podcasts-new-library-item
fix-remove-episode-from-playlist
playback-session-use-new-library-item
refactor-library-item
fix-heatmap-caption
feed-episodes-upsert
share-media-player-media-session-api
remove-old-playlist
remove_old_collection_object
plugin-implementation-demo
feed_migration
refactor-feeds-from-item
fix_remove_authors_no_books
v2.17.3-fk-constraints-migration
migrations-first-upgrade
sqlite_2
feature/nuxt-target-server
waveform
sqlite
playlists
video
v2.35.1
v2.35.0
v2.34.0
v2.33.2
v2.33.1
v2.33.0
v2.32.1
v2.32.0
v2.31.0
v2.30.0
v2.29.0
v2.28.0
v2.27.0
v2.26.3
v2.26.2
v2.26.1
v2.26.0
v2.25.1
v2.25.0
v2.24.0
v2.23.0
v2.22.0
v2.21.0
v2.20.0
v2.19.5
v2.19.4
v2.19.3
v2.19.2
v2.19.1
v2.19.0
v2.18.1
v2.18.0
v2.17.7
v2.17.6
v2.17.5
v2.17.4
v2.17.3
v2.17.2
v2.17.1
v2.17.0
v2.16.2
v2.16.1
v2.16.0
v2.15.1
v2.15.0
v2.14.0
v2.13.4
v2.13.3
v2.13.2
v2.13.1
v2.13.0
v2.12.3
v2.12.2
v2.12.1
v2.12.0
v2.11.0
v2.10.1
v2.10.0
v2.9.0
v2.8.1
v2.8.0
v2.7.2
v2.7.1
v2.7.0
v2.6.0
v2.5.0
v2.4.4
v2.4.3
v2.4.2
v2.4.1
v2.4.0
v2.3.5
v2.3.4
v2.3.3
v2.3.2
v2.3.1
v2.3.0
v2.2.23
v2.2.22
v2.2.21
v2.2.20
v2.2.19
v2.2.18
v2.2.17
v2.2.16
v2.2.15
v2.2.14
v2.2.13
v2.2.12
v2.2.11
v2.2.10
v2.2.9
v2.2.8
v2.2.7
v2.2.6
v2.2.5
v2.2.4
v2.2.3
v2.2.2
v2.2.1
v2.2.0
v2.1.5
v2.1.4
v2.1.3
v2.1.2
v2.1.1
v2.1.0
v2.0.24
v2.0.23
v2.0.22
v2.0.21
v2.0.20
v2.0.19
v2.0.18
v2.0.17
v2.0.16
v2.0.15
v2.0.14
v2.0.13
v2.0.12
v2.0.11
v2.0.10
v2.0.9
v2.0.8
v2.0.7
v2.0.6
v2.0.5
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v1.7.2
v1.7.1
v1.7.0
v1.6.0
v1.5.5
v1.5.0
v1.4.11
v1.4.9
v1.4.7
v1.4.6
v1.4.4
v1.4.2
v1.4.0
v1.4.1
v1.3.4
v1.3.3
v1.3.1
v1.2.8
v1.2.6
v1.2.5
v1.2.4
v1.2.1
v1.1.15
v1.1.14
v1.1.13
v1.1.12
v1.1.11
v1.1.10
v1.1.9
v1.1.8
v1.0.0
0.9.61-beta.0
0.9.61-beta
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
Mirrored from GitHub Pull Request
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
adam (Adam Melkus)
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#1763
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rakorea on GitHub (Feb 25, 2024).
Describe the issue
When connecting iOS Application v0.9.72-beta to server 2.8.0, server crashes.
Checked that the server code in question does seem to check if session exists, but I still get the following log:
After app restart the connection works fine. Looks like race condition to me, but I'm not a Node dev. Whether this is mobile app misbehaving and somehow throwing 2 concurrent threads to server is beyond me, server crashing here is obviously not ideal.
https://github.com/advplyr/audiobookshelf/blob/d8b9f08e5a00b113e33367e1d4ed5ef593d02b18/server/managers/PlaybackSessionManager.js#L136
Running the server on Qnap NAS, installed via .qpkg package from https://www.myqnap.org/product/audiobookshelf/
Steps to reproduce the issue
Unfortunately have not found bullet proof way to reproduce. Usage pattern is usually:
This results to server crashing almost daily.
Audiobookshelf version
2.8.0
How are you running audiobookshelf?
Other
@advplyr commented on GitHub (Feb 25, 2024):
Is the
/configfolder on a network drive?@rakorea commented on GitHub (Feb 25, 2024):
No, everything is local on the server
@mikiher commented on GitHub (Mar 2, 2024):
What seems suspicious about log above is that the same line appears twice in succession within a short timeframe:
It does smell like a race condition...
@zugao commented on GitHub (Mar 19, 2024):
I also encountered the same issue after connecting to the server
@TobiasDax commented on GitHub (Jul 11, 2024):
Still the same issue
@Marvin-D-Martian commented on GitHub (Sep 14, 2024):
I think I have the same issue. My docker crashes without any info in the docker log. I posted about this on r/audiobookshelf and just including my data here in case it helps...
All latest versions
All works well, until it doesn't.
When using Shelf Player, I can see
Device - Audiobooks iOS 2.13.4 Play method - Direct Play
When using Plappa:
Device - plappa 1.4.2 Play method - unknown
All the duplicate listening session have variious play times. I am obviously only using Plappa, just tried ShelfPlayer to see if it actually recognises play method.
Log is attached below, but from what I can see, there is abunch of Listening Session for the same user and book, with various times.
FATAL [Server] Unhandled rejection: SequelizeUniqueConstraintError: Validation error, promise: Promise { <rejected> Error at Database.<anonymous> (/node_modules/sequelize/lib/dialects/sqlite/query.js:185:27) at /node_moduIes/sequelize/Iib/dialects/sqlite/query.js:183:50 at new Promise (<anonymous>) at Query.run (/node_modules/sequelize/Iib/dialects/sqlite/query.js:183:12) at /node_modules/sequelize/lib/sequelize.js:315:28 at async SQLiteQuerylnterface.insert (/node_modules/sequelize/lib/dialects/abstract/query-interface.js:308:21) at async PlaybackSession.save at async playbackSession.create at async PlaybackSessionManager.syncLocalSession (/server/managers/PlaybackSessionManager.js:168:7) at async PlaybackSessionManager.syncLocalSessionRequest { name: 'SequelizeUniqueConstraintErrorj, errors: [ [ValidationErrorltem] l, parent: [Error: SQLITE_CONSTRAINT: UNIQUE constraint failed: playbackSessions.id] { errno: 19, code: 'SQLITE_CONSTRAINT', sql: 'INSERT INTO playbackSessionss ( • id , & medialtemld , medialtemType' , s displayTitle& , s displayAuthor' , • mediaPlayeö , startTime& , s currentT VALUES 1, original: [Error: SQLITE_CONSTRAINT: UNIQUE constraint failed: playbacksessions.id] { errno: 19, code: 'SQLITE_CONSTRAINT', sql: 'INSERT INTO playbackSessionss ( • id , s medialtemld , medialtemTypes , s displayTitles , s displayAuthoö , ' mediaPlayers , startTimes , s currentT VALUES 1, fields: [ 'id' l, sql: 'INSERT INTO playbackSessions' ( • id , s medialtemld , medialtemTypes displayTitles , s displayAuthoö , ' mediaPlayers , startTimes , s currentT VALUES } }Debug log:
2024-09-13 21:27:05.741 DEBUG [ApiCacheManager] mediaProgress.afterUpdate: Clearing cache 2024-09-13 21:27:05.741 DEBUG [SocketAuthority] clientEmitter - no clients found for user a4031e86-929c-48b7-bb98-49e2715f5432 2024-09-13 21:27:05.824 DEBUG [ApiCacheManager] mediaProgress.afterUpdate: Clearing cache 2024-09-13 21:27:05.824 DEBUG [SocketAuthority] clientEmitter - no clients found for user a4031e86-929c-48b7-bb98-49e2715f5432 2024-09-13 21:42:07.577 DEBUG Set Log Level to DEBUG 2024-09-13 21:42:07.629 DEBUG [ApiCacheManager] Array.afterUpsert: Clearing cache@Marvin-D-Martian commented on GitHub (Sep 17, 2024):
Crashed again this morning. No book was playing, no user connected.
`FATAL
[Server] Unhandled rejection: SequelizeUniqueConstraintError: Validation error, promise: Promise { Error at Database. (/node_modules/sequelize/lib/dialects/sqlite/query.js:185:27) at /node_modules/sequelize/lib/dialects/sqlite/query.js:183:50 at new Promise () at Query.run (/node_modules/sequelize/lib/dialects/sqlite/query.js:183:12) at /node_modules/sequelize/lib/sequelize.js:315:28 at async SQLiteQueryInterface.insert (/node_modules/sequelize/lib/dialects/abstract/query-interface.js:308:21) at async PlaybackSession.save (/node_modules/sequelize/lib/model.js:2490:35) at async playbackSession.create (/node_modules/sequelize/lib/model.js:1362:12) at async PlaybackSessionManager.syncLocalSession (/server/managers/PlaybackSessionManager.js:168:7) at async PlaybackSessionManager.syncLocalSessionRequest (/server/managers/PlaybackSessionManager.js:242:20) { name: 'SequelizeUniqueConstraintError', errors: [ [ValidationErrorItem] ], parent: [Error: SQLITE_CONSTRAINT: UNIQUE constraint failed: playbackSessions.id] { errno: 19, code: 'SQLITE_CONSTRAINT', sql: 'INSERT INTO
playbackSessions(id,mediaItemId,mediaItemType,displayTitle,displayAuthor,mediaPlayer,startTime,currentTime,serverVersion,timeListening,mediaMetadata,date,dayOfWeek,extraData,createdAt,updatedAt,userId,deviceId,libraryId) VALUES ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11,$12,$13,$14,$15,$16,$17,$18,$19);' }, original: [Error: SQLITE_CONSTRAINT: UNIQUE constraint failed: playbackSessions.id] { errno: 19, code: 'SQLITE_CONSTRAINT', sql: 'INSERT INTOplaybackSessions(id,mediaItemId,mediaItemType,displayTitle,displayAuthor,mediaPlayer,startTime,currentTime,serverVersion,timeListening,mediaMetadata,date,dayOfWeek,extraData,createdAt,updatedAt,userId,deviceId,libraryId) VALUES ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11,$12,$13,$14,$15,$16,$17,$18,$19);' }, fields: [ 'id' ], sql: 'INSERT INTOplaybackSessions(id,mediaItemId,mediaItemType,displayTitle,displayAuthor,mediaPlayer,startTime,currentTime,serverVersion,timeListening,mediaMetadata,date,dayOfWeek,extraData,createdAt,updatedAt,userId,deviceId,libraryId) VALUES ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,$11,$12,$13,$14,$15,$16,$17,$18,$19);' } }`@rakorea commented on GitHub (Sep 17, 2024):
I still think it is race condition. I just don't have the Node knowledge to fix this correctly.
It is my understanding that Node is single threaded so generally you do not need to think about concurrency. But whenever you await, then it might give another task (or whatever they are called) priority.
I think in current PlaybackSessionManager.js:162 is where it goes wrong. Any number of these processes can get through line 163 and await again on line 169.
@mikiher commented on GitHub (Sep 17, 2024):
Sorry, this dropped out of my radar for a while.
Thanks for the reports and suggestions. I will investigate this week.
@mikiher commented on GitHub (Sep 18, 2024):
You were right about the race condition. Sent a fix.
@github-actions[bot] commented on GitHub (Oct 5, 2024):
Fixed in v2.14.0.