starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[Bug]: quick match overwrite all information in some situations #1665

New Issue
Closed
opened 2026-04-24 23:53:57 +02:00 by adam · 10 comments
adam commented 2026-04-24 23:53:57 +02:00
Owner
Copy Link
Copy Source

Originally created by @zombiehoffa on GitHub (Jan 16, 2024).

Describe the issue

if I click on a book to edit then click "quick match" sometimes it will overwrite all fields with a completely different book. I have noticed this happens when the first hit on audible is completely different than what the book actually is.

Steps to reproduce the issue

  1. click quick match while editing a book with a title and author
  2. if audible has completely different info everything gets overwritten, I believe all the time but may just be sometimes.

Audiobookshelf version

v2.7.1 docker

How are you running audiobookshelf?

Docker

Originally created by @zombiehoffa on GitHub (Jan 16, 2024). ### Describe the issue if I click on a book to edit then click "quick match" sometimes it will overwrite all fields with a completely different book. I have noticed this happens when the first hit on audible is completely different than what the book actually is. ### Steps to reproduce the issue 1. click quick match while editing a book with a title and author 2. if audible has completely different info everything gets overwritten, I believe all the time but may just be sometimes. ### Audiobookshelf version v2.7.1 docker ### How are you running audiobookshelf? Docker
adam added the bug label 2026-04-24 23:53:57 +02:00
adam closed this issue 2026-04-24 23:53:57 +02:00
adam commented 2026-04-24 23:53:57 +02:00
Author
Owner
Copy Link
Copy Source

@zombiehoffa commented on GitHub (Jan 16, 2024):

try "Endangered Species" by "Gene Wolfe" as an example. First hit on audible is not that book and everything is overwritten by the first book result, including the already filled in author and title.

@zombiehoffa commented on GitHub (Jan 16, 2024): try "Endangered Species" by "Gene Wolfe" as an example. First hit on audible is not that book and everything is overwritten by the first book result, including the already filled in author and title.
adam commented 2026-04-24 23:53:57 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Jan 16, 2024):

I believe this is because of #2400 where it was updated so that the audible search results are sorted by the one with the closest duration to match your book. Can you check if the result it is using has a closer duration then the correct one?

I can see how this would be problematic

@advplyr commented on GitHub (Jan 16, 2024): I believe this is because of #2400 where it was updated so that the audible search results are sorted by the one with the closest duration to match your book. Can you check if the result it is using has a closer duration then the correct one? I can see how this would be problematic
adam commented 2026-04-24 23:53:58 +02:00
Author
Owner
Copy Link
Copy Source

@zombiehoffa commented on GitHub (Jan 17, 2024):

Its the one that is on top for audible bools. It seemed more that the bool name was generic and furst hit wasnt the book. I will see what i can see when i get home but the bigg problem is it blows everything away rather than fillng unfilled stuff lile the tool tip says it will. If it just put in bad jnfo in the unfilled spots i could recover from that more easily

@zombiehoffa commented on GitHub (Jan 17, 2024): Its the one that is on top for audible bools. It seemed more that the bool name was generic and furst hit wasnt the book. I will see what i can see when i get home but the bigg problem is it blows everything away rather than fillng unfilled stuff lile the tool tip says it will. If it just put in bad jnfo in the unfilled spots i could recover from that more easily
adam commented 2026-04-24 23:53:58 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Jan 17, 2024):

Yes audible API doesn't always return exactly the matching book. Sometimes it appears to be random

@advplyr commented on GitHub (Jan 17, 2024): Yes audible API doesn't always return exactly the matching book. Sometimes it appears to be random
adam commented 2026-04-24 23:53:58 +02:00
Author
Owner
Copy Link
Copy Source

@mikiher commented on GitHub (Jan 18, 2024):

One more thing to check: Quick Match is only supposed to override existing details if "Prefer matched metadata" is enabled in the settings. Do you have "Prefer matched metadata" enabled? by default it's disabled. If you enabled it, consider disabling it.

@mikiher commented on GitHub (Jan 18, 2024): One more thing to check: Quick Match is only supposed to override existing details if "Prefer matched metadata" is enabled in the settings. Do you have "Prefer matched metadata" enabled? by default it's disabled. If you enabled it, consider disabling it.
adam commented 2026-04-24 23:53:58 +02:00
Author
Owner
Copy Link
Copy Source

@mikiher commented on GitHub (Jan 18, 2024):

Also, I don't seem to find this specific book (Endangered Species by Gene Wolfe) on Audible. I tried to look it up on Google (sometimes it won't appear in Audible search results because of geo limitations, especially if you're outside the US) and could not find it too.

So it seems like this is not an issue of the Audible API not returning exactly the matching book - it just doesn't exist on Audible.

@mikiher commented on GitHub (Jan 18, 2024): Also, I don't seem to find this specific book (Endangered Species by Gene Wolfe) on Audible. I tried to look it up on Google (sometimes it won't appear in Audible search results because of geo limitations, especially if you're outside the US) and could not find it too. So it seems like this is not an issue of the Audible API not returning exactly the matching book - it just doesn't exist on Audible.
adam commented 2026-04-24 23:53:59 +02:00
Author
Owner
Copy Link
Copy Source

@mikiher commented on GitHub (Jan 18, 2024):

@advplyr, Quick Match will always has the potential to do the wrong thing if the top search result is not the right one, and this will always happen for some books (if they don't exist on the provider, or if the title or author don't match, or for any other reason). Would you consider some sort of an "Undo Quick Match" button to help with such cases?

@mikiher commented on GitHub (Jan 18, 2024): @advplyr, Quick Match will always has the potential to do the wrong thing if the top search result is not the right one, and this will always happen for some books (if they don't exist on the provider, or if the title or author don't match, or for any other reason). Would you consider some sort of an "Undo Quick Match" button to help with such cases?
adam commented 2026-04-24 23:54:00 +02:00
Author
Owner
Copy Link
Copy Source

@zombiehoffa commented on GitHub (Jan 18, 2024):

Thanks! I did have that set!

@zombiehoffa commented on GitHub (Jan 18, 2024): Thanks! I did have that set!
adam commented 2026-04-24 23:54:01 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Jan 18, 2024):

Ah yeah thanks I didn't think to ask about prefer matched metadata.

There was a feature request to be able to preview quick match metadata before accepting. https://github.com/advplyr/audiobookshelf/issues/841

I'm not sure what would be better. It seems like having an "undo match" feature could be a better user experience because it wouldn't add an additional step. The additional step would only be for if you noticed it was wrong.

@advplyr commented on GitHub (Jan 18, 2024): Ah yeah thanks I didn't think to ask about prefer matched metadata. There was a feature request to be able to preview quick match metadata before accepting. https://github.com/advplyr/audiobookshelf/issues/841 I'm not sure what would be better. It seems like having an "undo match" feature could be a better user experience because it wouldn't add an additional step. The additional step would only be for if you noticed it was wrong.
adam commented 2026-04-24 23:54:01 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Jan 18, 2024):

I think the "prefer matched metadata" setting resolves this issue actually and we may not need to improve on the duration sorting from #2400 just yet. The given example just didn't have a match.

@advplyr commented on GitHub (Jan 18, 2024): I think the "prefer matched metadata" setting resolves this issue actually and we may not need to improve on the duration sorting from #2400 just yet. The given example just didn't have a match.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#1665
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?