mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
"Search Title or ASIN" field unescaped character #156
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#156
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Nullrogue on GitHub (Dec 30, 2021).
Running version 1.6.45_amd64 on a debian 11 host.
Attempted to use the match feature on a book titled
A Brother’s PriceReceived the following errors for each available provider:
Culprit seems to be the
’character which is identified asU+2019 : RIGHT SINGLE QUOTATION MARK {single comma quotation mark}.@Nullrogue commented on GitHub (Dec 30, 2021):
The standard javascript function
escape()seems like it might be a candidate for a fix.escape("’") => '%u2019'@Nullrogue commented on GitHub (Dec 30, 2021):
This behavior is also present in the cover art provider search resulting in the same errors.
@mx03 commented on GitHub (Dec 30, 2021):
I create a pull request for this.
@Nullrogue commented on GitHub (Dec 30, 2021):
Tested this PR and it fixes all the cases I am aware of with this issue. It is also almost the exact same fix I had staged. Beat me to it!
@advplyr commented on GitHub (Dec 30, 2021):
Awesome, thanks for working that out. I just patched the current version.
Just realized you are using the debian package, are you using the PPA? I'm going to update the deb now, I hope to automate that process soon.
@advplyr commented on GitHub (Dec 30, 2021):
Just pushed the latest version to the PPA https://github.com/advplyr/audiobookshelf-ppa