starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[Bug] Series volume sorting with dot #146

New Issue
Closed
opened 2026-04-24 22:59:29 +02:00 by adam · 5 comments
adam commented 2026-04-24 22:59:29 +02:00
Owner
Copy Link
Copy Source

Originally created by @mx03 on GitHub (Dec 25, 2021).

For some series that are splitted up in multiple seasons or books i abuse the series-part with following pattern: seriesnumber.volumenumber (eg: 1.1 , 1.2 , 2.3).

The series is currently sorted: ( 1.10 , 1.1, 1.2, [...] 1.9, 2.10, 2.1 [...] ), better would be the natural sorting. ( 1.1 1.2 [...] 1.9 1.10 2.1 )

Not sure if the volume numbering overall wanted to be other than pure number or if its ok with dot.

Originally created by @mx03 on GitHub (Dec 25, 2021). For some series that are splitted up in multiple seasons or books i abuse the series-part with following pattern: _seriesnumber_._volumenumber_ (eg: 1.1 , 1.2 , 2.3). The series is currently sorted: ( 1.10 , 1.1, 1.2, [...] 1.9, 2.10, 2.1 [...] ), better would be the natural sorting. ( 1.1 1.2 [...] 1.9 1.10 2.1 ) Not sure if the volume numbering overall wanted to be other than pure number or if its ok with dot.
adam added the bug label 2026-04-24 22:59:29 +02:00
adam closed this issue 2026-04-24 22:59:30 +02:00
adam commented 2026-04-24 22:59:31 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Dec 25, 2021):

This is a bug then, as long as it is a valid number it should be sorted as that.

@advplyr commented on GitHub (Dec 25, 2021): This is a bug then, as long as it is a valid number it should be sorted as that.
adam commented 2026-04-24 22:59:31 +02:00
Author
Owner
Copy Link
Copy Source

@mx03 commented on GitHub (Dec 25, 2021):

The problem is ab.book.volumeNumber is a string, if you use Number the result is:

Number('1.1') // => 1.1
Number('1.10') // => 1.1

If it should works with this logic it shouldn't treated as Number and use https://www.npmjs.com/package/fast-sort#natural-sorting--language-sensitive-sorting instead

@mx03 commented on GitHub (Dec 25, 2021): The problem is ab.book.volumeNumber is a string, if you use Number the result is: ```js Number('1.1') // => 1.1 Number('1.10') // => 1.1 ``` If it should works with this logic it shouldn't treated as Number and use https://www.npmjs.com/package/fast-sort#natural-sorting--language-sensitive-sorting instead
adam commented 2026-04-24 22:59:31 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Dec 26, 2021):

I wasn't aware of language sensitive sorting, thanks for finding that.
This is included in v1.6.48

@advplyr commented on GitHub (Dec 26, 2021): I wasn't aware of language sensitive sorting, thanks for finding that. This is included in `v1.6.48`
adam commented 2026-04-24 22:59:31 +02:00
Author
Owner
Copy Link
Copy Source

@mx03 commented on GitHub (Dec 26, 2021):

regression after changing series route https://github.com/advplyr/audiobookshelf/commit/6b9ce453b9c0f1bafff24c254c6d967c628d1588

@mx03 commented on GitHub (Dec 26, 2021): regression after changing series route https://github.com/advplyr/audiobookshelf/commit/6b9ce453b9c0f1bafff24c254c6d967c628d1588
adam commented 2026-04-24 22:59:32 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Dec 27, 2021):

I just pushed a patch for this, same version.

@advplyr commented on GitHub (Dec 27, 2021): I just pushed a patch for this, same version.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#146
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?