starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[Bug]: RSS Feeds not respecting "Prevent feed from being indexed by itunes and google" #1344

New Issue
Closed
opened 2026-04-24 23:40:35 +02:00 by adam · 7 comments
adam commented 2026-04-24 23:40:35 +02:00
Owner
Copy Link
Copy Source

Originally created by @DieselTech on GitHub (Sep 1, 2023).

Describe the issue

Turning on Prevent feed from being indexed by itunes and google doesn't apply the protections it says it does. This is confirmed both by the RSS status window showing "Prevent Indexing: No" and by checking the RSS feed itself.

<itunes:block>No</itunes:block>
<googleplay:block>no</googleplay:block>

Steps to reproduce the issue

  1. Turn on a feed
  2. Check the box to prevent
  3. View Feed

Audiobookshelf version

2.3.3

How are you running audiobookshelf?

Docker

Originally created by @DieselTech on GitHub (Sep 1, 2023). ### Describe the issue Turning on Prevent feed from being indexed by itunes and google doesn't apply the protections it says it does. This is confirmed both by the RSS status window showing "Prevent Indexing: No" and by checking the RSS feed itself. ```rss <itunes:block>No</itunes:block> <googleplay:block>no</googleplay:block> ``` ### Steps to reproduce the issue 1. Turn on a feed 2. Check the box to prevent 3. View Feed ### Audiobookshelf version 2.3.3 ### How are you running audiobookshelf? Docker
adam added the bug label 2026-04-24 23:40:35 +02:00
adam closed this issue 2026-04-24 23:40:36 +02:00
adam commented 2026-04-24 23:40:37 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Sep 8, 2023):

I wasn't able to reproduce this in my testing. With the prevent indexing checked I get:

<itunes:block>Yes</itunes:block>
<googleplay:block>yes</googleplay:block>

I did some reading on this though and made minor updates. I updated them to use lowercase "yes" and when not preventing indexing those tags won't be present at all. Using "no" in that tag is useless.

Are you still able to reproduce this on 2.3.3?

@advplyr commented on GitHub (Sep 8, 2023): I wasn't able to reproduce this in my testing. With the prevent indexing checked I get: ```xml <itunes:block>Yes</itunes:block> <googleplay:block>yes</googleplay:block> ``` I did some reading on this though and made minor updates. I updated them to use lowercase "yes" and when not preventing indexing those tags won't be present at all. Using "no" in that tag is useless. Are you still able to reproduce this on 2.3.3?
adam commented 2026-04-24 23:40:38 +02:00
Author
Owner
Copy Link
Copy Source

@DieselTech commented on GitHub (Sep 8, 2023):

Are you still able to reproduce this on 2.3.3?

Yes. I even turned off existing feeds that were made on prior versions and recreated them on 2.3.3

The behavior is 100% reproducible on my instance using the latest docker container.

@DieselTech commented on GitHub (Sep 8, 2023): > Are you still able to reproduce this on 2.3.3? Yes. I even turned off existing feeds that were made on prior versions and recreated them on 2.3.3 The behavior is 100% reproducible on my instance using the latest docker container.
adam commented 2026-04-24 23:40:41 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Sep 8, 2023):

Are you able to get it to say "Yes" here at all?

image

@advplyr commented on GitHub (Sep 8, 2023): Are you able to get it to say "Yes" here at all? ![image](https://github.com/advplyr/audiobookshelf/assets/67830747/663206fa-f138-4cd5-9a04-3fdb06bf4144)
adam commented 2026-04-24 23:40:41 +02:00
Author
Owner
Copy Link
Copy Source

@DieselTech commented on GitHub (Sep 15, 2023):

Are you able to get it to say "Yes" here at all?

Nope. No combo of actions I could take would ever get it to show up as Yes

@DieselTech commented on GitHub (Sep 15, 2023): > Are you able to get it to say "Yes" here at all? Nope. No combo of actions I could take would ever get it to show up as `Yes`
adam commented 2026-04-24 23:40:42 +02:00
Author
Owner
Copy Link
Copy Source

@nichwall commented on GitHub (Oct 28, 2023):

I was just able to recreate this using a collection on 5c1c511718 (edge on October 27 2023, most recent release was 2.4.4). When opening an RSS feed from a single book the Prevent Indexing was set correctly, but was not set for a collection with two books.
image

@nichwall commented on GitHub (Oct 28, 2023): I was just able to recreate this using a collection on 5c1c5117180765d32d325b7ab682bf31addfabc6 (edge on October 27 2023, most recent release was 2.4.4). When opening an RSS feed from a single book the Prevent Indexing was set correctly, but was not set for a collection with two books. ![image](https://github.com/advplyr/audiobookshelf/assets/5686638/62aca0dc-2e1f-4b80-8da9-739812cc083d)
adam commented 2026-04-24 23:40:43 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Oct 28, 2023):

Thanks, I found it. It was specific to collections & series

@advplyr commented on GitHub (Oct 28, 2023): Thanks, I found it. It was specific to collections & series
adam commented 2026-04-24 23:40:44 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (Oct 29, 2023):

Fixed in v2.5.0

@advplyr commented on GitHub (Oct 29, 2023): Fixed in [v2.5.0](https://github.com/advplyr/audiobookshelf/releases/tag/v2.5.0)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#1344
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?