mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug]: Server crash while deleting a library item #1327
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#1327
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mikiher on GitHub (Aug 26, 2023).
Describe the issue
The server crashed when a library item was deleted using the "Delete" from the menu. The "Delete from filesystem" checkbox was set to true. The file deleted was a single m4b file at the volume's root directory.
Logs:
2023-08-26T04:39:58.684092900Z [2023-08-26 04:39:58] INFO: [LibraryItemController] Deleting library item from file system at "/torrents/The Vorrh.m4b"
2023-08-26T04:40:05.180493000Z [2023-08-26 04:40:05] INFO: [Server] 1 Files Changed
2023-08-26T04:40:05.238155800Z [2023-08-26 04:40:05] ERROR: [Utils] Failed to get ino for path /torrents/The Vorrh.m4b [Error: ENOENT: no such file or directory, stat '/torrents/The Vorrh.m4b'] {
2023-08-26T04:40:05.238207500Z errno: -2,
2023-08-26T04:40:05.238223000Z code: 'ENOENT',
2023-08-26T04:40:05.238227400Z syscall: 'stat',
2023-08-26T04:40:05.238231800Z path: '/torrents/The Vorrh.m4b'
2023-08-26T04:40:05.238236500Z } (fileUtils.js:65)
2023-08-26T04:40:05.518349100Z /server/scanner/Scanner.js:652
2023-08-26T04:40:05.518376700Z } else if (library.settings.audiobooksOnly && !fileUpdateGroup[itemDir].some(checkFilepathIsAudioFile)) {
2023-08-26T04:40:05.518380300Z ^
2023-08-26T04:40:05.518569600Z
2023-08-26T04:40:05.518579300Z TypeError: fileUpdateGroup[itemDir].some is not a function
2023-08-26T04:40:05.518584700Z at Scanner.scanFolderUpdates (/server/scanner/Scanner.js:652:79)
2023-08-26T04:40:05.518588900Z at async Scanner.scanFilesChanged (/server/scanner/Scanner.js:572:33)
2023-08-26T04:40:05.518593200Z at async Server.filesChanged (/server/Server.js:243:5)
Steps to reproduce the issue
Audiobookshelf version
v2.3.3
How are you running audiobookshelf?
Docker
@mikiher commented on GitHub (Aug 26, 2023):
Same happened again. Here are the relevant logs:
[2023-08-26 12:16:40] INFO: [LibraryItemController] Deleting library item from file system at "/torrents/Artificial Condition - Martha Wells.mp3"
[2023-08-26 12:16:47] INFO: [Server] 1 Files Changed
[2023-08-26 12:16:47] ERROR: [Utils] Failed to get ino for path /torrents/Artificial Condition - Martha Wells.mp3 [Error: ENOENT: no such file or directory, stat '/torrents/Artificial Condition - Martha Wells.mp3'] {
[2023-08-26 12:16:40] INFO: [LibraryItemController] Deleting library item from file system at "/torrents/Artificial Condition - Martha Wells.mp3"
[2023-08-26 12:16:47] INFO: [Server] 1 Files Changed
} (fileUtils.js:65)
errno: -2,
code: 'ENOENT',
syscall: 'stat',
path: '/torrents/Artificial Condition - Martha Wells.mp3'
/server/scanner/Scanner.js:652
} else if (library.settings.audiobooksOnly && !fileUpdateGroup[itemDir].some(checkFilepathIsAudioFile)) {
^
TypeError: fileUpdateGroup[itemDir].some is not a function
at Scanner.scanFolderUpdates (/server/scanner/Scanner.js:652:79)
at async Scanner.scanFilesChanged (/server/scanner/Scanner.js:572:33)
at async Server.filesChanged (/server/Server.js:243:5)
@advplyr commented on GitHub (Sep 10, 2023):
Fixed in v2.4.0