mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug]: Number of backups to keep not being respected #1245
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#1245
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @raviwarrier on GitHub (Jul 16, 2023).
Describe the issue
The old backups don't get deleted.
As you can see the setting is to keep 3 backup copies, but the app doesn't delete the older ones. Just noticed it in the debacle of 2.3.0 update and revert to 2.2.3.
Unfortunately, due to the migration to 2.3.0 and return to 2.2.3, all my old logs are no longer available.
Steps to reproduce the issue
Can't say.
Audiobookshelf version
2.2.3
How are you running audiobookshelf?
Docker
@advplyr commented on GitHub (Jul 20, 2023):
I don't think we should automatically delete old backups once you adjust the limit. It seems there was some bug happening where it kept more than 3 backups. If you can reproduce that bug let me know
@raviwarrier commented on GitHub (Jul 21, 2023):
I will keep a look out for this in the new version 2.3.3. If it happens again, do you want me to send you the logs?
@advplyr commented on GitHub (Jul 21, 2023):
That would be great, just the logs around the time of the automated backup. It works by creating a new backup, then it will remove 1 backup if there are more than X amount of backups. Only 1 at a time is removed and this will be in the logs that it successfully removed 1 backup.