mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Enhancement]: Search for authors without suffixes like '- Translator' or '-Foreword' #1219
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#1219
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @raviwarrier on GitHub (Jun 29, 2023).
Describe the feature/enhancement
As you can see from the image above, there are people who get added to the book's meta data because they contributed or translated a book. This is no problem until the author is searched for.
Almost everytime, such a search or match comes up empty because of the suffixes. While I know it would be unfair to remove them from the authors list or some people may want to know what they contributed, an easier option would be to parse out such suffixes before searching for or matching them.
@advplyr commented on GitHub (Jul 1, 2023):
Are you referring to matching or searching within Abs?
@raviwarrier commented on GitHub (Jul 2, 2023):
Matching... for example in the image above, because the translator is listed as "Phillip Freeman - translation", no match comes up for him. The same applies to "Eric Reis - Foreword" (as an example)... but Phillip and Eric are authors and need to be matched.
Hope that clarifies.
@advplyr commented on GitHub (Jul 15, 2023):
Do you have other examples of audiobooks that Audible uses hyphens like that? This is the first I'm seeing that
@raviwarrier commented on GitHub (Jul 16, 2023):
here are some:
In this case, Richard Dawkins is an author himself, but this is how it shows in the author's list:
@advplyr commented on GitHub (Jul 16, 2023):
Hmm, I'm not sure I like how Audible is doing that because these aren't authors. Do you know if this is only Audible that is giving us this data? Maybe something can be setup specifically for processing the data coming from Audible
@raviwarrier commented on GitHub (Jul 17, 2023):
This is how Audible shows the page:
this is how audible shows it in MP3Tag using Seanap's script:
I think there are very limited postfixes: - foreword, - contributor, - translator, - introduction, so maybe some hard-coding might work (even though I don't like hard-coding strings)
Another thing I observed is that hyphenated names don't have a space before and after the hyphens (Simon Baron-Cohen) , while these postfixes do, so that might be another way to check and ignore the postfixes. Something like:
if hyphen in name
if surrounded by spaces
take text before hyphen to get name for search
else
take the whole text as name for search
end if
end if
But you would know a better way of implementing this.
@loughnane commented on GitHub (Jul 25, 2023):
I think its a better solution here to treat 'translators' as a separate field rather than lumping postfixes. As libraries grow you'll see its often the case that someone who has translated something also writes things in their own right. For example George Eliot did a translation of Spinoza's ethics.