mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug] Embed audio file not embedding ASIN, series and series sequence #1151
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#1151
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jeff47 on GitHub (May 25, 2023).
Describe the feature/enhancement
I have a number of files where the asin tag is present, but when I go into Match, it defaults to the Title instead. It seems more logical to use the ASIN first, if it exists, and then use the title as a fallback.
@advplyr commented on GitHub (May 25, 2023):
This should be how it already works. What is your provider set to?
@advplyr commented on GitHub (May 25, 2023):
I just tested again and this is working, but let me know how I can reproduce it.
@jeff47 commented on GitHub (May 25, 2023):
Audible.
I've attached an example. Tone finds the ASIN in the m4b file, but the ASIN doesn't seem to get parsed by Audiobookshelf.
@advplyr commented on GitHub (May 25, 2023):
Abs uses
ffprobeto get the meta tags from audio files. Can you try ffprobe?@jeff47 commented on GitHub (May 25, 2023):
Ah, I assumed since tone was used to embed the metadata, it was used to read it as well! My mistake.
ffprobe doesn't reveal any ASIN tag set.
However, I don't see an ASIN in other files using ffprobe where ABS does have them set. Do I need a different parameter to extract them?
@advplyr commented on GitHub (May 25, 2023):
I'm not sure how tone is setting the
asintag, maybe @sandreas could help out. In this comment he hadAUDIBLE_ASINpicked up by ffprobe. https://github.com/advplyr/audiobookshelf/issues/787#issuecomment-1532282307@jeff47 commented on GitHub (May 25, 2023):
Hmm. Using that ffprobe commandline is helpful. Even after matching with an ASIN, and seeing it in ABS on the book info page and in the tone dump, I do not see it in ffprobe. I do not believe ffprobe supports those tags.
@sandreas commented on GitHub (May 26, 2023):
@advplyr @jeff47
tonedoes not set the fieldASINautomatically... Depending on which format you use (e.g.mp3orm4a), you have to useAdditionalFieldsfor this, see here:https://github.com/sandreas/tone/blob/c3ab8c49019afd6f057a55fa5b6ac0ecb22ee789/tone/Metadata/Taggers/M4BFillUpTagger.cs#L37
You can do this with custom JavaScript taggers as well.
I personally use
metadata.AdditionalFields["----:com.pilabor.tone:AUDIBLE_ASIN"]for my very own purposes, whichffprobedetects asAUDIBLE_ASIN(without the----:com.pilabor.tone:prefix). I don't useASIN, because it is a term for Amazon items. While Audible uses the same format for its ID, theASINon Audible and Amazon are not identical for the same product (I think this is to prevent scraping the websites). Therefore I usedAUDIBLE_ASINto not pollute theASINtag.@jeff47 commented on GitHub (May 26, 2023):
I don't see AUDIBLE_ASIN in the ffprobe output for files I've used ABS to embed metadata, and if I remove a properly tagged file from ABS and reimport it, ABS does not populate the ASIN field even when tone displays it on the cli.
That's the basis for my question -- is this the expected behavior? I would have assumed that if an ASIN tag was found in the metadata for a file, it would be used to improve the match and in my experience, this is not happening.
@sandreas commented on GitHub (May 26, 2023):
@jeff47 That may happen, if ABS tries to tag files via
toneAdditionalFields, butffprobeis not able to show it.toneis still able to show tags because they are there,ffprobedoes NOT show, but after reimporting the ABS cache may be gone and the tag cannot be determined sinceffprobeis used.@advplyr So this MAY be a problem in ABS, but you have to investigate this... If it is something in
tonefeel free to open an issue.@advplyr commented on GitHub (May 27, 2023):
I had to make some updates to get embed tool to work for ASIN, series and series sequence
For mpeg4 audio files it will use
----:com.pilabor.tone:SERIESfor series name----:com.pilabor.tone:PARTfor series sequence----:com.pilabor.tone:AUDIBLE_ASINfor asinI tested this on an m4a and was able to properly embed those and the scanner read them.
I also added an additional check for if series sequence is an integer. If it is not an integer then MP3 files will add
PARTin additionalFields. Tested all of these on MP3 as well.@advplyr commented on GitHub (May 28, 2023):
Fixed in v2.2.21
@jeff47 commented on GitHub (Sep 11, 2024):
It's been a while since I checked on this, but I don't think the audible_asin tag is being embedded. I don't see it showing up when I check with "tone dump" after doing the quick embed function.
Are all the metadata fields to be embedded listed on this page? audible_asin doesn't show up there, although it is present on the main book page.