starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[Bug]: Delete bookmark not working #1150

New Issue
Closed
opened 2026-04-24 23:34:16 +02:00 by adam · 5 comments
adam commented 2026-04-24 23:34:16 +02:00
Owner
Copy Link
Copy Source

Originally created by @itkfilelor on GitHub (May 25, 2023).

Describe the issue

Clicking delete on a bookmark does not work, This goes for the WebUI, mobile (Android) and the API. All three get an affirmative response (green alert modal on UI; 200 with API), but no change is affected. I noticed in server/routers/ApiRouter.js only the filter exists but no action.

Steps to reproduce the issue

  1. Click delete on a bookmark.

Audiobookshelf version

v2.2.20

How are you running audiobookshelf?

Docker

Originally created by @itkfilelor on GitHub (May 25, 2023). ### Describe the issue Clicking delete on a bookmark does not work, This goes for the WebUI, mobile (Android) and the API. All three get an affirmative response (green alert modal on UI; 200 with API), but no change is affected. I noticed in [server/routers/ApiRouter.js](https://github.com/advplyr/audiobookshelf/blob/master/server/routers/ApiRouter.js) only the filter exists but no action. ### Steps to reproduce the issue 1. Click delete on a bookmark. ### Audiobookshelf version v2.2.20 ### How are you running audiobookshelf? Docker
adam added the bug label 2026-04-24 23:34:16 +02:00
adam closed this issue 2026-04-24 23:34:17 +02:00
adam commented 2026-04-24 23:34:17 +02:00
Author
Owner
Copy Link
Copy Source

@Canderson8495 commented on GitHub (May 27, 2023):

So I just started a fresh dev environment. Added some books, opened a book, created a bookmark. Checked to make sure bookmark was working correctly. It was working correctly. I deleted it, but I had no problems on my side.
Does this occur for all of your books or just some?

@Canderson8495 commented on GitHub (May 27, 2023): So I just started a fresh dev environment. Added some books, opened a book, created a bookmark. Checked to make sure bookmark was working correctly. It was working correctly. I deleted it, but I had no problems on my side. Does this occur for all of your books or just some?
adam commented 2026-04-24 23:34:18 +02:00
Author
Owner
Copy Link
Copy Source

@itkfilelor commented on GitHub (May 27, 2023):

So I just started a fresh dev environment. Added some books, opened a book, created a bookmark. Checked to make sure bookmark was working correctly. It was working correctly. I deleted it, but I had no problems on my side. Does this occur for all of your books or just some?

I only tried the one thus far. I'll look into it further.
UPDATE: Took a rebuild but its working now... thanks for the inspiration.

@itkfilelor commented on GitHub (May 27, 2023): > So I just started a fresh dev environment. Added some books, opened a book, created a bookmark. Checked to make sure bookmark was working correctly. It was working correctly. I deleted it, but I had no problems on my side. Does this occur for all of your books or just some? I only tried the one thus far. I'll look into it further. UPDATE: Took a rebuild but its working now... thanks for the inspiration.
adam commented 2026-04-24 23:34:18 +02:00
Author
Owner
Copy Link
Copy Source

@itkfilelor commented on GitHub (May 27, 2023):

I lied, it's not working 😄. If a bookmark is created "normally" via the app or WebUI it all works as expected. But if the bookmark is created via the api it does not. As mentioned in the OP this goes for all three methods.
Since @advplyr can't or won't expose intents for use with Tasker on android, (Not a gripe, just happy for this great software.) I took to python scripting. To not guild the lily, I can successfully create and update a bookmark, but I cannot delete.

@itkfilelor commented on GitHub (May 27, 2023): I lied, it's not working 😄. If a bookmark is created "normally" via the app or WebUI it all works as expected. But if the bookmark is created via the api it does not. As mentioned in the OP this goes for all three methods. Since @advplyr can't or won't expose intents for use with Tasker on android, (Not a gripe, just happy for this great software.) I took to python scripting. To not guild the lily, I can successfully create and update a bookmark, but I cannot delete.
adam commented 2026-04-24 23:34:19 +02:00
Author
Owner
Copy Link
Copy Source

@advplyr commented on GitHub (May 27, 2023):

Can you share the API request you are making that is creating the bookmark? Can you also look at the server logs?

@advplyr commented on GitHub (May 27, 2023): Can you share the API request you are making that is creating the bookmark? Can you also look at the server logs?
adam commented 2026-04-24 23:34:19 +02:00
Author
Owner
Copy Link
Copy Source

@itkfilelor commented on GitHub (May 27, 2023):

I'm just gonna stop. it appears to be my code. I works fine with Postman.
If I come back just slap me.

@itkfilelor commented on GitHub (May 27, 2023): I'm just gonna stop. it appears to be my code. I works fine with Postman. If I come back just slap me.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#1150
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?