mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[Bug]: Author folder name splitting not working correctly #1068
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#1068
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @0rn0lf on GitHub (Apr 13, 2023).
Describe the issue
When you add new audiobooks to the filesystem, were the top folder (authors) contains multiple entries, the serperators "," or "&" wont work correcty if one author doesnt have a lastname.
Steps to reproduce the issue
Exprected behavior should be 4 authors. But abs only creates 2. It seems to think, that Peter and Tommy Krappweis are the same person. Also it merged Sebastian Fitzek and Stephen King as a single author.
If you remove Peter, it will correctly detect the 3 authors.
The same happens when audiobooks dont have an author and are listed as N.N or N. N. or seperated with ","
This is kinda related to https://github.com/advplyr/audiobookshelf/issues/1198
A sperator should always seperate the names. There are propably authors out there who use a single pseudonym which doesnt contain a lastname
Audiobookshelf version
5.2.18
How are you running audiobookshelf?
Docker
@advplyr commented on GitHub (Apr 13, 2023):
We may be able to do this with the "&" separator but with the "," separator some users keep their authors "Last Name, First Name"
Using an "&" separator is uncommon I think.
How do you handle multiple authors in the format of "Last Name, First Name"
@0rn0lf commented on GitHub (Apr 13, 2023):
My current format is "First Name Last Name , First Name Last Name"
The format "Last Name, First Name" doesnt make any sense in my opinion. While this might work, it looks pretty ugly in the folder structure, is hard to read for humans and not pretty reliable when having multipe authors.
I again used "Peter" as a dummy name here. While abs was able to sort most of the clutter correctly out, it totally forgot about "Peter" because he doesnt have a last name.
Also, no one would call out "Rowling J.K" or "Tolkin J.R.R" but this is my personal opinion here.
The "&" might be uncommon but it could solve the problem and would make splitting the folder string a lot easier in terms of programming. It would come with the downside that multiple related authors must be added seperately. So you cannot name your folder "Homer&Marge Simpson" as this would be splitted to "Homer" and "Marge Simpson"
In this case you would have to name it "Homer Simpson & Marge Simpson" so that "Homer" doesnt lose his last name.
Or as mentioned in the other issue, we could use a semi-colon ";".
But then again, if some names the folder like "Homer&Marge Simpson;Ned Flanders" you would have to split "Homer" and "Marge" and add "Simpson" to both of them so that they are listed as seperate authors. But it would correctly handle "Ned Flanders" because it could be splitted by the semi-colon.
I think the easiest way for the scanner would be to define a new naming convention like:
"Homer Simpson ; Marge Simpson ; Ned Flanders"
At the end, it doesnt matter if its "Last Name, First Name" or "First Name Last Name" but it must be consistent.
Guessing whats the first and whats the last name for the scanner cannot be a solution.
Of cource, at the very end it doesnt matter since everything will be managed by the metadata from Audible etc. but this will only work if the names were correctly exported by the scanner. And Audible is also displaying them as "First name Last name"
The better the detection works, the better the automation workflow will be. Regardless of how many authors are named in the search query or the position of them.
@damajor commented on GitHub (Feb 5, 2025):
Related to #2661