mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
Series and Sub-Series #1059
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#1059
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MikeBishop on GitHub (Apr 10, 2023).
Is your feature request related to a problem? Please describe.
Some overarching series have smaller series within them. The current solution enables a book to be assigned to multiple series, so that both the parent and all child series appear in the series list.
Describe the solution you'd like
Describe alternatives you've considered
Using the current setup, where a book can be assigned to both the smaller and larger series, an alternative would be to hide the smaller series if it is completely contained by the larger series.
Additional context
@advplyr commented on GitHub (Apr 10, 2023):
Have you looked at the series page, there is a collapse sub-series option there.
I think that is what you are talking about. Your screenshot is of the authors page though
@MikeBishop commented on GitHub (Apr 11, 2023):
That's part of it, and helps. The trouble is that all the smaller series still appear in the series listing, the author listing, etc. What I'd ideally see is those smaller series appearing only inside the larger series, and not treated as full-fledged series in other views.
I'd also like to be able to tag a series as belonging to a series, rather than having to have every book belong to 2+ series. Maybe a better way to express this is the ability to have a series be composed of both books and other series?
@AarynRobinson commented on GitHub (Apr 11, 2023):
A potential solution could be an option to hide a series from the series page. I think that would be satisfactory to me and seems simpler to implement.
@advplyr commented on GitHub (Apr 13, 2023):
What is the reason for hiding sub-series?
I don't think we are going to have a series be composed of both books and series. A few reasons for this but mainly the data model is not setup to support that and sub-series should still have a sequence.
@MikeBishop commented on GitHub (Apr 13, 2023):
Because there can be lots of them, and they create visual clutter.
Consider something like the Deryni series, which is composed mostly of trilogies set in different eras. (Modulo the occasional stand-alone.)
It's already the case that if I click into Deryni, then see the different trilogies and stand-alones; clicking into one of them shows the books in that trilogy. That's a great start.
But if they're all listed in the Series page, then I have ~6 Deryni series -- the overarching one and the 5 smaller ones it contains. They then become a noticeable fraction of the series listing, when they're conceptually all one thing unless I want to dig in. Same with Valdemar, Pern, Mistborn, etc. I'd like the option to have only the overarching series show anywhere outside that series' page.
When adding, it would be nice to be able to say "This new book is number 3 in the Herald Spy series, and Herald Spy already has a sequence number in Valdemar," but I can understand that would entail some abstraction in the data model. (I haven't looked at ABS's data model for series to see how insane that would be.) On the other hand, without that linkage, it seems like hiding a sub-series becomes more complex; ABS only knows about books belong to series, and would have to either look for overlaps between all series or look for books that are assigned to multiple series as a clue for which ones to consider.
Still, if we keep the current model, that a book has to be assigned to be, say, 3 in Herald Spy and 7.3 in Valdemar, then something that simply hides the sub-series is a step in this direction.
(I'm a little confused by this part, since I haven't suggested sub-series not having a sequence.)
@advplyr commented on GitHub (Apr 13, 2023):
If we support hiding sub-series from the series (and author) page then my initial reaction is this would be boolean flag on the series that you would have to manually turn on. It could get messy trying to detect what is a sub-series. Not to say auto-detecting sub-series wouldn't ever be supported but as a first step a manual flag makes sense. We may also change the data model. It has changed a few times now as more requests come in and handling use-cases I never thought of.
I was thinking that if we added the option to put an entire series in another series then the UI for this would then somehow have to prompt for entering the sequence of each book in that series. Using the batch editor you can already group select all the books in a series, batch edit, and add a series to all the books. Then you would need to go into each book and set the sequence afterwards.
I was thinking about the UI/UX when I said that
@MikeBishop commented on GitHub (Apr 14, 2023):
I took a look at the code for collapsing automatically; I can post what I've got when I'm back at a keyboard. It's a relatively small addition, but might require some real-world testing to see how much the iteration over the books actually costs. In a large library, it's potentially a lot of traversing.
Since my main instance is running in a Docker container, I don't yet have a good setup to test the change, but I'll see if I can figure that out this weekend.
@advplyr commented on GitHub (Apr 14, 2023):
I think the rest of the feature should be figured out before doing auto hide sub-series. We would have to have a library setting to enable that also
@MikeBishop commented on GitHub (Apr 14, 2023):
I'd thought you were ruling out the data model change; sorry. Yes, I agree that route would require a series editor view, and possibly a series batch editor. (Other things that might go in there: Renaming a series. Setting a custom cover for the series, which is popular with Plex collections. Could also envision it containing something like the chapter reorder tool for the component items.) I have no Vue experience, so UI I would have more trouble being any help on.
As to the option, that's obviously possible. I was wondering if there would be people who explicitly don't want this behavior or if it could just be part of "Collapse series." Perhaps a question for the Discord?
@MikeBishop commented on GitHub (Apr 14, 2023):
Oh, one other thought -- if we did go the data model route, the difference in behavior could simply be whether the books belong to both series or one series belongs to another. No scanning for overlap, just a global statement that an element is hidden if a parent is shown.
@MikeBishop commented on GitHub (Apr 17, 2023):
Looks like this is mostly a duplicate of #870.
@advplyr commented on GitHub (Apr 30, 2023):
Duplicate of #870
@advplyr commented on GitHub (Apr 30, 2023):
We'll just make that issue the main one for these sub-series requests. I don't know how to cleanly handle this and don't have anything in my library that requires it so hard to visualize.