mirror of
https://github.com/advplyr/audiobookshelf.git
synced 2026-05-30 23:40:40 +02:00
[UI]: Show "abridged" only when true. #1053
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf#1053
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Dr-Blank on GitHub (Apr 9, 2023).
Describe the feature/enhancement
Since abridged is of type Boolean, it can be shown/hidden based on the value. Right now the metadata feels unnecessarily long and abridged = no seems like it is adding no value.
I would suggest something like a pill (see below) as a solution to show abridged only if it is so, or the tag can contain the text itself, whether it is abridge or unabridged, getting rid of the extra yes and no. looks nice too imo.
@sumitshinde-84 commented on GitHub (Apr 9, 2023):
i would like to work on this issue can you please assign it to me ?
@Dr-Blank commented on GitHub (Apr 9, 2023):
On second thought, I think that space would be better suited for tags and labels as they are not in the ui as of now, see below for another rendition.
I used the same classes for both of the pills which if slightly different but in align to the theme, should look better.
@mrburns-42 commented on GitHub (Apr 9, 2023):
Personally, I would prefer to see unabridged when the abriged flag is not set. What do you think?
@Dr-Blank commented on GitHub (Apr 9, 2023):
@skronenwerth for me it is the opposite. 99% of my library contains unabridged books :D
But it can be both, always enabled, showing the type.
@mrburns-42 commented on GitHub (Apr 9, 2023):
@Dr-Blank For me, too, about 99% are unabridged. I mean, however, that when setting the flag abridged and when not setting the flag unabridged is displayed. I think that I had expressed myself misleadingly.
@advplyr commented on GitHub (Apr 9, 2023):
I wasn't sure how to display it so I did it that way in the hopes someone would come with some better suggestions.
I'm still not sure but here is how explicit flag is displayed. I'm hovering over it in this screenshot which shows the tooltip.
If we put this next to the book title then I don't think we should show the word "unabridged".
If you don't see the word "abridged" then you can just assume it is unabridged.
@sumitshinde-84 sure
@Dr-Blank commented on GitHub (Apr 9, 2023):
I completely forgot about the explicit tag. Will have to come up with some new to accommodate both.
@Dr-Blank commented on GitHub (Apr 13, 2023):
@advplyr
Why not just line them up next to each other? I mean how often is a book abridged and that too explicit at the same time? Even if that is the Case, the "e" doesn't seem to take up much space.
Or maybe we could place a similar "🄰" next to the existing 🅴 which on hover showed a tooltip of "abridged" like explicit. Now these Unicode do not match up entirely, so maybe we need a custom svg for that, let me know if you need help with those, in case you decide to proceed with that. I found this font which somewhat resembles those Unicode characters but it is not perfect, here it is (not sure about the copyright though).
yup
@advplyr commented on GitHub (Apr 13, 2023):
I like the idea of just using an "A" SVG. I think we'll want to use an SVG because some browsers won't render some unicode characters.
@advplyr commented on GitHub (Apr 16, 2023):
@advplyr commented on GitHub (Apr 17, 2023):
Updated in v2.2.19