Add LibraryItemController test for delete/batchDelete/updateMedia endpoint functions to correctly remove authors & series with no books

server/managers/CacheManager.js

@@ -86,6 +86,7 @@ class CacheManager {
   }
 
   async purgeEntityCache(entityId, cachePath) {
+    if (!entityId || !cachePath) return []
     return Promise.all(
       (await fs.readdir(cachePath)).reduce((promises, file) => {
         if (file.startsWith(entityId)) {

server/objects/LibraryItem.js

@@ -262,7 +262,7 @@ class LibraryItem {
    * @returns {Promise<LibraryFile>} null if not saved
    */
   async saveMetadata() {
-    if (this.isSavingMetadata) return null
+    if (this.isSavingMetadata || !global.MetadataPath) return null
 
     this.isSavingMetadata = true
 

server/routers/ApiRouter.js

@@ -400,10 +400,12 @@ class ApiRouter {
     await CacheManager.purgeCoverCache(libraryItemId)
 
     // Remove metadata file if in /metadata/items dir
-    const itemMetadataPath = Path.join(global.MetadataPath, 'items', libraryItemId)
-    if (await fs.pathExists(itemMetadataPath)) {
-      Logger.info(`[ApiRouter] Removing item metadata at "${itemMetadataPath}"`)
-      await fs.remove(itemMetadataPath)
+    if (global.MetadataPath) {
+      const itemMetadataPath = Path.join(global.MetadataPath, 'items', libraryItemId)
+      if (await fs.pathExists(itemMetadataPath)) {
+        Logger.info(`[ApiRouter] Removing item metadata at "${itemMetadataPath}"`)
+        await fs.remove(itemMetadataPath)
+      }
     }
 
     await Database.libraryItemModel.removeById(libraryItemId)