mirror of
https://github.com/advplyr/audiobookshelf-app.git
synced 2026-07-26 22:48:43 +02:00
App keeps crashing (local storage permissions lost) #613
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf-app#613
Reference in New Issue
Block a user
Originally created by @WickedSquirrel on GitHub (Jul 6, 2023).
Steps to reproduce
Expected behaviour
Actual behaviour
Environment data
Audiobookshelf Version:
Android Issue
Android version:
Newest
Device model:
Pixel 5
Stock or customized system:
Stock I think
iOS Issue
iOS Version:
iPhone model:
@nichwall commented on GitHub (Jul 7, 2023):
What server version are you running? If you are running the latest app (0.9.65), you need to have at least server version 2.2.23. You can check both of these numbers using the menu in the upper right corner of the app
@mihailim commented on GitHub (Jul 7, 2023):
Been happening for me as well for the past few weeks. Docker 2.2.23, app 0.9.65. Opus, multiple files per audiobook. Excepting the app from battery optimization and so on doesn't seem to change anything.
@gazpachoking commented on GitHub (Jul 9, 2023):
This happens for me, but only if I download the audiobook locally. Streaming works fine.
EDIT: Some more detail
When I click to play a downloaded book, the audio starts immediately, but the player (the strip on the bottom of the screen) doesn't show up for several seconds (~15 seconds.)
Usually, the audio starts getting stuttery after a few seconds.
Sometimes the whole app crashes a few seconds later.
Sometimes things will keep working, and the stutters stop, or go down to a minimum. When this happens, the phone still seems to run hotter and more slugishly.
This wasn't happening before a few weeks ago, though I haven't done experimentation to pin it down to a specific version yet.
Current versions:
Server: 2.2.23
Android App: 0.9.65-beta
EDIT2:
Did some more testing, seems this started with 0.9.64. I just tried that and 0.9.63, and things seem to be working better on 0.9.63.
@mihailim commented on GitHub (Jul 10, 2023):
Thank you for the additional description, @gazpachoking ! Yeah, that's exactly how it's behaving for me as well for local playback, including the initial UI freeze while audio is playing, the stutters and so on. The only additional details I can add are:
These may or may not be relevant, just throwing them out there as additional data points.
Edit: Oh, and of course tried completely nuking the app (including its local cache, storage, and the local storage directory) then reinstalling it and creating a new local storage directory. No change.
@WickedSquirrel commented on GitHub (Jul 10, 2023):
I think I have both set to always be up to date
@nichwall commented on GitHub (Jul 11, 2023):
Are all of you listening to the books in a web browser at all, or only in the Android app? Are you in an area with poor cell reception when this issue occurs?
@Daemonias - Is it with both streamed and downloaded books?
@gazpachoking @mihailim - Are you waiting for the server connection to be established before beginning playback?
There was a change recently (don't remember exactly when) to allow playback if the connection to the server hasn't been established. What happens if you log out of the server and try to play a downloaded book (steps below)?
You can also try playing a downloaded book in airplane mode, just trying to narrow down what the issue is
@WickedSquirrel commented on GitHub (Jul 11, 2023):
I don't know.. I nearly never stream.. I can try.
And I will try the offline mode.
@mihailim commented on GitHub (Jul 11, 2023):
Tested three scenarios:
So indeed it seems to be related to client/server comms. Speculation: smells like a race condition somewhere, blocking the UI -- and maybe the UI blockage is leading to the app being killed?
@advplyr commented on GitHub (Jul 11, 2023):
@mihailim When the UI leads to the crash this usually gives a message like "the app isn't responding", is that what you are seeing?
You said you are on Android 13 but what device are you using and is it stock?
You said you were using opus audio files, have you tried any other audio formats?
If you go to logs on the server and enable debug logs you should be able to watch the mobile app sync with the server every 30 seconds or so.
@mihailim commented on GitHub (Jul 11, 2023):
Bit hard to tell, since the screen is always off when it happens, and unlocking it presumably clears :) I'll try to reproduce with it plugged in and every screen timeout turned off; could take a bit though. I'll also try to capture some filtered and some raw logcat output, and will try to correlate it with the server-side debug logs.
Using a Pixel 6a, fully stock, not rooted, July 5 2023 patch level, but the problem has been occurring for at least 2 months.
Haven't tried any other formats yet, will try a monolithic m4b.
@WickedSquirrel commented on GitHub (Jul 12, 2023):
That's what I'm sometimes getting.. it can even play while saying that.. then I press wait for app.. then it comes again.
Leaving the app or closing the screen will make it crash
@gazpachoking commented on GitHub (Aug 3, 2023):
I've noticed that some books are worse than others with this problem. Perhaps to do with the number of files?
Downloaded books are totally unusable for me with Android Auto, because the app crashes and is closed after a few seconds of playback.
I can't use another app while listening to a downloaded book either, because the message about audiobookshelf not responding keeps popping up over the other app (the audio continues to play in the background though.) If I click 'wait' I get a few seconds before the dialog pops back up again. If I click to end the program playback stops.
@mihailim commented on GitHub (Aug 4, 2023):
Update (and sorry for the long absence without feedback): So far I'm unable to reproduce this any longer after changing the nginx reverse proxy read and send timeout values.
Context: Used to have the timeouts at 20 seconds by default, down from the nginx defaults of 60 seconds. Wanted to get rid of the constant annoying "socket connected / socket disconnected" messages. In other words, in the nginx config, at the same level as the other proxy directives such as
proxy_passandproxy_set_header, I've addedSince then, the problem has completely disappeared -- which tracks with the speculation that it was sync-related.
Might be worth trying that to see if it actually helps!
Edit:
Tightened things up even further -- left the read and send timeout at the 60 second nginx defaults for the main reverse proxy, and set them to 1 hour just for the
/socket.io/location. Local playback still works perfectly this way. So from where I'm standing, there's a strong likelihood that the issues were caused by too-low reverse proxy read and send timeouts to the sync API endpoint.@gazpachoking commented on GitHub (Aug 11, 2023):
Tried setting the timeouts on my reverse proxy to 1h as well, but with no luck. Didn't seem to affect this issue at all. I'm also confused how it could affect things, as the issue occurs immediately when starting a book, how would any sort of timeout affect things before the timeout period has even elapsed?
@mihailim commented on GitHub (Aug 11, 2023):
Damn and blast... I really had hopes that was it. For me, it always took 15+ minutes to happen, usually even longer (which is why it was rather difficult to reproduce reliably) and it doesn't happen at all now... :/
@gazpachoking commented on GitHub (Aug 13, 2023):
Ugh. I tried to revert to 0.9.63 again, but now that version is failing to download my books.
@mihailim commented on GitHub (Aug 13, 2023):
Yup, you'd need to downgrade the server as well.
@gazpachoking commented on GitHub (Aug 13, 2023):
Hmmmmm. This is anecdotal at this point because I've only clicked to play once. Something got messed up during my version changes and even when restoring 0.9.65 the app was crashing all the time. I cleared my audiobook download folder (because it never matches already downloaded things to the server items after a version change,) then cleared the app cache and storage. Somehow everything seems to be working properly for downloaded books now. The real test will be when I get back in to my car for android auto, as that's when it's at its worst.
@mihailim commented on GitHub (Aug 15, 2023):
The server-side switch to SQLite also necessitated a change in all the IDs (libraries, library items, authors, what have you), so when downgrading nothing already downloaded would match, need to start from a clean slate on the app side.
@gazpachoking commented on GitHub (Aug 23, 2023):
Things were fine for a while, but now it's back to freezing my phone for a while after I click play on local media (crashing in the worst case scenario.) I didn't change any versions or settings since it was working. I tried clearing the app storage/cache and signing in and downloading a book again, but that didn't fix anything this time.
@gazpachoking commented on GitHub (Oct 7, 2023):
Still having this issue on 0.9.66. The book will play okay while the screen is on, but the 'audiobookshelf isn't responding' keeps popping up, making the phone unusable. If the screen is asleep, audiobookshelf gets killed and the book stops playing.
@sandreas commented on GitHub (Nov 18, 2023):
@advplyr I have the exact same behaviour on some other apps too. Seems to be a problem with battery settings and android permissions, the app has to request BackgroundService permission to prevent it.
Maybe this helps. An app that works and is open source: https://github.com/PaulWoitaschek/Voice
The app itself is not designed for me personally, but at least the background playback works.
@advplyr commented on GitHub (Nov 18, 2023):
@sandreas Thanks, I've had this stackoverflow post bookmarked for a while now because it explains the issue well: https://stackoverflow.com/questions/69604951/getting-android-app-foregroundservicestartnotallowedexception-in-android-12-sdk
That exception is the one that is thrown
@advplyr commented on GitHub (Nov 18, 2023):
Notice that they say one way to prevent this from happening is to disable battery optimization:
This works for most cases. I would rather do it correctly like they explain in the post but I haven't dug into it yet, it is a lot of work it seems like.
@mihailim commented on GitHub (Nov 18, 2023):
It seems there are multiple causes manifesting in a similar way -- back when I could reliably reproduce the problem, the application battery usage was set to Unrestricted. That helped, in the sense that it significantly reduced the occurrence of the problem from multiple times per hour of playback to once every few hours, but it didn't eliminate it completely.
@advplyr commented on GitHub (Nov 18, 2023):
@mihailim Yeah I think there was an issue with media downloaded prior to the db switch in server v2.2.23
@sandreas commented on GitHub (Nov 19, 2023):
Here is a little more detail about Background-Services on Android. It's for flutter, but I personally find it useful:
https://suragch.medium.com/background-audio-in-flutter-with-audio-service-and-just-audio-3cce17b4a7d
Here is an example manifest file: https://github.com/suragch/flutter_audio_service_demo/blob/master/final/android/app/src/main/AndroidManifest.xml
Here are the most important parts:
@shvnrg commented on GitHub (Dec 7, 2023):
I had this problem too for a while now and experimented a little bit.
Could anyone with the problem try to download the media to internal app storage?
It looks like this solved the problem for me:
External Folder Library: stutter and then force close
Internal Storage: no problems
Pixel 4a, Android 13, Full Stock, Server v2.6.0, App v0.9.68-beta
@sandreas commented on GitHub (Dec 7, 2023):
Thank you for your effort, but this does not work for me. And I'd like to mention, that even if it had worked, it would not have solved the problem. My internal storage is just not big enough for the audio books I use.
I have tested several offline media player apps and used the audiobookshelf download folder as source. Some of them did show the same issue, some of them worked like a charm (mostly the trials of commercial ones). I think getting this to work may be complex task, but it has to do with adding the correct permissions into the manifest and then requesting a media session the correct way.
In addition you can allow interactions via media button by adding a
<receiver>class implementing the according interface, which will result in supporting media buttons and cable headphone remotes.This is definitely a problem in how audiobookshelf-app is implemented and not something that can be solved completely by tinkering with the android settings.
Here I summarized everything I found and the test project (written in flutter) works like a charm on my device (I modified it to use a valid audiobookshelf source and tested it for more than 2 hours of listening).
@advplyr commented on GitHub (Dec 7, 2023):
@sandreas What android version and device are you using? I know Android 10 and below will have permission issues when not using internal storage.
@sandreas commented on GitHub (Dec 7, 2023):
@advplyr
Android 12 on Unihertz Jelly 2e
Edit:
In https://github.com/advplyr/audiobookshelf-app/blob/master/android/app/src/main/AndroidManifest.xml I don't see the
android.permission.WAKE_LOCK. Is this added programmatically?@Salvoxia commented on GitHub (Dec 11, 2023):
I also have crashing problems where the app gets killed randomly when playing. Sometimes after a couple of seconds, sometimes it runs for half an hour.
App version is 0.9.68-beta on Anrdoid 13.
Only seems to be happening for certain audio books, but I was not yet able to find a significant difference between ones that work and ones that don't.
I was now able to record such a crash with
adb logcat | grep audiobookshelf. It seems like the Low Memory Killer Daemon simply kills off ABS due to "high memory pressure". See the logs at timestamp12-11 20:47:42.284:Not sure if this is related to what other people have described in this thread, symptoms seem to be similar to some reports, not to others.
When checking, my phone usually has about 3GB memory left (total 8GB), even with ABS running and playing.
I'm happy to provide more data, if guided.
@7h3ju57 commented on GitHub (Dec 23, 2023):
I'm getting the same issue.
I always download my books and experiencing the following issues.
Start the book, it starts but I have to make sure to wait for the playback bar to show up first then I can lock my phone and listen otherwise abs gets killed.
Using android auto, plays a few seconds then dies. Workaround is to start it manually on the phone, then abs in auto restarts a couple times and starts working as normal.
Running latest version of abs server and client on pixel 8
@advplyr commented on GitHub (Dec 23, 2023):
Have you tried disabling battery optimization for Abs? I'm on a pixel 6 Android 13 and don't have these issues.
There is more work to do here but I think a workaround for most is going to be disabling battery optimization.
@7h3ju57 commented on GitHub (Dec 23, 2023):
Yeah I've tried disabling battery optimization.
For me anyway the issue is due to local downloads.
To test I deleted the local version and all the issues are gone. No 15 second delay for the playback bar to appear after starting a book, and abs in android auto worked fine for at least two trips.
So looks like the issues are caused by local downloaded books?
Anything I can do to help identify any issues? Logs etc?
@Salvoxia commented on GitHub (Dec 23, 2023):
@7h3ju57 Does it make any difference for you if you download to Internal App Storage or to a manually added folder?
@gazpachoking commented on GitHub (Dec 23, 2023):
I have a pixel 5, and experience the issue with battery optimization turned off, and when downloaded to internal or external storage.
Edit: I was wrong. Internal storage does fix the problem.
@7h3ju57 commented on GitHub (Dec 24, 2023):
Can confirm downloading to internal storage fixes all the issues I was experiencing.
@gazpachoking commented on GitHub (Dec 24, 2023):
Oh! It fixes for me too. I had tested on a previous version with no luck, but it worked this time.
@Salvoxia commented on GitHub (Dec 24, 2023):
Thanks, I can confirm as well that I no longer experience the issues I described when sticking to Internal App Storage for downloaded books.
@sandreas commented on GitHub (Dec 24, 2023):
This is great, but still a WORKAROUND... not a fix. There are other apps out there working flawlessly with external storage, so it must be possible somehow. However, I understand that it is complicated and much work.
@Salvoxia commented on GitHub (Dec 24, 2023):
Sure, but for fixing reproducing this behavior is necessary, and this is an important clue as to how to reproducing the problem more or less reliably might be possible.
@sandreas commented on GitHub (Dec 24, 2023):
Absolutely. I would love to help, but I don't know how :-) Maybe I'll find the time after christmas.
@mihailim commented on GitHub (Dec 24, 2023):
For what it's worth, I can also confirm that all the app playback freezes / crashes are gone when downloading books to Internal storage, as opposed to a separate folder as I used to do before.
Pixel 6a, Android 14 on the latest patch level -- although the issue has always been intermittently present for all A14 builds when trying local playback.
Permanently exempting the app from battery optimization as advised a few months back definitely helped reduce the incidence to the point where it became impossible to reliably reproduce without waiting 20-30 minutes at the very least, but in itself that never solved the problem. This workaround did, reliably -- not a single incident for a full day (8+ hours of playback), which was never the case before.
@sandreas commented on GitHub (Apr 10, 2024):
@advplyr
Is it possible, that a request to ignore battery optimizations would help at least with a few of the crashes?
The
AndroidManifest.xmlis missing this at the moment:@advplyr commented on GitHub (Apr 10, 2024):
That looks old, is that still supported? Saw a comment saying Google Play store looks for this in app approval