Originally created by @nichwall on GitHub (Jun 28, 2023).
Steps to reproduce
Set playback speed to a value that is not a preset (using the +/- of 0.1 increments)
Expected behaviour
Notification for playback should show the playback value
Actual behaviour
Playback speed in notification is the last playback speed which matches a preset (either by using a preset or using +/- 0.1 to reach a preset)
Screenshot should be 1.7 to match previous screenshot
Environment data
Audiobookshelf Version: 0.9.65-beta
Android App?
iOS App?
Android Issue
Android version: 13
Device model: Pixel 6a
Stock or customized system: Stock
Originally created by @nichwall on GitHub (Jun 28, 2023).
### Steps to reproduce
1. Set playback speed to a value that is not a preset (using the +/- of 0.1 increments)
### Expected behaviour
- Notification for playback should show the playback value

### Actual behaviour
- Playback speed in notification is the last playback speed which matches a preset (either by using a preset or using +/- 0.1 to reach a preset)
Screenshot should be 1.7 to match previous screenshot

### Environment data
Audiobookshelf Version: 0.9.65-beta
- [x] Android App?
- [ ] iOS App?
#### Android Issue
Android version: 13
Device model: Pixel 6a
Stock or customized system: Stock
I'm not sure we will support this yet since the playback speed shown on the notification is actually an icon and not text. So to support every value there we would have to include dozens of icons.
We currently use 6 icons. 0.5x, 1x, 1.2x, 1.5x, 2x, 3x.
I thought it would be better to have the playback speed adjustable there and round to the nearest icon then to not include the playback speed there at all.
We could put in some more icons to fill the gaps between 1x and 2x but I imagine we would still get bug reports so it may be better to remove the feature.
@advplyr commented on GitHub (Jun 28, 2023):
I'm not sure we will support this yet since the playback speed shown on the notification is actually an icon and not text. So to support every value there we would have to include dozens of icons.
We currently use 6 icons. 0.5x, 1x, 1.2x, 1.5x, 2x, 3x.
I thought it would be better to have the playback speed adjustable there and round to the nearest icon then to not include the playback speed there at all.
We could put in some more icons to fill the gaps between 1x and 2x but I imagine we would still get bug reports so it may be better to remove the feature.
Oh that's nifty. I didn't notice you could tap there and change the playback speed since I almost never change it. This is not a problem for me, I just wanted to document it somewhere for when someone else notices it.
I think the current selection of presets is good enough for changing between playback speed from the notification.
@nichwall commented on GitHub (Jun 28, 2023):
Oh that's nifty. I didn't notice you could tap there and change the playback speed since I almost never change it. This is not a problem for me, I just wanted to document it somewhere for when someone else notices it.
I think the current selection of presets is good enough for changing between playback speed from the notification.
We'll keep the current functionality for now. Maybe in the future android will allow us to put a custom value there instead of using icons.
@advplyr commented on GitHub (Sep 12, 2023):
We'll keep the current functionality for now. Maybe in the future android will allow us to put a custom value there instead of using icons.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Originally created by @nichwall on GitHub (Jun 28, 2023).
Steps to reproduce
Expected behaviour
Actual behaviour
Screenshot should be 1.7 to match previous screenshot
Environment data
Audiobookshelf Version: 0.9.65-beta
Android Issue
Android version: 13
Device model: Pixel 6a
Stock or customized system: Stock
@advplyr commented on GitHub (Jun 28, 2023):
I'm not sure we will support this yet since the playback speed shown on the notification is actually an icon and not text. So to support every value there we would have to include dozens of icons.
We currently use 6 icons. 0.5x, 1x, 1.2x, 1.5x, 2x, 3x.
I thought it would be better to have the playback speed adjustable there and round to the nearest icon then to not include the playback speed there at all.
We could put in some more icons to fill the gaps between 1x and 2x but I imagine we would still get bug reports so it may be better to remove the feature.
@nichwall commented on GitHub (Jun 28, 2023):
Oh that's nifty. I didn't notice you could tap there and change the playback speed since I almost never change it. This is not a problem for me, I just wanted to document it somewhere for when someone else notices it.
I think the current selection of presets is good enough for changing between playback speed from the notification.
@advplyr commented on GitHub (Sep 12, 2023):
We'll keep the current functionality for now. Maybe in the future android will allow us to put a custom value there instead of using icons.