mirror of
https://github.com/advplyr/audiobookshelf-app.git
synced 2026-07-26 14:38:39 +02:00
[Android] Playback speed not saving between sessions #419
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/audiobookshelf-app#419
Reference in New Issue
Block a user
Originally created by @nathanmilot on GitHub (Jan 31, 2023).
Steps to reproduce
Expected behaviour
Playback should be at the selected speed. The previous version of the app did this.
Actual behaviour
It defaults to 1x.
Environment data
Audiobookshelf Version: 0.9.61-beta
Android Issue
Android version: 13
Device model:Google Pixel 6 Pro
Stock or customized system: stock
iOS Issue
iOS Version:
iPhone model:
@mym0T commented on GitHub (Feb 2, 2023):
This issue may be specific to Android. I am not able to reproduce it on iOS with version 0.9.61
@advplyr commented on GitHub (Mar 2, 2023):
I did further testing on this and it specifically has to do with the first media that loads when launching the app. The problem was a race condition between loading the saved playback speed and setting the media.
This was specific to Android but there was another bug that affected both iOS/Android after updating from any version before 0.9.61. This resolves itself after selecting the playback speed again.
@jcrmit commented on GitHub (Mar 8, 2023):
This behaviour is still occuring after update to v0.9.63-beta
@advplyr commented on GitHub (Mar 8, 2023):
@jcrmit You sideloaded the APK?
@jcrmit commented on GitHub (Mar 8, 2023):
Yes I always do. Is that an issue?
@advplyr commented on GitHub (Mar 8, 2023):
Not an issue.
If you set the playback speed on an audiobook. Close and re-open the app. The most recent audiobooks should automatically open and that is not showing the updated playback speed?
@jcrmit commented on GitHub (Mar 8, 2023):
Have an audioplaying set to 1.4x (intentionally changed from 1.5x)
Closed the re-opened the app
The book that was playing opens (in bottom banner)
When I click to expand, playback speed have returned to 1x
@rweatherly commented on GitHub (Mar 8, 2023):
I wanted to jump in and add that both myself (Pixel 7) and a friend of mine (Pixel 6) are experiencing the same issue, we are both using Android 13 and v0.9.62 version of the play store app, not sideloaded. its not every time, but it does occur at least once every day or three
@i-am-at0m commented on GitHub (Mar 9, 2023):
I also noticed it on my Pixel 7 Pro and just gave up on using it because I open the app multiple times a day but rarely switch books.
@advplyr commented on GitHub (Mar 10, 2023):
I thought I fixed this in the 0.9.63-beta just released on the play store. Can others test this on the latest version?
@i-am-at0m commented on GitHub (Mar 10, 2023):
Nope, not fixed. Have a video showing how I reproduced it, but don't want to post it publicly because it has my public-facing server url in it. How can I get it to you?
@rweatherly commented on GitHub (Mar 10, 2023):
i just got the update via the play store last night and it hasn't happened since, but i will update here if it happens again.
@rweatherly commented on GitHub (Mar 10, 2023):
SO i checked with my friend who did also get the update and she is having the issue, while it seems im not. She reported then when she fully backed out of the app and then when its started and has to connect to the server, it seems to be that time when it does the reset. I tested this and it does not happen to me. It does seem to be taking longer to connect with this update though.
the only difference im aware of is that the ABS server is on my local network, so im connecting over the LAN, and she is going over the internet to a reverse proxy that is passing the traffic to the server. Let me know if there is any other tests, or logs that i can gather that would be useful
@i-am-at0m commented on GitHub (Mar 10, 2023):
It was glitching and resetting for me yesterday on lan and reverse proxy,
and I tested it just now on reverse proxy and it saved correctly. Recorded
another video I'll send on to advplyr.
On Fri, Mar 10, 2023, 09:25 rweatherly @.***> wrote:
@advplyr commented on GitHub (Mar 10, 2023):
I was just able to reproduce this so hopefully I can track it down now. It does appear to be a race condition since sometimes it happens sometimes it doesn't. Thanks for all the info
@advplyr commented on GitHub (Mar 10, 2023):
I narrowed this down to the audio player opening on load is resetting the saved playback speed. The reason I didn't catch this is because oddly it only happens on the production app, I still cannot reproduce this in development.
The way you can have this working for now if you really need it is to download the book you are listening to. Then logout of your server. As long as you are logged out before you close and re-open the app then the player won't open automatically.
The player only opens automatically on app launch after it establishes a server connection. If you have logged out before closing then the app won't attempt to connect to the server on launch.
@PyroghostX commented on GitHub (Apr 5, 2023):
My friend and I both have this on android on the latest google play version.
It happens every time we open the app. I have it set at 1.2 or 1.5, and every single time reopening the app (after it has closed) it will be back at 1x speed.
Have you been able to figure it out? Is there any troubleshooting I can help do?
@advplyr commented on GitHub (May 23, 2023):
Fixed in v0.9.64-beta
@advplyr commented on GitHub (May 23, 2023):
The problem was the auto-opening of the most recent listened item. This was removed
@advplyr commented on GitHub (May 31, 2023):
Just tested and this issue persists
@PyroghostX commented on GitHub (May 31, 2023):
I haven't had it, playback has stayed at 1.7x for a while now
@advplyr commented on GitHub (May 31, 2023):
@PyroghostX On Android?
@PyroghostX commented on GitHub (May 31, 2023):
yes, android 13
@rweatherly commented on GitHub (May 31, 2023):
Jumping in to report two more Android 13 Pixels that have not seen any issues with the playback speed since the latest update. We are both daily users of it.
@advplyr commented on GitHub (May 31, 2023):
Hmm that's good news but also makes this more confusing as some people are.
By any chance did you uninstall and reinstall the app completely at some point between when the bug was happening and it being fixed?
@rweatherly commented on GitHub (May 31, 2023):
Neither of us have done an app reinstall.
@feerlessleadr commented on GitHub (May 31, 2023):
Same position as others. I'm on Android 13 on my OnePlus 8t and I haven't had this issue since it was resolved back in April. I didn't uninstall and reinstall or anything.
@rendyhd commented on GitHub (May 31, 2023):
The issue is fixed for me too, no new install just updated to last version
@advplyr commented on GitHub (Jun 2, 2023):
I found a bug where the promise was never getting resolved resulting in the locally saved playback speed never getting fetched. This explains why it happens sometimes or for some users and not others.
@advplyr commented on GitHub (Jun 25, 2023):
Fixed in v0.9.65-beta