starred/audiobookshelf-app
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf-app.git synced 2026-07-27 15:08:40 +02:00
Code Issues 454 Packages Projects Releases 10 Wiki Activity

[PR #1739] Fix clicking next chapter button #1678

New Issue
Open
opened 2026-04-25 00:00:33 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:00:33 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1739
Author: @Cutch
Created: 11/27/2025
Status: 🔄 Open

Base: master ← Head: fix_next_seek

📝 Commits (1)

  • 01299c1 Fix clicking next chapter button

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 components/app/AudioPlayer.vue (+2 -2)

📄 Description

Brief summary

The next chapter button has a bug, repeated clicks to next chapter does not work if chapters have have decimal places.

Which issue is fixed?

Pull Request Type

Test on android

In-depth Description

The next chapter button has a bug. It does not allow repeated clicks because seek, seeks to the floor(time) but the chapter identification uses .toFixed(2). Next chapter only works if the time is greater than the decimal value of the chapter.
This seems to be the only option as AbsAudioPlayer.seek does not seem to accept decimal values.

How have you tested this?

Android studio virtual phone

Screenshots

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1739 **Author:** [@Cutch](https://github.com/Cutch) **Created:** 11/27/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix_next_seek` --- ### 📝 Commits (1) - [`01299c1`](https://github.com/advplyr/audiobookshelf-app/commit/01299c1ce117c4c4c8f66899789224eb6dbdd656) Fix clicking next chapter button ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `components/app/AudioPlayer.vue` (+2 -2) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary The next chapter button has a bug, repeated clicks to next chapter does not work if chapters have have decimal places. <!-- Please provide a brief summary of what your PR attempts to achieve. --> ## Which issue is fixed? <!-- Which issue number does this PR fix? Ex: "Fixes #1234" --> ## Pull Request Type <!-- Does this affect only Android, only iOS, or both? Does this change the frontend or the backend of the apps? --> Test on android ## In-depth Description <!-- Describe your solution in more depth. How does it work? Why is this the best solution? Does it solve a problem that affects multiple users or is this an edge case for your setup? --> The next chapter button has a bug. It does not allow repeated clicks because seek, seeks to the floor(time) but the chapter identification uses .toFixed(2). Next chapter only works if the time is greater than the decimal value of the chapter. This seems to be the only option as AbsAudioPlayer.seek does not seem to accept decimal values. ## How have you tested this? Android studio virtual phone <!-- Please describe in detail with reproducible steps how you tested your changes. --> ## Screenshots <!-- If your PR includes any changes to the front-end, please include screenshots or a short video from before and after your changes. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:00:33 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
android auto
backlog
bug
enhancement
ereader
help wanted
iOS
progress sync
pull-request
Mirrored from GitHub Pull Request
 sleep timer
unable to reproduce
waiting
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1678