[PR #1660] [CLOSED] Fix OIDC button not appearing during re-login when refresh token is missing #1650

New Issue

2026-04-25T00:00:18+02:00

adam commented

2026-04-25 00:00:18 +02:00

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1660
Author: @jtbrush56
Created: 8/14/2025
Status: ❌ Closed

Base: master ← Head: fix-oidc-button-relogin

📝 Commits (1)

02d801f Fix OIDC button not appearing during re-login when refresh token is missing

📊 Changes

1 file changed (+15 additions, -0 deletions)

View changed files

📝 components/connection/ServerConnectForm.vue (+15 -0)

📄 Description

Problem

The OIDC login button was not appearing when manually reconnecting to servers that support OpenID authentication, specifically when refresh tokens were missing or expired.

Root Cause

The connectToServer method only called /ping and /api/authorize endpoints during reconnection, but never fetched authentication methods from /status, leaving authMethods empty.

Solution

Added call to getServerAddressStatus() when token authentication fails
Populates authMethods array before showing auth form
Includes robust error handling for graceful fallback
Reuses existing proven logic for consistency

Changes

File: components/connection/ServerConnectForm.vue (lines 474-490)
Backward Compatible: ✅ No breaking changes
Error Handling: ✅ Graceful fallback to local auth

Result

Users can now see and use the OIDC button when reconnecting to servers after refresh token expiration.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1660 **Author:** [@jtbrush56](https://github.com/jtbrush56) **Created:** 8/14/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-oidc-button-relogin` --- ### 📝 Commits (1) - [`02d801f`](https://github.com/advplyr/audiobookshelf-app/commit/02d801f6db3cfe9a53b8a97067a805f440fe51b8) Fix OIDC button not appearing during re-login when refresh token is missing ### 📊 Changes **1 file changed** (+15 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `components/connection/ServerConnectForm.vue` (+15 -0) </details> ### 📄 Description ## Problem The OIDC login button was not appearing when manually reconnecting to servers that support OpenID authentication, specifically when refresh tokens were missing or expired. ## Root Cause The `connectToServer` method only called `/ping` and `/api/authorize` endpoints during reconnection, but never fetched authentication methods from `/status`, leaving `authMethods` empty. ## Solution - Added call to `getServerAddressStatus()` when token authentication fails - Populates `authMethods` array before showing auth form - Includes robust error handling for graceful fallback - Reuses existing proven logic for consistency ## Changes - **File:** `components/connection/ServerConnectForm.vue` (lines 474-490) - **Backward Compatible:** ✅ No breaking changes - **Error Handling:** ✅ Graceful fallback to local auth ## Result Users can now see and use the OIDC button when reconnecting to servers after refresh token expiration. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-04-25 00:00:18 +02:00

adam closed this issue

2026-04-25 00:00:18 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1650