[PR #1640] fix: session resumption issues #1646

New Issue

2026-04-24T23:59:56+02:00

adam commented

2026-04-24 23:59:56 +02:00

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1640
Author: @AwsomeFox
Created: 7/23/2025
Status: 🔄 Open

Base: master ← Head: fix-session-resume

📝 Commits (1)

a735336 fix: session resumption issues

📊 Changes

2 files changed (+1 additions, -3 deletions)

View changed files

📝 android/app/src/main/java/com/audiobookshelf/app/player/PlayerNotificationListener.kt (+1 -1)
📝 android/app/src/main/java/com/audiobookshelf/app/player/PlayerNotificationService.kt (+0 -2)

📄 Description

Brief summary

Fixes session resumption problems by altering logic when updating notification and when user swipes away application.

Which issue is fixed?

Should fix
https://github.com/advplyr/audiobookshelf-app/issues/1309

Pull Request Type

Only android

In-depth Description

I've pinpointed the logic error in PlayerNotificationListener.kt. The isForegroundService flag was being set to false even when the notification was just being updated, not dismissed by the user. This made the service vulnerable to being killed by the system. Moved the isForegroundService = false line to be within the if (dismissedByUser) block. This change ensures that the service remains in a foreground state when paused, which is the correct behavior. This should resolve the issue where Android Auto fails to resume playback.

The current onTaskRemoved implementation is too aggressive and stops the service even when paused. The correct approach is to let the service continue running when the app is swiped from the recents list. The service's lifecycle is already correctly managed by the PlayerNotificationManager, which will stop the service when the user dismisses the notification (which is only possible when playback is paused).

How have you tested this?

Still testing since it is intermittent. Also want to see the affects on battery life if any.

Update: tested after overnight and killing the app. The book resumes in android auto just fine now. I did test with https://github.com/advplyr/audiobookshelf-app/pull/1641 at the same time.

Screenshots

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1640 **Author:** [@AwsomeFox](https://github.com/AwsomeFox) **Created:** 7/23/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-session-resume` --- ### 📝 Commits (1) - [`a735336`](https://github.com/advplyr/audiobookshelf-app/commit/a735336d69e0f431c6e45cd30121b57b46ac97fd) fix: session resumption issues ### 📊 Changes **2 files changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `android/app/src/main/java/com/audiobookshelf/app/player/PlayerNotificationListener.kt` (+1 -1) 📝 `android/app/src/main/java/com/audiobookshelf/app/player/PlayerNotificationService.kt` (+0 -2) </details> ### 📄 Description  ## Brief summary Fixes session resumption problems by altering logic when updating notification and when user swipes away application.  ## Which issue is fixed? Should fix https://github.com/advplyr/audiobookshelf-app/issues/1309  ## Pull Request Type Only android  ## In-depth Description I've pinpointed the logic error in PlayerNotificationListener.kt. The isForegroundService flag was being set to false even when the notification was just being updated, not dismissed by the user. This made the service vulnerable to being killed by the system. Moved the isForegroundService = false line to be within the if (dismissedByUser) block. This change ensures that the service remains in a foreground state when paused, which is the correct behavior. This should resolve the issue where Android Auto fails to resume playback. The current onTaskRemoved implementation is too aggressive and stops the service even when paused. The correct approach is to let the service continue running when the app is swiped from the recents list. The service's lifecycle is already correctly managed by the PlayerNotificationManager, which will stop the service when the user dismisses the notification (which is only possible when playback is paused).  ## How have you tested this?  Still testing since it is intermittent. Also want to see the affects on battery life if any. Update: tested after overnight and killing the app. The book resumes in android auto just fine now. I did test with https://github.com/advplyr/audiobookshelf-app/pull/1641 at the same time. ## Screenshots  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-04-24 23:59:56 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1646