Adds a toggle for the feature of auto selecting the bookmark text input. The reason being some users (like myself) don't want the keyboard to pop up when setting a bookmark and don't care about the text.
Which issue is fixed?
None
Pull Request Type
Affects both apps.
Affects both the frontend and backend of the apps (adds a new item into the device settings data store)
In-depth Description
Recently a change was made to auto select the text input when creating a bookmark. This negatively affected my use of the app as when I'm listening at night I would like to just quickly set a bookmark and then go to sleep. Auto selecting the text input makes the bright keyboard pop up and makes it harder to select create bookmark. I have added a toggle which allows users to disable the auto select so they can go back to how the app worked before. This way it still defaults to the new method but for users that would like to go back they now have an option.
How have you tested this?
Open the app
Start listening to an audiobook
Create a bookmark (This should auto select the text input)
Go to settings
Enable the toggle for disable auto focus
Create a bookmark (This should not auto select the text input)
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1611
**Author:** [@abguymon](https://github.com/abguymon)
**Created:** 6/22/2025
**Status:** ❌ Closed
**Base:** `master` ← **Head:** `toggle-bookmark-focus`
---
### 📝 Commits (4)
- [`3f0e856`](https://github.com/advplyr/audiobookshelf-app/commit/3f0e856d87ecf3660a65bb2371439417be9aa1b8) pushing up toggle feature
- [`80afdcc`](https://github.com/advplyr/audiobookshelf-app/commit/80afdcca37245534ab27ae9af2a961b50110e583) defaulting to true
- [`0733959`](https://github.com/advplyr/audiobookshelf-app/commit/073395914a0530447997a9ab7e66aa75b7c1e54b) toggle is now working
- [`833300e`](https://github.com/advplyr/audiobookshelf-app/commit/833300ef49a13c4c1bb8be6d8152e027ff12eb01) finishing up change
### 📊 Changes
**3 files changed** (+40 additions, -4 deletions)
<details>
<summary>View changed files</summary>
📝 `android/app/src/main/java/com/audiobookshelf/app/data/DeviceClasses.kt` (+4 -2)
📝 `components/modals/BookmarksModal.vue` (+15 -1)
📝 `pages/settings.vue` (+21 -1)
</details>
### 📄 Description
## Brief summary
Adds a toggle for the feature of auto selecting the bookmark text input. The reason being some users (like myself) don't want the keyboard to pop up when setting a bookmark and don't care about the text.
## Which issue is fixed?
None
## Pull Request Type
Affects both apps.
Affects both the frontend and backend of the apps (adds a new item into the device settings data store)
## In-depth Description
Recently a change was made to auto select the text input when creating a bookmark. This negatively affected my use of the app as when I'm listening at night I would like to just quickly set a bookmark and then go to sleep. Auto selecting the text input makes the bright keyboard pop up and makes it harder to select create bookmark. I have added a toggle which allows users to disable the auto select so they can go back to how the app worked before. This way it still defaults to the new method but for users that would like to go back they now have an option.
## How have you tested this?
1. Open the app
2. Start listening to an audiobook
3. Create a bookmark (This should auto select the text input)
4. Go to settings
5. Enable the toggle for disable auto focus
6. Create a bookmark (This should **not** auto select the text input)
## Screenshots
**BEFORE**
https://github.com/user-attachments/assets/3a5dd2f8-0a80-4454-a194-cad23a528e92
**AFTER**
https://github.com/user-attachments/assets/0ae9693c-cb68-4070-bdb9-5006dc4c4105
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1611
Author: @abguymon
Created: 6/22/2025
Status: ❌ Closed
Base:
master← Head:toggle-bookmark-focus📝 Commits (4)
3f0e856pushing up toggle feature80afdccdefaulting to true0733959toggle is now working833300efinishing up change📊 Changes
3 files changed (+40 additions, -4 deletions)
View changed files
📝
android/app/src/main/java/com/audiobookshelf/app/data/DeviceClasses.kt(+4 -2)📝
components/modals/BookmarksModal.vue(+15 -1)📝
pages/settings.vue(+21 -1)📄 Description
Brief summary
Adds a toggle for the feature of auto selecting the bookmark text input. The reason being some users (like myself) don't want the keyboard to pop up when setting a bookmark and don't care about the text.
Which issue is fixed?
None
Pull Request Type
Affects both apps.
Affects both the frontend and backend of the apps (adds a new item into the device settings data store)
In-depth Description
Recently a change was made to auto select the text input when creating a bookmark. This negatively affected my use of the app as when I'm listening at night I would like to just quickly set a bookmark and then go to sleep. Auto selecting the text input makes the bright keyboard pop up and makes it harder to select create bookmark. I have added a toggle which allows users to disable the auto select so they can go back to how the app worked before. This way it still defaults to the new method but for users that would like to go back they now have an option.
How have you tested this?
Screenshots
BEFORE
https://github.com/user-attachments/assets/3a5dd2f8-0a80-4454-a194-cad23a528e92
AFTER
https://github.com/user-attachments/assets/0ae9693c-cb68-4070-bdb9-5006dc4c4105
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.