[PR #1612] [MERGED] Update create bookmark to not autofocus input and use placeholder #1634

New Issue

2026-04-24T23:59:51+02:00

adam commented

2026-04-24 23:59:51 +02:00

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1612
Author: @advplyr
Created: 6/23/2025
Status: ✅ Merged
Merged: 6/23/2025
Merged by: @advplyr

Base: master ← Head: create_bookmarks_focus

📝 Commits (1)

a77f345 Update create bookmark to not autofocus input and leave empty with placeholder

📊 Changes

3 files changed (+18 additions, -15 deletions)

View changed files

📝 components/modals/BookmarksModal.vue (+6 -12)
📝 components/ui/TextInput.vue (+5 -1)
📝 components/ui/TextInputWithLabel.vue (+7 -2)

📄 Description

Brief summary

When pressing create bookmark the current functionality is to focus the input and select the input value.

This update removes the autofocus and leaves the input value blank with a placeholder value.

Which issue is fixed?

No issue but fixes issue mentioned in PR #1611

Pull Request Type

Both android/ios

In-depth Description

Auto-focusing and selecting the bookmark input was originally added because when using a custom bookmark note the input value had to be deleted first. By having the input text auto-selected you could start typing for a custom note or press create to use the default note.

This PR removes the need to auto-select the text in the input because the input will be empty. The only downside is the input will have to be pressed to open the keyboard to add a custom note instead of automatically opened.

If it is preferred to auto open the keyboard we could look at a different design that uses a quick create button or uses a similar design to the web app.

Screenshots

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1612 **Author:** [@advplyr](https://github.com/advplyr) **Created:** 6/23/2025 **Status:** ✅ Merged **Merged:** 6/23/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `create_bookmarks_focus` --- ### 📝 Commits (1) - [`a77f345`](https://github.com/advplyr/audiobookshelf-app/commit/a77f3455968e080b492707cbdc0d757a6a085136) Update create bookmark to not autofocus input and leave empty with placeholder ### 📊 Changes **3 files changed** (+18 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `components/modals/BookmarksModal.vue` (+6 -12) 📝 `components/ui/TextInput.vue` (+5 -1) 📝 `components/ui/TextInputWithLabel.vue` (+7 -2) </details> ### 📄 Description  ## Brief summary When pressing create bookmark the current functionality is to focus the input and select the input value. This update removes the autofocus and leaves the input value blank with a placeholder value. ## Which issue is fixed? No issue but fixes issue mentioned in PR #1611 ## Pull Request Type Both android/ios ## In-depth Description Auto-focusing and selecting the bookmark input was originally added because when using a custom bookmark note the input value had to be deleted first. By having the input text auto-selected you could start typing for a custom note or press create to use the default note. This PR removes the need to auto-select the text in the input because the input will be empty. The only downside is the input will have to be pressed to open the keyboard to add a custom note instead of automatically opened. If it is preferred to auto open the keyboard we could look at a different design that uses a quick create button or uses a similar design to the web app. ## Screenshots ![image](https://github.com/user-attachments/assets/78c5dd2a-2035-4ca3-9d0e-779bf1dcbb43) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-04-24 23:59:51 +02:00

adam closed this issue

2026-04-24 23:59:52 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1634