starred/audiobookshelf-app
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf-app.git synced 2026-07-24 05:28:35 +02:00
Code Issues 454 Packages Projects Releases 10 Wiki Activity

[PR #1556] [MERGED] fix(InternalDownloadManager): add accept-encoding identity to requests #1618

New Issue
Closed
opened 2026-04-24 23:59:44 +02:00 by adam · 0 comments
adam commented 2026-04-24 23:59:44 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1556
Author: @Zibbp
Created: 4/25/2025
Status: ✅ Merged
Merged: 4/25/2025
Merged by: @advplyr

Base: master ← Head: master

📝 Commits (2)

  • dfc77ea fix(InternalDownloadManager): add accept-encoding identity to requests
  • b03f59a fix(InternalDownloadManager): set accept-encoding header on just the download task

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 android/app/src/main/java/com/audiobookshelf/app/managers/InternalDownloadManager.kt (+1 -1)

📄 Description

Fixes https://github.com/advplyr/audiobookshelf-app/issues/1553.
@nichwall pointed me in the correct direction for a fix. I've tested this against my server through a reverse proxy with gzip and without the proxy, directly to the container, both work fine. This disables compression for requests using the internal download manager client. As seen in the issue the okhttp client is sending an accept encoding for gzip by default which causes issues.
And more testing you want to do on your end?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1556 **Author:** [@Zibbp](https://github.com/Zibbp) **Created:** 4/25/2025 **Status:** ✅ Merged **Merged:** 4/25/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`dfc77ea`](https://github.com/advplyr/audiobookshelf-app/commit/dfc77ea0d0eff6db88b172dfff37138551fe7d42) fix(InternalDownloadManager): add accept-encoding identity to requests - [`b03f59a`](https://github.com/advplyr/audiobookshelf-app/commit/b03f59ace337d2dca5e774a6d0f82b2dc01309a3) fix(InternalDownloadManager): set accept-encoding header on just the download task ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `android/app/src/main/java/com/audiobookshelf/app/managers/InternalDownloadManager.kt` (+1 -1) </details> ### 📄 Description Fixes https://github.com/advplyr/audiobookshelf-app/issues/1553. @nichwall pointed me in the correct direction for a fix. I've tested this against my server through a reverse proxy with gzip and without the proxy, directly to the container, both work fine. This disables compression for requests using the internal download manager client. As seen in the issue the okhttp client is sending an accept encoding for gzip by default which causes issues. And more testing you want to do on your end? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-24 23:59:44 +02:00
adam closed this issue 2026-04-24 23:59:44 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
android auto
backlog
bug
enhancement
ereader
help wanted
iOS
progress sync
pull-request
Mirrored from GitHub Pull Request
 sleep timer
unable to reproduce
waiting
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1618