starred/audiobookshelf-app
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf-app.git synced 2026-07-24 13:38:37 +02:00
Code Issues 454 Packages Projects Releases 10 Wiki Activity

[PR #1523] [MERGED] iOS: Bugfix: resolve race condition when rebuilding queue for seeking back #1608

New Issue
Closed
opened 2026-04-24 23:59:40 +02:00 by adam · 0 comments
adam commented 2026-04-24 23:59:40 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1523
Author: @complacentsee
Created: 3/22/2025
Status: ✅ Merged
Merged: 3/22/2025
Merged by: @advplyr

Base: master ← Head: ios_seekbacktrackbugfix

📝 Commits (1)

  • 647bd81 iOS: resolve race condition when rebuilding queue for seeking back

📊 Changes

1 file changed (+14 additions, -0 deletions)

View changed files

📝 ios/App/Shared/player/AudioPlayer.swift (+14 -0)

📄 Description

This resolves a bug I introduced in c72f7cd where a race condition exists when seeking requires rebuilding the audioPlayer item queue and the observers monitor that there is an item playing to ensure stopping at the end of the players queue.
This PR allows the player to keep track if seeking is causing the audioPlayer item queue to be rebuilding, ensuring we don't end the session inadvertently.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1523 **Author:** [@complacentsee](https://github.com/complacentsee) **Created:** 3/22/2025 **Status:** ✅ Merged **Merged:** 3/22/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `ios_seekbacktrackbugfix` --- ### 📝 Commits (1) - [`647bd81`](https://github.com/advplyr/audiobookshelf-app/commit/647bd8193b789b7507cbc9dcb8c76406324772e0) iOS: resolve race condition when rebuilding queue for seeking back ### 📊 Changes **1 file changed** (+14 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `ios/App/Shared/player/AudioPlayer.swift` (+14 -0) </details> ### 📄 Description This resolves a bug I introduced in c72f7cd where a race condition exists when seeking requires rebuilding the audioPlayer item queue and the observers monitor that there is an item playing to ensure stopping at the end of the players queue. This PR allows the player to keep track if seeking is causing the audioPlayer item queue to be rebuilding, ensuring we don't end the session inadvertently. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-24 23:59:40 +02:00
adam closed this issue 2026-04-24 23:59:40 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
android auto
backlog
bug
enhancement
ereader
help wanted
iOS
progress sync
pull-request
Mirrored from GitHub Pull Request
 sleep timer
unable to reproduce
waiting
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1608