[PR #1512] [MERGED] IOS: Support autoRewind and disableAutoRewind setting #1606

Closed
opened 2026-04-24 23:59:39 +02:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1512
Author: @complacentsee
Created: 3/11/2025
Status: Merged
Merged: 3/12/2025
Merged by: @advplyr

Base: masterHead: ios_autorewind


📝 Commits (2)

  • 922601e IOS: Support autoRewind and disableAutoRewind setting
  • 35d60ec Match rewind times to android

📊 Changes

3 files changed (+54 additions, -27 deletions)

View changed files

📝 ios/App/AudiobookshelfUnitTests/Shared/player/util/PlayerTimeUtilsTests.swift (+38 -11)
📝 ios/App/Shared/player/util/PlayerTimeUtils.swift (+15 -15)
📝 pages/settings.vue (+1 -1)

📄 Description

This addresses issue #1447. Most of the code to support this was added in 2022, but in practice it isn't working as intended, it looks like the tests didn't test that the resultant code when used completely would result in the correct time, just components that passed tests correctly.

This request does the following:

  1. Updates the PlayerTimeUtils handle time intervals correctly.
  2. Updates the test suite to test the PlayerTimeUtils.calcSeekBackTime at all ranges.
  3. Enables the setting for disable auto rewind in iOS UI.
  4. Updates PlayerTimeUtils such that the disable auto rewind setting is used.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1512 **Author:** [@complacentsee](https://github.com/complacentsee) **Created:** 3/11/2025 **Status:** ✅ Merged **Merged:** 3/12/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `ios_autorewind` --- ### 📝 Commits (2) - [`922601e`](https://github.com/advplyr/audiobookshelf-app/commit/922601eab7d2c2d46c6e1f8e6cc8cc311275683f) IOS: Support autoRewind and disableAutoRewind setting - [`35d60ec`](https://github.com/advplyr/audiobookshelf-app/commit/35d60ecaa067b95fd2fb48ab771b95a9f249f873) Match rewind times to android ### 📊 Changes **3 files changed** (+54 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `ios/App/AudiobookshelfUnitTests/Shared/player/util/PlayerTimeUtilsTests.swift` (+38 -11) 📝 `ios/App/Shared/player/util/PlayerTimeUtils.swift` (+15 -15) 📝 `pages/settings.vue` (+1 -1) </details> ### 📄 Description This addresses issue #1447. Most of the code to support this was added in 2022, but in practice it isn't working as intended, it looks like the tests didn't test that the resultant code when used completely would result in the correct time, just components that passed tests correctly. This request does the following: 1. Updates the PlayerTimeUtils handle time intervals correctly. 2. Updates the test suite to test the PlayerTimeUtils.calcSeekBackTime at all ranges. 3. Enables the setting for disable auto rewind in iOS UI. 4. Updates PlayerTimeUtils such that the disable auto rewind setting is used. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-24 23:59:39 +02:00
adam closed this issue 2026-04-24 23:59:40 +02:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1606