[PR #1469] [MERGED] Download manager cleanup #1593

New Issue

2026-04-24T23:59:32+02:00

adam commented

2026-04-24 23:59:32 +02:00

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1469
Author: @nichwall
Created: 2/7/2025
Status: ✅ Merged
Merged: 2/8/2025
Merged by: @advplyr

Base: master ← Head: download_manager_cleanup

📝 Commits (3)

3b3f941 Iniital refactor and adding comments
5a1951b InternalDownloadManager autoformatting and comments
1141c6f Remove read timeout for connection

📊 Changes

2 files changed (+292 additions, -160 deletions)

View changed files

📝 android/app/src/main/java/com/audiobookshelf/app/managers/DownloadItemManager.kt (+219 -127)
📝 android/app/src/main/java/com/audiobookshelf/app/managers/InternalDownloadManager.kt (+73 -33)

📄 Description

This PR refactors the DownloadItemManager.kt and InternalDownloadManager.kt by:

Adding comments to functions
Applying autoformatting
Refactoring functions into smaller functions to make reuse and replacement simpler
Increases the cache size for writing internal files from the InputBufferStream
No functional changes were made

This PR is part of an effort to document files without introducing functional changes to make things a bit easier to follow.

This was tested by downloading files to both internal and external folders on a Pixel 6a running Android 15.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1469 **Author:** [@nichwall](https://github.com/nichwall) **Created:** 2/7/2025 **Status:** ✅ Merged **Merged:** 2/8/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `download_manager_cleanup` --- ### 📝 Commits (3) - [`3b3f941`](https://github.com/advplyr/audiobookshelf-app/commit/3b3f94124a4ca60cdd9d2293a4080cea82dba83e) Iniital refactor and adding comments - [`5a1951b`](https://github.com/advplyr/audiobookshelf-app/commit/5a1951b495ae9ae05d1fd84032dffef1962525ee) InternalDownloadManager autoformatting and comments - [`1141c6f`](https://github.com/advplyr/audiobookshelf-app/commit/1141c6f7a527b71e967dae8aa7154b4e1e7f6494) Remove read timeout for connection ### 📊 Changes **2 files changed** (+292 additions, -160 deletions) <details> <summary>View changed files</summary> 📝 `android/app/src/main/java/com/audiobookshelf/app/managers/DownloadItemManager.kt` (+219 -127) 📝 `android/app/src/main/java/com/audiobookshelf/app/managers/InternalDownloadManager.kt` (+73 -33) </details> ### 📄 Description This PR refactors the `DownloadItemManager.kt` and `InternalDownloadManager.kt` by: - Adding comments to functions - Applying autoformatting - Refactoring functions into smaller functions to make reuse and replacement simpler - Increases the cache size for writing internal files from the `InputBufferStream` - No functional changes were made This PR is part of an effort to document files without introducing functional changes to make things a bit easier to follow. This was tested by downloading files to both internal and external folders on a Pixel 6a running Android 15. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-04-24 23:59:32 +02:00

adam closed this issue

2026-04-24 23:59:32 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1593