starred/audiobookshelf-app
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf-app.git synced 2026-07-26 06:28:43 +02:00
Code Issues 454 Packages Projects Releases 10 Wiki Activity

[PR #1468] [MERGED] Devicemanager settings revert #1592

New Issue
Closed
opened 2026-04-24 23:59:31 +02:00 by adam · 0 comments
adam commented 2026-04-24 23:59:31 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1468
Author: @nichwall
Created: 2/7/2025
Status: ✅ Merged
Merged: 2/8/2025
Merged by: @advplyr

Base: master ← Head: devicemanager_settings_revert

📝 Commits (2)

  • 853a12b Revert "Simplify default value assignment"
  • bb56a55 Fix: end time default value

📊 Changes

1 file changed (+34 additions, -18 deletions)

View changed files

📝 android/app/src/main/java/com/audiobookshelf/app/device/DeviceManager.kt (+34 -18)

📄 Description

This PR fixes an issue introduced by my original rewrite in https://github.com/advplyr/audiobookshelf-app/pull/1462.

Some of the settings would be reset upon restarting the app after more testing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1468 **Author:** [@nichwall](https://github.com/nichwall) **Created:** 2/7/2025 **Status:** ✅ Merged **Merged:** 2/8/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `devicemanager_settings_revert` --- ### 📝 Commits (2) - [`853a12b`](https://github.com/advplyr/audiobookshelf-app/commit/853a12b0dd0b33f054d1d0bf182e7b4e582b9b36) Revert "Simplify default value assignment" - [`bb56a55`](https://github.com/advplyr/audiobookshelf-app/commit/bb56a5514376f092fedf5b6288f0197ccdf018c2) Fix: end time default value ### 📊 Changes **1 file changed** (+34 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `android/app/src/main/java/com/audiobookshelf/app/device/DeviceManager.kt` (+34 -18) </details> ### 📄 Description This PR fixes an issue introduced by my original rewrite in https://github.com/advplyr/audiobookshelf-app/pull/1462. Some of the settings would be reset upon restarting the app after more testing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-24 23:59:31 +02:00
adam closed this issue 2026-04-24 23:59:31 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
android auto
backlog
bug
enhancement
ereader
help wanted
iOS
progress sync
pull-request
Mirrored from GitHub Pull Request
 sleep timer
unable to reproduce
waiting
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1592