[PR #1462] [MERGED] Andriod DeviceManager.kt cleanup #1589

New Issue

2026-04-24T23:59:30+02:00

adam commented

2026-04-24 23:59:30 +02:00

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1462
Author: @nichwall
Created: 2/2/2025
Status: ✅ Merged
Merged: 2/2/2025
Merged by: @advplyr

Base: master ← Head: andriod_deviceManager_cleanup

📝 Commits (3)

973dca8 Add: function comments, autoformatting applied
d4090d1 Simplify default value assignment
9e7a76b Simplify nullable return

📊 Changes

1 file changed (+111 additions, -70 deletions)

View changed files

📝 android/app/src/main/java/com/audiobookshelf/app/device/DeviceManager.kt (+111 -70)

📄 Description

Overview

This PR cleans up the DeviceManager.kt file.

Detailed description

No functional changes were made
Code was autoformatted
Javadoc-style comments were added
Some syntax cleanup, particularly in the default device settings
Fixed autoSleepTimerStartTime being set twice instead of autoSleepTimerEndTime

How was this tested?

Tested on Android 15 with a Pixel 6a. I did not test with downgrading and upgrading the versions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1462 **Author:** [@nichwall](https://github.com/nichwall) **Created:** 2/2/2025 **Status:** ✅ Merged **Merged:** 2/2/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `andriod_deviceManager_cleanup` --- ### 📝 Commits (3) - [`973dca8`](https://github.com/advplyr/audiobookshelf-app/commit/973dca83a2aa61d45a24580a879756d68f78d690) Add: function comments, autoformatting applied - [`d4090d1`](https://github.com/advplyr/audiobookshelf-app/commit/d4090d15be592ebdc19136f5128725e2c34f7494) Simplify default value assignment - [`9e7a76b`](https://github.com/advplyr/audiobookshelf-app/commit/9e7a76bd97e35f02cb2c7276c60279425f9933f7) Simplify nullable return ### 📊 Changes **1 file changed** (+111 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `android/app/src/main/java/com/audiobookshelf/app/device/DeviceManager.kt` (+111 -70) </details> ### 📄 Description ## Overview This PR cleans up the `DeviceManager.kt` file. ## Detailed description - No functional changes were made - Code was autoformatted - Javadoc-style comments were added - Some syntax cleanup, particularly in the default device settings - Fixed `autoSleepTimerStartTime` being set twice instead of `autoSleepTimerEndTime` ## How was this tested? Tested on Android 15 with a Pixel 6a. I did not test with downgrading and upgrading the versions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-04-24 23:59:30 +02:00

adam closed this issue

2026-04-24 23:59:31 +02:00

adam referenced this issue

2026-04-24 23:59:50 +02:00

[PR #1589] [MERGED] Translations update from Hosted Weblate #1630

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1589

[PR #1462] [MERGED] Andriod DeviceManager.kt cleanup #1589