[PR #1461] [MERGED] Build apk workflow update #1587

Closed
opened 2026-04-24 23:59:29 +02:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1461
Author: @nichwall
Created: 1/30/2025
Status: Merged
Merged: 1/31/2025
Merged by: @advplyr

Base: masterHead: build_apk_workflow_update


📝 Commits (2)

  • 5d29efe Update: upload_artifact to v4 due to deprecation
  • 1c302a7 Update deploy APK workflow

📊 Changes

2 files changed (+90 additions, -90 deletions)

View changed files

📝 .github/workflows/build-apk.yml (+38 -38)
📝 .github/workflows/deploy-apk.yml (+52 -52)

📄 Description

This PR updates the Android build workflows to use upload-artifact@v4 due to @v3 being deprecated on January 30, 2025 (which is tomorrow at the time of this writing). The upload-artifact changes can be seen in this GitHub blog post: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

The upload-pages-artifact is also updated according to https://github.com/actions/upload-pages-artifact to ensure that is on the most up to date version. This workflow updates the page hosted at https://advplyr.github.io/audiobookshelf-app/. I wonder if we still need this page because it is not really advertised anywhere and the APK can be downloaded from the workflow itself. However, the page is very nice and looks professional, but not sure about maintaining it if it breaks. A screenshot of the page is shown below.
APK download page


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1461 **Author:** [@nichwall](https://github.com/nichwall) **Created:** 1/30/2025 **Status:** ✅ Merged **Merged:** 1/31/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `build_apk_workflow_update` --- ### 📝 Commits (2) - [`5d29efe`](https://github.com/advplyr/audiobookshelf-app/commit/5d29efe1d5ee15c33de0412653a9df4a368a0cbe) Update: upload_artifact to v4 due to deprecation - [`1c302a7`](https://github.com/advplyr/audiobookshelf-app/commit/1c302a7ac161edc830b44e2be65536b3d32a201f) Update deploy APK workflow ### 📊 Changes **2 files changed** (+90 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-apk.yml` (+38 -38) 📝 `.github/workflows/deploy-apk.yml` (+52 -52) </details> ### 📄 Description This PR updates the Android build workflows to use `upload-artifact@v4` due to `@v3` being deprecated on January 30, 2025 (which is tomorrow at the time of this writing). The `upload-artifact` changes can be seen in this GitHub blog post: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ The `upload-pages-artifact` is also updated according to https://github.com/actions/upload-pages-artifact to ensure that is on the most up to date version. This workflow updates the page hosted at https://advplyr.github.io/audiobookshelf-app/. I wonder if we still need this page because it is not really advertised anywhere and the APK can be downloaded from the workflow itself. However, the page is very nice and looks professional, but not sure about maintaining it if it breaks. A screenshot of the page is shown below. ![APK download page](https://github.com/user-attachments/assets/3867d558-4d45-4d4f-b140-40ce13f2f4fa) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-24 23:59:29 +02:00
adam closed this issue 2026-04-24 23:59:30 +02:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1587