[PR #1417] [MERGED] Support servers with subdirectory #1576

Closed
opened 2026-04-24 23:59:24 +02:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1417
Author: @mikiher
Created: 12/23/2024
Status: Merged
Merged: 12/28/2024
Merged by: @advplyr

Base: masterHead: subdirectory-support


📝 Commits (1)

  • 16de3fd Support servers with subdirectory

📊 Changes

4 files changed (+22 additions, -12 deletions)

View changed files

📝 components/connection/ServerConnectForm.vue (+2 -3)
📝 plugins/capacitor/AbsAudioPlayer.js (+11 -5)
📝 plugins/server.js (+7 -2)
📝 store/globals.js (+2 -2)

📄 Description

This adds support for connecting to servers with subdirectory, e.g. https://my.server.com/audiobookself.

This is the last step in preparing for subdirectory support, based on the proposed plan.

The required changes include:

  • Allow paths when specifying the server address in the Connect form
  • Fix this.player.src in AbsAudioPlayer.js (all other changes in this file are due to formatting)
  • Connect to the correct WebSocket path
  • Fix getLibraryItemCoverSrc and getLibraryItemCoverSrcById in globals.js

I tested this using the web client, as well as on my Android phone against a server running with RouterBasePath=/audiobookshelf (which should support both subdirectory and non-subdirectory access).

  • I connected using the standard non-subdirectory address, and made sure everything was working
  • I then connected using the subdirectory address, and made sure everything was working.

I did not test on iOS, as I don't have an IOS dev environement nor an iOS phone to test on.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1417 **Author:** [@mikiher](https://github.com/mikiher) **Created:** 12/23/2024 **Status:** ✅ Merged **Merged:** 12/28/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `subdirectory-support` --- ### 📝 Commits (1) - [`16de3fd`](https://github.com/advplyr/audiobookshelf-app/commit/16de3fdb97e813b4b92087a09e2d67981efd7d28) Support servers with subdirectory ### 📊 Changes **4 files changed** (+22 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `components/connection/ServerConnectForm.vue` (+2 -3) 📝 `plugins/capacitor/AbsAudioPlayer.js` (+11 -5) 📝 `plugins/server.js` (+7 -2) 📝 `store/globals.js` (+2 -2) </details> ### 📄 Description This adds support for connecting to servers with subdirectory, e.g. `https://my.server.com/audiobookself`. This is the last step in preparing for subdirectory support, based on [the proposed plan](https://github.com/advplyr/audiobookshelf/discussions/3535). The required changes include: - Allow paths when specifying the server address in the Connect form - Fix `this.player.src` in `AbsAudioPlayer.js` (all other changes in this file are due to formatting) - Connect to the correct WebSocket path - Fix `getLibraryItemCoverSrc` and `getLibraryItemCoverSrcById` in `globals.js` I tested this using the web client, as well as on my Android phone against a server running with `RouterBasePath=/audiobookshelf` (which should support both subdirectory and non-subdirectory access). - I connected using the standard non-subdirectory address, and made sure everything was working - I then connected using the subdirectory address, and made sure everything was working. I _did not_ test on iOS, as I don't have an IOS dev environement nor an iOS phone to test on. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-24 23:59:24 +02:00
adam closed this issue 2026-04-24 23:59:25 +02:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1576