starred/audiobookshelf-app
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf-app.git synced 2026-07-26 06:28:43 +02:00
Code Issues 454 Packages Projects Releases 10 Wiki Activity

[PR #1383] [MERGED] Turn page while playing #1567

New Issue
Closed
opened 2026-04-24 23:59:21 +02:00 by adam · 0 comments
adam commented 2026-04-24 23:59:21 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1383
Author: @RaHoni
Created: 11/17/2024
Status: ✅ Merged
Merged: 12/13/2024
Merged by: @advplyr

Base: master ← Head: turn_page_while_playing

📝 Commits (4)

  • 12a3969 Add an EReader setting for turning when playing
  • 5801c8a Update navigate with volume while playing string, update reader settings to use the same LabelOn and LabelOff translations
  • fe7a41f Merge hu
  • f4d2178 Correct German Translation for new EReader Setting.

📊 Changes

18 files changed (+47 additions, -41 deletions)

View changed files

📝 components/readers/Reader.vue (+25 -6)
📝 strings/bn.json (+1 -2)
📝 strings/cs.json (+1 -2)
📝 strings/de.json (+2 -2)
📝 strings/en-us.json (+4 -2)
📝 strings/es.json (+1 -2)
📝 strings/fi.json (+1 -2)
📝 strings/fr.json (+1 -2)
📝 strings/hr.json (+1 -2)
📝 strings/hu.json (+2 -3)
📝 strings/it.json (+1 -2)
📝 strings/nl.json (+1 -2)
📝 strings/ru.json (+1 -2)
📝 strings/sl.json (+1 -2)
📝 strings/sv.json (+1 -2)
📝 strings/uk.json (+1 -2)
📝 strings/zh-cn.json (+1 -2)
📝 strings/zh_Hant.json (+1 -2)

📄 Description

This is a fix for #1365. This adds an additional settings that disables the check for playing when enabled.
The default for this setting is off.

But since while testing i noticed that the problem for #1374 was also showing up on the Virtual Pixel 7a. The simple fix was removing the half-screen option. @advplyr this does change the Settings to be full-screen. Is this okay or is there something else I should do?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1383 **Author:** [@RaHoni](https://github.com/RaHoni) **Created:** 11/17/2024 **Status:** ✅ Merged **Merged:** 12/13/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `turn_page_while_playing` --- ### 📝 Commits (4) - [`12a3969`](https://github.com/advplyr/audiobookshelf-app/commit/12a3969509fe0e9b55e8cec4c4f2a7880b7357ab) Add an EReader setting for turning when playing - [`5801c8a`](https://github.com/advplyr/audiobookshelf-app/commit/5801c8a15e0fcd0d3d2ad11e3fbf255b688e4edb) Update navigate with volume while playing string, update reader settings to use the same LabelOn and LabelOff translations - [`fe7a41f`](https://github.com/advplyr/audiobookshelf-app/commit/fe7a41fc1ade6e3cb230eaac366363e8e017ee36) Merge hu - [`f4d2178`](https://github.com/advplyr/audiobookshelf-app/commit/f4d2178b53142f7c3f3f453598d44b8f59c8f48e) Correct German Translation for new EReader Setting. ### 📊 Changes **18 files changed** (+47 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `components/readers/Reader.vue` (+25 -6) 📝 `strings/bn.json` (+1 -2) 📝 `strings/cs.json` (+1 -2) 📝 `strings/de.json` (+2 -2) 📝 `strings/en-us.json` (+4 -2) 📝 `strings/es.json` (+1 -2) 📝 `strings/fi.json` (+1 -2) 📝 `strings/fr.json` (+1 -2) 📝 `strings/hr.json` (+1 -2) 📝 `strings/hu.json` (+2 -3) 📝 `strings/it.json` (+1 -2) 📝 `strings/nl.json` (+1 -2) 📝 `strings/ru.json` (+1 -2) 📝 `strings/sl.json` (+1 -2) 📝 `strings/sv.json` (+1 -2) 📝 `strings/uk.json` (+1 -2) 📝 `strings/zh-cn.json` (+1 -2) 📝 `strings/zh_Hant.json` (+1 -2) </details> ### 📄 Description This is a fix for #1365. This adds an additional settings that disables the check for playing when enabled. The default for this setting is off. But since while testing i noticed that the problem for #1374 was also showing up on the Virtual Pixel 7a. The simple fix was removing the half-screen option. @advplyr this does change the Settings to be full-screen. Is this okay or is there something else I should do? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-24 23:59:21 +02:00
adam closed this issue 2026-04-24 23:59:21 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
android auto
backlog
bug
enhancement
ereader
help wanted
iOS
progress sync
pull-request
Mirrored from GitHub Pull Request
 sleep timer
unable to reproduce
waiting
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1567