starred/audiobookshelf-app
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf-app.git synced 2026-07-25 14:08:35 +02:00
Code Issues 454 Packages Projects Releases 10 Wiki Activity

[PR #1360] [MERGED] iOS devices have always networkConnected status true #1566

New Issue
Closed
opened 2026-04-24 23:59:21 +02:00 by adam · 0 comments
adam commented 2026-04-24 23:59:21 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1360
Author: @ISO-B
Created: 11/3/2024
Status: ✅ Merged
Merged: 11/3/2024
Merged by: @advplyr

Base: master ← Head: fix_remove_internet_connection_check

📝 Commits (1)

  • 358197d iOS devices have always networkConnected status true

📊 Changes

3 files changed (+9 additions, -4 deletions)

View changed files

📝 components/app/AudioPlayer.vue (+3 -3)
📝 pages/item/_id/index.vue (+1 -1)
📝 store/index.js (+5 -0)

📄 Description

#1359 fixed things only for Android app. Capacitor Network plugin only shows iOS device connected if internet access is available. This fix allows iOS users to use local server without internet access. Socket is used to detect if connection to server is availabe. networkConnected is only used for add server form and cellular permission check.

Cellular permissions for download and streaming wont work for iOS if device is connected to cellular, but without internet access to server that is used for connectivity check.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1360 **Author:** [@ISO-B](https://github.com/ISO-B) **Created:** 11/3/2024 **Status:** ✅ Merged **Merged:** 11/3/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix_remove_internet_connection_check` --- ### 📝 Commits (1) - [`358197d`](https://github.com/advplyr/audiobookshelf-app/commit/358197db035e2f792f83a55bdf9a0e4984b0f594) iOS devices have always networkConnected status true ### 📊 Changes **3 files changed** (+9 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `components/app/AudioPlayer.vue` (+3 -3) 📝 `pages/item/_id/index.vue` (+1 -1) 📝 `store/index.js` (+5 -0) </details> ### 📄 Description #1359 fixed things only for Android app. Capacitor Network plugin only shows iOS device connected if internet access is available. This fix allows iOS users to use local server without internet access. Socket is used to detect if connection to server is availabe. networkConnected is only used for add server form and cellular permission check. Cellular permissions for download and streaming wont work for iOS if device is connected to cellular, but without internet access to server that is used for connectivity check. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-24 23:59:21 +02:00
adam closed this issue 2026-04-24 23:59:21 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
android auto
backlog
bug
enhancement
ereader
help wanted
iOS
progress sync
pull-request
Mirrored from GitHub Pull Request
 sleep timer
unable to reproduce
waiting
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1566