[PR #1359] [MERGED] Changed network connection check logic #1562

New Issue

2026-04-24T23:59:19+02:00

adam commented

2026-04-24 23:59:19 +02:00

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1359
Author: @ISO-B
Created: 10/31/2024
Status: ✅ Merged
Merged: 11/2/2024
Merged by: @advplyr

Base: master ← Head: fix_remove_internet_connection_check

📝 Commits (1)

fe9168c Changed network connection check logic

📊 Changes

4 files changed (+29 additions, -25 deletions)

View changed files

📝 components/app/Appbar.vue (+4 -4)
📝 components/tables/podcast/EpisodesTable.vue (+4 -4)
📝 pages/bookshelf/add-podcast.vue (+4 -4)
📝 store/index.js (+17 -13)

📄 Description

Network connection no longer requires internet connection. Socket connection status is used instead for checking if server is reachable. If there is no socket connection available eq. before connecting to server then connection type is used to for network connection check.

This should fix #566

Test cases, tested with Android 11 and 14:

Wifi connection with access to internet. Everything worked as previously
Wifi connection without access to internet. I was able to change server, browse library and stream content
Cellular connection with VPN to allow access to server. Everything worked as previously
Cellular connection without VPN, no access to server. Offline mode, but I was able to try connection to different server/adding new server
No wifi or cellular connection. Offline mode, adding new server shows no network connection.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1359 **Author:** [@ISO-B](https://github.com/ISO-B) **Created:** 10/31/2024 **Status:** ✅ Merged **Merged:** 11/2/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix_remove_internet_connection_check` --- ### 📝 Commits (1) - [`fe9168c`](https://github.com/advplyr/audiobookshelf-app/commit/fe9168c6cf505e9c632f662ae0db14256e5fbe93) Changed network connection check logic ### 📊 Changes **4 files changed** (+29 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `components/app/Appbar.vue` (+4 -4) 📝 `components/tables/podcast/EpisodesTable.vue` (+4 -4) 📝 `pages/bookshelf/add-podcast.vue` (+4 -4) 📝 `store/index.js` (+17 -13) </details> ### 📄 Description Network connection no longer requires internet connection. Socket connection status is used instead for checking if server is reachable. If there is no socket connection available eq. before connecting to server then connection type is used to for network connection check. This should fix #566 Test cases, tested with Android 11 and 14: 1. Wifi connection with access to internet. Everything worked as previously 2. Wifi connection without access to internet. I was able to change server, browse library and stream content 3. Cellular connection with VPN to allow access to server. Everything worked as previously 4. Cellular connection without VPN, no access to server. Offline mode, but I was able to try connection to different server/adding new server 5. No wifi or cellular connection. Offline mode, adding new server shows no network connection. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-04-24 23:59:19 +02:00

adam closed this issue

2026-04-24 23:59:19 +02:00

adam referenced this issue

2026-04-24 23:59:45 +02:00

[PR #1562] [MERGED] Template updates #1619

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1562