I am used to reading EBooks with FBReader but since uploading all EBooks to ABS I wanted to use the ABS-App. Wich works great for the EPub files we have. But I missed the possibility to turn the Pages by pressing Volume down. This was more convenient and in my Opinion more ergonomic.
The default config is to use the Down-Key for next page and theUp-Key for previous.
I have a few questions about this PR:
I have put the option to change the use of the Volume Keys into the reader settings, is this the right place?
I am not sure about the wording to use in the settings.
Wich should be the default setting? On as used by FBReader or Off as to not obstruct the change of the Volume for users who don't know the settings?
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1302
**Author:** [@RaHoni](https://github.com/RaHoni)
**Created:** 8/30/2024
**Status:** ✅ Merged
**Merged:** 9/8/2024
**Merged by:** [@advplyr](https://github.com/advplyr)
**Base:** `master` ← **Head:** `navigate_with_volume`
---
### 📝 Commits (2)
- [`8a6a2b8`](https://github.com/advplyr/audiobookshelf-app/commit/8a6a2b8577cc79e11704e317fd43c3c38359c1d1) Make it possible to turn the page with volume keys
- [`612a7a7`](https://github.com/advplyr/audiobookshelf-app/commit/612a7a70639fff8a547e531ca35976690e3dba47) Epub ereader volume navigate setting fixes and disable when player is open
### 📊 Changes
**9 files changed** (+103 additions, -3 deletions)
<details>
<summary>View changed files</summary>
📝 `android/app/capacitor.build.gradle` (+1 -0)
📝 `android/app/src/main/assets/capacitor.plugins.json` (+4 -0)
📝 `android/capacitor.settings.gradle` (+3 -0)
📝 `components/readers/Reader.vue` (+72 -3)
📝 `ios/App/Podfile` (+1 -0)
📝 `package-lock.json` (+13 -0)
📝 `package.json` (+1 -0)
📝 `strings/de.json` (+4 -0)
📝 `strings/en-us.json` (+4 -0)
</details>
### 📄 Description
I am used to reading EBooks with FBReader but since uploading all EBooks to ABS I wanted to use the ABS-App. Wich works great for the EPub files we have. But I missed the possibility to turn the Pages by pressing Volume down. This was more convenient and in my Opinion more ergonomic.
The default config is to use the Down-Key for next page and theUp-Key for previous.
I have a few questions about this PR:
1. I have put the option to change the use of the Volume Keys into the reader settings, is this the right place?
2. I am not sure about the wording to use in the settings.
3. Wich should be the default setting? On as used by FBReader or Off as to not obstruct the change of the Volume for users who don't know the settings?
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1302
Author: @RaHoni
Created: 8/30/2024
Status: ✅ Merged
Merged: 9/8/2024
Merged by: @advplyr
Base:
master← Head:navigate_with_volume📝 Commits (2)
8a6a2b8Make it possible to turn the page with volume keys612a7a7Epub ereader volume navigate setting fixes and disable when player is open📊 Changes
9 files changed (+103 additions, -3 deletions)
View changed files
📝
android/app/capacitor.build.gradle(+1 -0)📝
android/app/src/main/assets/capacitor.plugins.json(+4 -0)📝
android/capacitor.settings.gradle(+3 -0)📝
components/readers/Reader.vue(+72 -3)📝
ios/App/Podfile(+1 -0)📝
package-lock.json(+13 -0)📝
package.json(+1 -0)📝
strings/de.json(+4 -0)📝
strings/en-us.json(+4 -0)📄 Description
I am used to reading EBooks with FBReader but since uploading all EBooks to ABS I wanted to use the ABS-App. Wich works great for the EPub files we have. But I missed the possibility to turn the Pages by pressing Volume down. This was more convenient and in my Opinion more ergonomic.
The default config is to use the Down-Key for next page and theUp-Key for previous.
I have a few questions about this PR:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.