[PR #1210] [MERGED] Add settings to limit Cellular Data (Download/Streaming) #1522

New Issue

2026-04-24T23:59:02+02:00

adam commented

2026-04-24 23:59:02 +02:00

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1210
Author: @mfcar
Created: 5/23/2024
Status: ✅ Merged
Merged: 6/4/2024
Merged by: @advplyr

Base: master ← Head: mf/limitCellularData

📝 Commits (7)

d788623 Initial work
574dda5 Fix android build
4ad54f3 Improvements and fixes on the cellular permissions
d42cbfe Revert podcast episode local playback event
d4e8afc Map translation strings
41477fd Merge translation strings
b6824cf Fix:Latest podcast episodes to play local

📊 Changes

35 files changed (+479 additions, -76 deletions)

View changed files

📝 android/app/src/main/java/com/audiobookshelf/app/data/DeviceClasses.kt (+14 -2)
📝 android/app/src/main/java/com/audiobookshelf/app/device/DeviceManager.kt (+8 -0)
📝 components/app/AudioPlayerContainer.vue (+13 -2)
📝 components/tables/podcast/EpisodeRow.vue (+5 -0)
📝 components/tables/podcast/LatestEpisodeRow.vue (+11 -2)
📝 ios/App/App/AppDelegate.swift (+8 -1)
📝 ios/App/App/plugins/AbsDatabase.swift (+39 -35)
📝 ios/App/Shared/models/DeviceSettings.swift (+5 -1)
➕ mixins/cellularPermissionHelpers.js (+42 -0)
📝 pages/bookshelf/latest.vue (+6 -4)
📝 pages/item/_id/_episode/index.vue (+5 -0)
📝 pages/item/_id/index.vue (+7 -3)
📝 pages/settings.vue (+73 -1)
📝 store/index.js (+9 -1)
📝 strings/cs.json (+11 -1)
📝 strings/da.json (+11 -1)
📝 strings/de.json (+12 -2)
📝 strings/en-us.json (+12 -2)
📝 strings/es.json (+11 -1)
📝 strings/fr.json (+11 -1)

...and 15 more files

📄 Description

This PR add a new category on the settings page, "Data Settings" with two configurable options:

Download using Cellular
Streaming using Cellular

These settings provide users with control over their data usage on cellular networks. The available options for these settings are:

Always (default): This option allows unrestricted use of download and streaming features over cellular data. This option is set as the default to avoid migration issues, as this is the actual standard behavior.
Never: This option blocks both downloading and streaming over cellular data, displaying an error toast when attempted. [Image 2]
Ask for confirmation*: This option prompts the user for confirmation before initiating a download or streaming over cellular data. [Image 3]

*If the audio is already downloaded, the confirmation alert is not displayed.

Image 2

Image 3

What is missing:

~~- For now this feature is only implemented on the latest podcast episodes page, needs to be applied on the other pages that contains the play and download buttons~~
~~- The features have been tested in a web browser. I need to test on mobile devices (but I only able to test on iOS)~~ https://github.com/advplyr/audiobookshelf-app/pull/1210#issuecomment-2132397578
~~- Improve phrasing~~

Demo:

https://github.com/advplyr/audiobookshelf-app/assets/814828/e40b24f4-79da-4ab5-83ec-32d1b50330ae

Feedback is appreciated

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1210 **Author:** [@mfcar](https://github.com/mfcar) **Created:** 5/23/2024 **Status:** ✅ Merged **Merged:** 6/4/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `mf/limitCellularData` --- ### 📝 Commits (7) - [`d788623`](https://github.com/advplyr/audiobookshelf-app/commit/d7886235097f723858e3fd41fe255b37e3063d24) Initial work - [`574dda5`](https://github.com/advplyr/audiobookshelf-app/commit/574dda528694dd0bc876a74ad4150780e5738265) Fix android build - [`4ad54f3`](https://github.com/advplyr/audiobookshelf-app/commit/4ad54f34fe4adbee5089611fc5d20efa5686eb20) Improvements and fixes on the cellular permissions - [`d42cbfe`](https://github.com/advplyr/audiobookshelf-app/commit/d42cbfe3e46e6e1e55bdc73fa20ea3bc782a8981) Revert podcast episode local playback event - [`d4e8afc`](https://github.com/advplyr/audiobookshelf-app/commit/d4e8afc2f1cdb93d9f3961eae136ce73d83154a6) Map translation strings - [`41477fd`](https://github.com/advplyr/audiobookshelf-app/commit/41477fdac142401f11cf8f6615ffa8d19f449651) Merge translation strings - [`b6824cf`](https://github.com/advplyr/audiobookshelf-app/commit/b6824cf242554c57e7ba4a537b57c6bd7213c8d7) Fix:Latest podcast episodes to play local ### 📊 Changes **35 files changed** (+479 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `android/app/src/main/java/com/audiobookshelf/app/data/DeviceClasses.kt` (+14 -2) 📝 `android/app/src/main/java/com/audiobookshelf/app/device/DeviceManager.kt` (+8 -0) 📝 `components/app/AudioPlayerContainer.vue` (+13 -2) 📝 `components/tables/podcast/EpisodeRow.vue` (+5 -0) 📝 `components/tables/podcast/LatestEpisodeRow.vue` (+11 -2) 📝 `ios/App/App/AppDelegate.swift` (+8 -1) 📝 `ios/App/App/plugins/AbsDatabase.swift` (+39 -35) 📝 `ios/App/Shared/models/DeviceSettings.swift` (+5 -1) ➕ `mixins/cellularPermissionHelpers.js` (+42 -0) 📝 `pages/bookshelf/latest.vue` (+6 -4) 📝 `pages/item/_id/_episode/index.vue` (+5 -0) 📝 `pages/item/_id/index.vue` (+7 -3) 📝 `pages/settings.vue` (+73 -1) 📝 `store/index.js` (+9 -1) 📝 `strings/cs.json` (+11 -1) 📝 `strings/da.json` (+11 -1) 📝 `strings/de.json` (+12 -2) 📝 `strings/en-us.json` (+12 -2) 📝 `strings/es.json` (+11 -1) 📝 `strings/fr.json` (+11 -1) _...and 15 more files_ </details> ### 📄 Description This PR add a new category on the settings page, "Data Settings" with two configurable options: - Download using Cellular - Streaming using Cellular <img width="463" alt="Screenshot 2024-05-23 at 22 52 10" src="https://github.com/advplyr/audiobookshelf-app/assets/814828/02d5a675-9e6d-4281-89a7-296e831f8b56"> --- These settings provide users with control over their data usage on cellular networks. The available options for these settings are: - Always (default): This option allows unrestricted use of download and streaming features over cellular data. This option is set as the default to avoid migration issues, as this is the actual standard behavior. - Never: This option blocks both downloading and streaming over cellular data, displaying an error toast when attempted. [Image 2] - Ask for confirmation*: This option prompts the user for confirmation before initiating a download or streaming over cellular data. [Image 3] *If the audio is already downloaded, the confirmation alert is not displayed. <img width="463" alt="Screenshot 2024-05-23 at 22 51 32" src="https://github.com/advplyr/audiobookshelf-app/assets/814828/f24f5180-17d5-471b-aed0-138d1af195ba"> Image 2 <img width="463" alt="Screenshot 2024-05-23 at 22 51 49" src="https://github.com/advplyr/audiobookshelf-app/assets/814828/70e286a8-a977-4ea3-bb30-1ebc817885e9"> Image 3 --- ### What is missing: ~~- For now this feature is only implemented on the latest podcast episodes page, needs to be applied on the other pages that contains the play and download buttons~~ ~~- The features have been tested in a web browser. I need to test on mobile devices (but I only able to test on iOS)~~ https://github.com/advplyr/audiobookshelf-app/pull/1210#issuecomment-2132397578 ~~- Improve phrasing~~ --- ### Demo: https://github.com/advplyr/audiobookshelf-app/assets/814828/e40b24f4-79da-4ab5-83ec-32d1b50330ae --- Feedback is appreciated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-04-24 23:59:02 +02:00

adam closed this issue

2026-04-24 23:59:02 +02:00

adam referenced this issue

2026-04-24 23:59:40 +02:00

[PR #1522] [MERGED] sort podcasts by filename; display filename in table row #1607

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1522