[PR #1205] [MERGED] Fix bug iOS AudioPlayer where multiple calls to setupRemoteTransportC… #1517

New Issue

2026-04-24T23:59:00+02:00

adam commented

2026-04-24 23:59:00 +02:00

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1205
Author: @indiefan
Created: 5/17/2024
Status: ✅ Merged
Merged: 5/18/2024
Merged by: @advplyr

Base: master ← Head: command-target-duplication-fix

📝 Commits (1)

984f01d Fix bug iOS AudioPlayer where multiple calls to setupRemoteTransportControls resulted in duplicate MPRemoteCommand targets being applied for the same action.

📊 Changes

1 file changed (+9 additions, -0 deletions)

View changed files

📝 ios/App/Shared/player/AudioPlayer.swift (+9 -0)

📄 Description

…ontrols resulted in duplicate MPRemoteCommand targets being applied for the same action.

We call this multiple times to pick up settings changes for certain playback controls. This makes that safe, with the assumption that we don't actually ever want multiple targets defined on the same commandCenter action. If at some point we do want that, then we'll need to refactor this to do more state-management, but I figured it was better to start with the simple approach unless/until we need the more complex one.

Fixes #1141.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1205 **Author:** [@indiefan](https://github.com/indiefan) **Created:** 5/17/2024 **Status:** ✅ Merged **Merged:** 5/18/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `command-target-duplication-fix` --- ### 📝 Commits (1) - [`984f01d`](https://github.com/advplyr/audiobookshelf-app/commit/984f01da233b81a1598cfb808697dd6b856b278f) Fix bug iOS AudioPlayer where multiple calls to setupRemoteTransportControls resulted in duplicate MPRemoteCommand targets being applied for the same action. ### 📊 Changes **1 file changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `ios/App/Shared/player/AudioPlayer.swift` (+9 -0) </details> ### 📄 Description …ontrols resulted in duplicate MPRemoteCommand targets being applied for the same action. We call this multiple times to pick up settings changes for certain playback controls. This makes that safe, with the assumption that we don't actually ever want multiple targets defined on the same commandCenter action. If at some point we do want that, then we'll need to refactor this to do more state-management, but I figured it was better to start with the simple approach unless/until we need the more complex one. Fixes #1141. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-04-24 23:59:00 +02:00

adam closed this issue

2026-04-24 23:59:00 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1517