[PR #1002] [MERGED] iOS Now Playing Chapter Track (updated #372) #1486

Closed
opened 2026-04-24 23:58:48 +02:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/1002
Author: @benonymity
Created: 12/23/2023
Status: Merged
Merged: 1/1/2024
Merged by: @advplyr

Base: masterHead: iosChapterTrack


📝 Commits (6)

  • 2b1667e feat: now playing chapter track
  • b11ad9d fix: only call on ios and remove...very professional logging
  • bb656a2 fix: broken isIos
  • 73d70dd Merge branch 'master' into iosChapterTrack
  • 322cad5 Move AbsAudioPlayer.setChapterTrack to AudioPlayer instead of localStore
  • 3cc7a09 Fix seeking in NowPlaying to adjust for chapter start time

📊 Changes

12 files changed (+103 additions, -14 deletions)

View changed files

📝 components/app/AudioPlayer.vue (+9 -2)
📝 ios/App/App/AppDelegate.swift (+13 -6)
📝 ios/App/App/plugins/AbsAudioPlayer.m (+1 -0)
📝 ios/App/App/plugins/AbsAudioPlayer.swift (+11 -0)
📝 ios/App/Shared/models/PlaybackSession.swift (+8 -0)
📝 ios/App/Shared/models/PlayerSettings.swift (+2 -0)
📝 ios/App/Shared/models/server/Chapter.swift (+10 -0)
📝 ios/App/Shared/player/AudioPlayer.swift (+24 -2)
📝 ios/App/Shared/player/PlayerHandler.swift (+4 -0)
📝 ios/App/Shared/util/NowPlayingInfo.swift (+14 -2)
📝 plugins/capacitor/AbsAudioPlayer.js (+6 -1)
📝 plugins/localStore.js (+1 -1)

📄 Description

This is all of @ronaldheft's work from #372 tied into the chapter track setting of the webView player. The only thing I'm unsure about is whether the setChapterTrack route for AbsAudioPlayer needs to be implemented on the Android side as well. I don't have an Android to test whether the route being called causes any errors, but it compiles and works perfectly on iOS.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/1002 **Author:** [@benonymity](https://github.com/benonymity) **Created:** 12/23/2023 **Status:** ✅ Merged **Merged:** 1/1/2024 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `iosChapterTrack` --- ### 📝 Commits (6) - [`2b1667e`](https://github.com/advplyr/audiobookshelf-app/commit/2b1667e532c7b02aa3676fcc1f4e6d00e44f1ecc) feat: now playing chapter track - [`b11ad9d`](https://github.com/advplyr/audiobookshelf-app/commit/b11ad9dc5bb65c49b1ab13abc2b0dc5dc50658bb) fix: only call on ios and remove...very professional logging - [`bb656a2`](https://github.com/advplyr/audiobookshelf-app/commit/bb656a265ff3ab21618ce141d09c237f5a53b163) fix: broken isIos - [`73d70dd`](https://github.com/advplyr/audiobookshelf-app/commit/73d70dd4807e989056b92c0b12b16b8b1fa5145c) Merge branch 'master' into iosChapterTrack - [`322cad5`](https://github.com/advplyr/audiobookshelf-app/commit/322cad554837f666e5096b4248a768b1f54ffeb7) Move AbsAudioPlayer.setChapterTrack to AudioPlayer instead of localStore - [`3cc7a09`](https://github.com/advplyr/audiobookshelf-app/commit/3cc7a0937c562dbb1415eee93cdb6de95bbac723) Fix seeking in NowPlaying to adjust for chapter start time ### 📊 Changes **12 files changed** (+103 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `components/app/AudioPlayer.vue` (+9 -2) 📝 `ios/App/App/AppDelegate.swift` (+13 -6) 📝 `ios/App/App/plugins/AbsAudioPlayer.m` (+1 -0) 📝 `ios/App/App/plugins/AbsAudioPlayer.swift` (+11 -0) 📝 `ios/App/Shared/models/PlaybackSession.swift` (+8 -0) 📝 `ios/App/Shared/models/PlayerSettings.swift` (+2 -0) 📝 `ios/App/Shared/models/server/Chapter.swift` (+10 -0) 📝 `ios/App/Shared/player/AudioPlayer.swift` (+24 -2) 📝 `ios/App/Shared/player/PlayerHandler.swift` (+4 -0) 📝 `ios/App/Shared/util/NowPlayingInfo.swift` (+14 -2) 📝 `plugins/capacitor/AbsAudioPlayer.js` (+6 -1) 📝 `plugins/localStore.js` (+1 -1) </details> ### 📄 Description This is all of @ronaldheft's work from #372 tied into the chapter track setting of the webView player. The only thing I'm unsure about is whether the setChapterTrack route for AbsAudioPlayer needs to be implemented on the Android side as well. I don't have an Android to test whether the route being called causes any errors, but it compiles and works perfectly on iOS. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-24 23:58:48 +02:00
adam closed this issue 2026-04-24 23:58:48 +02:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1486