starred/audiobookshelf-app
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf-app.git synced 2026-07-26 14:38:39 +02:00
Code Issues 454 Packages Projects Releases 10 Wiki Activity

[PR #565] [MERGED] fix: [iOS] seek pauses playback #1451

New Issue
Closed
opened 2026-04-24 23:58:33 +02:00 by adam · 0 comments
adam commented 2026-04-24 23:58:33 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/565
Author: @jramer
Created: 2/9/2023
Status: ✅ Merged
Merged: 2/19/2023
Merged by: @advplyr

Base: master ← Head: master

📝 Commits (9)

  • cbd74d0 fix: seek pauses playback
  • ef46ad7 fix: removes some warnings
  • b73763a fix: Fixes streaming issues
  • f4b05a3 Clarify state
  • 9496ee1 Merge branch 'master' of github.com:advplyr/audiobookshelf-app
  • 018a988 Merge branch 'master' into jramer/master
  • c9ad0c7 Merge branch 'master' of github.com:jramer/audiobookshelf-app
  • 3318f35 fix: seek when changing track
  • 7575a4f Merge branch 'master' into jramer/master

📊 Changes

7 files changed (+73 additions, -63 deletions)

View changed files

📝 components/app/AudioPlayer.vue (+0 -2)
📝 ios/App/App/plugins/AbsAudioPlayer.swift (+4 -4)
📝 ios/App/Shared/models/PlaybackMetadata.swift (+4 -4)
📝 ios/App/Shared/models/PlayerState.swift (+5 -5)
📝 ios/App/Shared/player/AudioPlayer.swift (+52 -39)
📝 ios/App/Shared/player/PlayerHandler.swift (+7 -8)
📝 ios/App/Shared/util/ApiClient.swift (+1 -1)

📄 Description

Fix for #518

  • Removes the pausing on seek which improves seek behaviour. Works for downloaded and streaming books but still sometimes pauses when streaming. (seems related to not getting data fast enough and errors from db)
  • Tries to improve on sending metadata by using the same data structure as android.
  • Removes some warnings

Needs some extra testing. Works with my .m4b and .mp3 books but would be good to try with many files (switching files while seeking) and maybe older ios versions.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/565 **Author:** [@jramer](https://github.com/jramer) **Created:** 2/9/2023 **Status:** ✅ Merged **Merged:** 2/19/2023 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (9) - [`cbd74d0`](https://github.com/advplyr/audiobookshelf-app/commit/cbd74d08e1e65d1754a5bc85b04182f0620d056f) fix: seek pauses playback - [`ef46ad7`](https://github.com/advplyr/audiobookshelf-app/commit/ef46ad7a938325be0f43f7738dfb7a9b8944b411) fix: removes some warnings - [`b73763a`](https://github.com/advplyr/audiobookshelf-app/commit/b73763a9ec4feb947371fb0f1f2d7616bcc8cf38) fix: Fixes streaming issues - [`f4b05a3`](https://github.com/advplyr/audiobookshelf-app/commit/f4b05a323633e990947413611a137cce112aee32) Clarify state - [`9496ee1`](https://github.com/advplyr/audiobookshelf-app/commit/9496ee1d9797d5e8b2abbd735143c68f78db6437) Merge branch 'master' of github.com:advplyr/audiobookshelf-app - [`018a988`](https://github.com/advplyr/audiobookshelf-app/commit/018a98812470aa18f231f87d7fc72ae054afa768) Merge branch 'master' into jramer/master - [`c9ad0c7`](https://github.com/advplyr/audiobookshelf-app/commit/c9ad0c789797a724182f78f60167cc7484b14d93) Merge branch 'master' of github.com:jramer/audiobookshelf-app - [`3318f35`](https://github.com/advplyr/audiobookshelf-app/commit/3318f3501c547e521cf47343384232a31ca2eef5) fix: seek when changing track - [`7575a4f`](https://github.com/advplyr/audiobookshelf-app/commit/7575a4f8831e125bfcb39e041b762f61abe008ca) Merge branch 'master' into jramer/master ### 📊 Changes **7 files changed** (+73 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `components/app/AudioPlayer.vue` (+0 -2) 📝 `ios/App/App/plugins/AbsAudioPlayer.swift` (+4 -4) 📝 `ios/App/Shared/models/PlaybackMetadata.swift` (+4 -4) 📝 `ios/App/Shared/models/PlayerState.swift` (+5 -5) 📝 `ios/App/Shared/player/AudioPlayer.swift` (+52 -39) 📝 `ios/App/Shared/player/PlayerHandler.swift` (+7 -8) 📝 `ios/App/Shared/util/ApiClient.swift` (+1 -1) </details> ### 📄 Description Fix for #518 * Removes the pausing on seek which improves seek behaviour. Works for downloaded and streaming books ~but still sometimes pauses when streaming. (seems related to not getting data fast enough and errors from db)~ * Tries to improve on sending metadata by using the same data structure as android. * Removes some warnings Needs some extra testing. Works with my .m4b and .mp3 books but would be good to try with many files (switching files while seeking) and maybe older ios versions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-24 23:58:33 +02:00
adam closed this issue 2026-04-24 23:58:35 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
android auto
backlog
bug
enhancement
ereader
help wanted
iOS
progress sync
pull-request
Mirrored from GitHub Pull Request
 sleep timer
unable to reproduce
waiting
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1451