starred/audiobookshelf-app
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf-app.git synced 2026-07-25 14:08:35 +02:00
Code Issues 454 Packages Projects Releases 10 Wiki Activity

[PR #455] [MERGED] Don't allow webview to scroll out of bounds vertically #1431

New Issue
Closed
opened 2026-04-24 23:58:24 +02:00 by adam · 0 comments
adam commented 2026-04-24 23:58:24 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/455
Author: @benonymity
Created: 12/7/2022
Status: ✅ Merged
Merged: 12/7/2022
Merged by: @advplyr

Base: master ← Head: vertical-bounce

📝 Commits (2)

  • 371fcac Fix: don't allow webview to scroll out of bounds vertically
  • a262efe Fix lockOrientation setting and add Realm db migration;

📊 Changes

7 files changed (+17 additions, -25 deletions)

View changed files

📝 android/app/src/main/res/xml/config.xml (+0 -4)
📝 ios/App/App/AppDelegate.swift (+7 -1)
📝 ios/App/App/config.xml (+0 -4)
📝 ios/App/App/plugins/AbsAudioPlayer.swift (+1 -0)
📝 ios/App/App/plugins/AbsDatabase.swift (+2 -2)
📝 ios/App/Podfile (+6 -7)
📝 ios/App/Shared/models/DeviceSettings.swift (+1 -7)

📄 Description

Prevents the app's webview from allowing a scroll of the actual app body, as per issue #5907 in the Capacitor repo. Previously the app could behave like this:
verticalScroll

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/455 **Author:** [@benonymity](https://github.com/benonymity) **Created:** 12/7/2022 **Status:** ✅ Merged **Merged:** 12/7/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `vertical-bounce` --- ### 📝 Commits (2) - [`371fcac`](https://github.com/advplyr/audiobookshelf-app/commit/371fcacc87854b48c88bc364f06716581d6b08bc) Fix: don't allow webview to scroll out of bounds vertically - [`a262efe`](https://github.com/advplyr/audiobookshelf-app/commit/a262efe9daac258c7b5ac3e17050f6d97132fb15) Fix lockOrientation setting and add Realm db migration; ### 📊 Changes **7 files changed** (+17 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `android/app/src/main/res/xml/config.xml` (+0 -4) 📝 `ios/App/App/AppDelegate.swift` (+7 -1) 📝 `ios/App/App/config.xml` (+0 -4) 📝 `ios/App/App/plugins/AbsAudioPlayer.swift` (+1 -0) 📝 `ios/App/App/plugins/AbsDatabase.swift` (+2 -2) 📝 `ios/App/Podfile` (+6 -7) 📝 `ios/App/Shared/models/DeviceSettings.swift` (+1 -7) </details> ### 📄 Description Prevents the app's webview from allowing a scroll of the actual app body, as per issue [#5907](https://github.com/ionic-team/capacitor/issues/5907) in the Capacitor repo. Previously the app could behave like this: ![verticalScroll](https://user-images.githubusercontent.com/62854267/206267623-dab4678b-e92a-4925-b85e-78d0ab5f49c3.jpg) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-24 23:58:24 +02:00
adam closed this issue 2026-04-24 23:58:24 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
android auto
backlog
bug
enhancement
ereader
help wanted
iOS
progress sync
pull-request
Mirrored from GitHub Pull Request
 sleep timer
unable to reproduce
waiting
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1431