starred/audiobookshelf-app
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf-app.git synced 2026-07-26 14:38:39 +02:00
Code Issues 454 Packages Projects Releases 10 Wiki Activity

[PR #398] [CLOSED] fix: iOS now playing widget does not always initialize with controls #1430

New Issue
Closed
opened 2026-04-24 23:58:24 +02:00 by adam · 0 comments
adam commented 2026-04-24 23:58:24 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/398
Author: @ronaldheft
Created: 9/23/2022
Status: ❌ Closed

Base: master ← Head: ios-now-playing-fixes

📝 Commits (10+)

  • abd5aa6 fix: Remove deprecated remote call
  • 564ba1a fix: Remove isEnabled calls
  • ba4243e Merge branch 'advplyr:master' into ios-now-playing-fixes
  • efe61b7 fix: Rate change in native code not reflect in UI
  • d46082d refactor: Use audio player rate directly
  • e606bcd fix: Use float consistently for playback rates
  • c1d3d5e fix: Media type should be audio
  • 3e06005 fix: Always update MediaCenter on main queue
  • 8c04931 fix: Unregister previous targets
  • 7fd2954 feat: Provide assert URL to NowPlaying

📊 Changes

5 files changed (+98 additions, -74 deletions)

View changed files

📝 components/app/AudioPlayer.vue (+1 -1)
📝 ios/App/Shared/player/AudioPlayer.swift (+42 -37)
📝 ios/App/Shared/player/AudioPlayerSleepTimer.swift (+1 -1)
📝 ios/App/Shared/player/PlayerHandler.swift (+2 -2)
📝 ios/App/Shared/util/NowPlayingInfo.swift (+52 -33)

📄 Description

Work in progress. Trying this fix.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/398 **Author:** [@ronaldheft](https://github.com/ronaldheft) **Created:** 9/23/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `ios-now-playing-fixes` --- ### 📝 Commits (10+) - [`abd5aa6`](https://github.com/advplyr/audiobookshelf-app/commit/abd5aa602248a61f4bdca58759b5ae04b838289f) fix: Remove deprecated remote call - [`564ba1a`](https://github.com/advplyr/audiobookshelf-app/commit/564ba1ae07e5e1597f5f638806bf24c696852c55) fix: Remove isEnabled calls - [`ba4243e`](https://github.com/advplyr/audiobookshelf-app/commit/ba4243ef68274ff4c66624ae0f4f8233db1ef424) Merge branch 'advplyr:master' into ios-now-playing-fixes - [`efe61b7`](https://github.com/advplyr/audiobookshelf-app/commit/efe61b7568c0b54b597d30e2d842542a5c972f01) fix: Rate change in native code not reflect in UI - [`d46082d`](https://github.com/advplyr/audiobookshelf-app/commit/d46082dd5bd0fcd6c553f3ad9417974d2bee4027) refactor: Use audio player rate directly - [`e606bcd`](https://github.com/advplyr/audiobookshelf-app/commit/e606bcd77ed01d562f83f0a1e23f5439b9651c49) fix: Use float consistently for playback rates - [`c1d3d5e`](https://github.com/advplyr/audiobookshelf-app/commit/c1d3d5e4f31a6a80b39005a5a9b7d8b18c79602e) fix: Media type should be audio - [`3e06005`](https://github.com/advplyr/audiobookshelf-app/commit/3e060052d167b95c3de66597e92fd0fbe841aaf2) fix: Always update MediaCenter on main queue - [`8c04931`](https://github.com/advplyr/audiobookshelf-app/commit/8c0493121b6b29d613e0ae5e3636355dd435ae4f) fix: Unregister previous targets - [`7fd2954`](https://github.com/advplyr/audiobookshelf-app/commit/7fd2954d45d35d2b6c9c813309d08117caab9b87) feat: Provide assert URL to NowPlaying ### 📊 Changes **5 files changed** (+98 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `components/app/AudioPlayer.vue` (+1 -1) 📝 `ios/App/Shared/player/AudioPlayer.swift` (+42 -37) 📝 `ios/App/Shared/player/AudioPlayerSleepTimer.swift` (+1 -1) 📝 `ios/App/Shared/player/PlayerHandler.swift` (+2 -2) 📝 `ios/App/Shared/util/NowPlayingInfo.swift` (+52 -33) </details> ### 📄 Description Work in progress. Trying this fix. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-24 23:58:24 +02:00
adam closed this issue 2026-04-24 23:58:24 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
android auto
backlog
bug
enhancement
ereader
help wanted
iOS
progress sync
pull-request
Mirrored from GitHub Pull Request
 sleep timer
unable to reproduce
waiting
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1430