[PR #393] [MERGED] fix: onReady called multiple times #1427

New Issue

2026-04-24T23:58:22+02:00

adam commented

2026-04-24 23:58:22 +02:00

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/393
Author: @ronaldheft
Created: 9/18/2022
Status: ✅ Merged
Merged: 9/19/2022
Merged by: @advplyr

Base: master ← Head: fix-on-ready-multiple-calls

📝 Commits (1)

e6d27a1 fix: onReady called multiple times

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 components/app/AudioPlayerContainer.vue (+4 -2)

📄 Description

Fixes a regression introduced in #386. By allowing onReady() to be called multiple times in the native code, it unearthed a situation where it was being called multiple times from the UI... when the playback rate changes.

This fix ensures that onReady() is only fired the first time settings are loaded, not every time.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/393 **Author:** [@ronaldheft](https://github.com/ronaldheft) **Created:** 9/18/2022 **Status:** ✅ Merged **Merged:** 9/19/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix-on-ready-multiple-calls` --- ### 📝 Commits (1) - [`e6d27a1`](https://github.com/advplyr/audiobookshelf-app/commit/e6d27a1487f775e92f4066a9a6deaee5c4f71139) fix: onReady called multiple times ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `components/app/AudioPlayerContainer.vue` (+4 -2) </details> ### 📄 Description Fixes a regression introduced in #386. By allowing `onReady()` to be called multiple times in the native code, it unearthed a situation where it was being called multiple times from the UI... when the playback rate changes. This fix ensures that `onReady()` is only fired the first time settings are loaded, not every time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-04-24 23:58:22 +02:00

adam closed this issue

2026-04-24 23:58:22 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1427