[PR #386] [MERGED] Fix various iOS app startup issues #1421

New Issue

2026-04-24T23:58:20+02:00

adam commented

2026-04-24 23:58:20 +02:00

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/386
Author: @ronaldheft
Created: 9/16/2022
Status: ✅ Merged
Merged: 9/16/2022
Merged by: @advplyr

Base: master ← Head: ios-general-fixes

📝 Commits (5)

713999e Fix deprecated and early window access warnings
7294bc7 Audio player modifications should be on main queue
b71a976 Merge remote-tracking branch 'upstream/master' into ios-general-fixes
141877f Fix Pods with iOS target change
e7f61e3 Fix player automatically starting after WebKit reload

📊 Changes

6 files changed (+66 additions, -51 deletions)

View changed files

📝 ios/App/App.xcodeproj/project.pbxproj (+12 -8)
📝 ios/App/App/AppDelegate.swift (+3 -3)
📝 ios/App/App/plugins/AbsAudioPlayer.swift (+2 -4)
📝 ios/App/Podfile (+1 -1)
📝 ios/App/Shared/player/AudioPlayer.swift (+39 -24)
📝 ios/App/Shared/player/PlayerHandler.swift (+9 -11)

📄 Description

This PR addresses a few different issues related to app startup:

Fixes a warnings related to accessing window too early
Fixes a crash where a race condition can cause the AudioPlayer's rate to be modified off the main queue
Fixes #374 by ensure if WebKit is reloaded and the native code is not, the two can get back in sync

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/386 **Author:** [@ronaldheft](https://github.com/ronaldheft) **Created:** 9/16/2022 **Status:** ✅ Merged **Merged:** 9/16/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `ios-general-fixes` --- ### 📝 Commits (5) - [`713999e`](https://github.com/advplyr/audiobookshelf-app/commit/713999eb83d08f58a250cde8b6190bdfc3d66064) Fix deprecated and early window access warnings - [`7294bc7`](https://github.com/advplyr/audiobookshelf-app/commit/7294bc703355b168796466816767e4468fd0d7e7) Audio player modifications should be on main queue - [`b71a976`](https://github.com/advplyr/audiobookshelf-app/commit/b71a976e61ae50252a7d869772435b3b4c9a52f6) Merge remote-tracking branch 'upstream/master' into ios-general-fixes - [`141877f`](https://github.com/advplyr/audiobookshelf-app/commit/141877f111eff60ac28aaea2a9fd7e30a42a4544) Fix Pods with iOS target change - [`e7f61e3`](https://github.com/advplyr/audiobookshelf-app/commit/e7f61e34e8b30a42ba1d108f4a44b8c777df8647) Fix player automatically starting after WebKit reload ### 📊 Changes **6 files changed** (+66 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `ios/App/App.xcodeproj/project.pbxproj` (+12 -8) 📝 `ios/App/App/AppDelegate.swift` (+3 -3) 📝 `ios/App/App/plugins/AbsAudioPlayer.swift` (+2 -4) 📝 `ios/App/Podfile` (+1 -1) 📝 `ios/App/Shared/player/AudioPlayer.swift` (+39 -24) 📝 `ios/App/Shared/player/PlayerHandler.swift` (+9 -11) </details> ### 📄 Description This PR addresses a few different issues related to app startup: - Fixes a warnings related to accessing `window` too early - Fixes a crash where a race condition can cause the AudioPlayer's rate to be modified off the main queue - Fixes #374 by ensure if WebKit is reloaded and the native code is not, the two can get back in sync --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2026-04-24 23:58:20 +02:00

adam closed this issue

2026-04-24 23:58:20 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1421