starred/audiobookshelf-app
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf-app.git synced 2026-07-24 21:48:42 +02:00
Code Issues 454 Packages Projects Releases 10 Wiki Activity

[PR #362] [MERGED] Fix marking local book as read crashing iOS app #1415

New Issue
Closed
opened 2026-04-24 23:58:17 +02:00 by adam · 0 comments
adam commented 2026-04-24 23:58:17 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/362
Author: @ronaldheft
Created: 9/3/2022
Status: ✅ Merged
Merged: 9/3/2022
Merged by: @advplyr

Base: master ← Head: fix-ios-mark-as-read-crash

📝 Commits (1)

  • 41753cd Fix marking as read crashing app

📊 Changes

1 file changed (+12 additions, -0 deletions)

View changed files

📝 ios/App/Shared/models/local/LocalMediaProgress.swift (+12 -0)

📄 Description

Fixes #348. This may actually be the fix for a few other crashes, as there could be other cases where the LocalMediaProgress did not have the id set.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/362 **Author:** [@ronaldheft](https://github.com/ronaldheft) **Created:** 9/3/2022 **Status:** ✅ Merged **Merged:** 9/3/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `fix-ios-mark-as-read-crash` --- ### 📝 Commits (1) - [`41753cd`](https://github.com/advplyr/audiobookshelf-app/commit/41753cd853b8467139890ca68e231d14ef867bd3) Fix marking as read crashing app ### 📊 Changes **1 file changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `ios/App/Shared/models/local/LocalMediaProgress.swift` (+12 -0) </details> ### 📄 Description Fixes #348. This may actually be the fix for a few other crashes, as there could be other cases where the `LocalMediaProgress` did not have the id set. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-24 23:58:17 +02:00
adam closed this issue 2026-04-24 23:58:18 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
android auto
backlog
bug
enhancement
ereader
help wanted
iOS
progress sync
pull-request
Mirrored from GitHub Pull Request
 sleep timer
unable to reproduce
waiting
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1415