starred/audiobookshelf-app
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf-app.git synced 2026-07-25 22:18:38 +02:00
Code Issues 454 Packages Projects Releases 10 Wiki Activity

[PR #355] [MERGED] Fixes iOS player seek issues with multi-track books #1412

New Issue
Closed
opened 2026-04-24 23:58:16 +02:00 by adam · 0 comments
adam commented 2026-04-24 23:58:16 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf-app/pull/355
Author: @ronaldheft
Created: 9/2/2022
Status: ✅ Merged
Merged: 9/2/2022
Merged by: @advplyr

Base: master ← Head: ios-bug-seek-multi-track

📝 Commits (4)

  • 6257c64 Fix race condition with the player queue
  • 50f6b15 Refactor to ensure we aren't missing any update time
  • 021d63d Fix seek jumping
  • c02adfa Fix typo in if statement

📊 Changes

1 file changed (+91 additions, -69 deletions)

View changed files

📝 ios/App/Shared/player/AudioPlayer.swift (+91 -69)

📄 Description

Fixes #350.

Note: I've observed that sometimes playback does stop when seeking. I logged this as #354. This was occurring before this PR as well. I will look at that too, but this is more important to get out the door.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/355 **Author:** [@ronaldheft](https://github.com/ronaldheft) **Created:** 9/2/2022 **Status:** ✅ Merged **Merged:** 9/2/2022 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `ios-bug-seek-multi-track` --- ### 📝 Commits (4) - [`6257c64`](https://github.com/advplyr/audiobookshelf-app/commit/6257c6488ba69412e7f7841f54e8d9c3ce0a4ac7) Fix race condition with the player queue - [`50f6b15`](https://github.com/advplyr/audiobookshelf-app/commit/50f6b15d233336d992d7f6f14c9b1bc5e21106bc) Refactor to ensure we aren't missing any update time - [`021d63d`](https://github.com/advplyr/audiobookshelf-app/commit/021d63d973f2382996b1d5af14df1c4468018050) Fix seek jumping - [`c02adfa`](https://github.com/advplyr/audiobookshelf-app/commit/c02adfa32615ce0cf62aa4fbea4c79bff686babe) Fix typo in if statement ### 📊 Changes **1 file changed** (+91 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `ios/App/Shared/player/AudioPlayer.swift` (+91 -69) </details> ### 📄 Description Fixes #350. Note: I've observed that sometimes playback does stop when seeking. I logged this as #354. This was occurring before this PR as well. I will look at that too, but this is more important to get out the door. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-24 23:58:16 +02:00
adam closed this issue 2026-04-24 23:58:16 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
android auto
backlog
bug
enhancement
ereader
help wanted
iOS
progress sync
pull-request
Mirrored from GitHub Pull Request
 sleep timer
unable to reproduce
waiting
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf-app#1412