49ad1ef Merge branch 'advplyr:master' into SwipeBack
📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝ios/App/App/plugins/AbsAudioPlayer.swift (+1 -1)
📄 Description
This isn't a good implementation of the idea, but allowing some form of swipe back gesture would be helpful for user experience to not reach for the back button. Maybe we could make this a dedicated plugin to enable and disable the gesture on item pages and disable elsewhere, as swiping back to previous library pages isn't very intuitive, but that makes this improvement exponentially more complex. I'll tinker with making it a plugin, this already exists but hasn't been updated in 3 years and calls deprecated methods. At this point I just threw a line in the middle of the AudioPlayer plugin to make it work.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/advplyr/audiobookshelf-app/pull/126
**Author:** [@benonymity](https://github.com/benonymity)
**Created:** 4/20/2022
**Status:** ✅ Merged
**Merged:** 4/23/2022
**Merged by:** [@advplyr](https://github.com/advplyr)
**Base:** `master` ← **Head:** `SwipeBack`
---
### 📝 Commits (2)
- [`a17b588`](https://github.com/advplyr/audiobookshelf-app/commit/a17b588e29523765ddf37cb7a1dec0421735b4b9) Hacky SwipeBack
- [`49ad1ef`](https://github.com/advplyr/audiobookshelf-app/commit/49ad1ef601d31f0b7a706b7e965ed2ada7b91802) Merge branch 'advplyr:master' into SwipeBack
### 📊 Changes
**1 file changed** (+1 additions, -1 deletions)
<details>
<summary>View changed files</summary>
📝 `ios/App/App/plugins/AbsAudioPlayer.swift` (+1 -1)
</details>
### 📄 Description
This isn't a good implementation of the idea, but allowing some form of swipe back gesture would be helpful for user experience to not reach for the back button. Maybe we could make this a dedicated plugin to enable and disable the gesture on item pages and disable elsewhere, as swiping back to previous library pages isn't very intuitive, but that makes this improvement exponentially more complex. I'll tinker with making it a plugin, [this](https://github.com/diiiary/capacitor-plugin-ios-swipe-back) already exists but hasn't been updated in 3 years and calls deprecated methods. At this point I just threw a line in the middle of the AudioPlayer plugin to make it work.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/advplyr/audiobookshelf-app/pull/126
Author: @benonymity
Created: 4/20/2022
Status: ✅ Merged
Merged: 4/23/2022
Merged by: @advplyr
Base:
master← Head:SwipeBack📝 Commits (2)
a17b588Hacky SwipeBack49ad1efMerge branch 'advplyr:master' into SwipeBack📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
ios/App/App/plugins/AbsAudioPlayer.swift(+1 -1)📄 Description
This isn't a good implementation of the idea, but allowing some form of swipe back gesture would be helpful for user experience to not reach for the back button. Maybe we could make this a dedicated plugin to enable and disable the gesture on item pages and disable elsewhere, as swiping back to previous library pages isn't very intuitive, but that makes this improvement exponentially more complex. I'll tinker with making it a plugin, this already exists but hasn't been updated in 3 years and calls deprecated methods. At this point I just threw a line in the middle of the AudioPlayer plugin to make it work.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.